Fixed
Status Update
No update yet.
Comments
ze...@google.com
The R8 build does include these files in our jar and they are not used/needed. I'll amend our build to avoid including them and merge it to the release branches.
ap...@google.com
Project: r8
Branch: master
commit 80533c96c4561ab997f18ce65dd2c0c6a37a33b5
Author: Ian Zerny <zerny@google.com>
Date: Thu Jan 24 10:32:09 2019
Don't include kotlin module files in distribution.
Bug: 123310328
Change-Id: Ie70d4b15f08ffc0e7b754c558079002bd6a84334
M build.gradle
https://r8-review.googlesource.com/33381
Branch: master
commit 80533c96c4561ab997f18ce65dd2c0c6a37a33b5
Author: Ian Zerny <zerny@google.com>
Date: Thu Jan 24 10:32:09 2019
Don't include kotlin module files in distribution.
Bug: 123310328
Change-Id: Ie70d4b15f08ffc0e7b754c558079002bd6a84334
M build.gradle
ap...@google.com
Project: r8
Branch: d8-1.3
commit 73a2e504b0edd45eac64b6f242346b2793eae1fe
Author: Søren Gjesse <sgjesse@google.com>
Date: Fri Jan 25 09:23:25 2019
Version 1.3.54
Manually applied: Don't include kotlin module files in distribution.
CL:https://r8-review.googlesource.com/c/r8/+/33381
Bug: 123310328
Change-Id: Ifa5057f0c09d864295e200c287fb3d54cd3c79bf
M build.gradle
M src/main/java/com/android/tools/r8/Version.java
https://r8-review.googlesource.com/33485
Branch: d8-1.3
commit 73a2e504b0edd45eac64b6f242346b2793eae1fe
Author: Søren Gjesse <sgjesse@google.com>
Date: Fri Jan 25 09:23:25 2019
Version 1.3.54
Manually applied: Don't include kotlin module files in distribution.
CL:
Bug: 123310328
Change-Id: Ifa5057f0c09d864295e200c287fb3d54cd3c79bf
M build.gradle
M src/main/java/com/android/tools/r8/Version.java
ap...@google.com
Project: r8
Branch: d8-1.4
commit 2fe3fcb0dc21ed70eb37cc74aae247deffc90d29
Author: Søren Gjesse <sgjesse@google.com>
Date: Fri Jan 25 09:12:36 2019
Version 1.4.30
Cherry-pick: Don't include kotlin module files in distribution.
CL:https://r8-review.googlesource.com/c/r8/+/33381
Bug: 123310328
Change-Id: I92dce45d6c031f2dd58780b0278a188142b21523
M build.gradle
M src/main/java/com/android/tools/r8/Version.java
https://r8-review.googlesource.com/33483
Branch: d8-1.4
commit 2fe3fcb0dc21ed70eb37cc74aae247deffc90d29
Author: Søren Gjesse <sgjesse@google.com>
Date: Fri Jan 25 09:12:36 2019
Version 1.4.30
Cherry-pick: Don't include kotlin module files in distribution.
CL:
Bug: 123310328
Change-Id: I92dce45d6c031f2dd58780b0278a188142b21523
M build.gradle
M src/main/java/com/android/tools/r8/Version.java
ag...@google.com
This change has landed in studio-3.3-dev and studio-3.4-dev. It has not yet landed in master, but will get there early next week when we do the weekly roll of R8 into studio.
xa...@google.com
Fantastic!
Description
The builder.jar file contains:
920 06-13-2018 13:29 META-INF/kotlin-stdlib-common.kotlin_module
2994 06-13-2018 13:30 META-INF/kotlin-stdlib.kotlin_module
125 08-16-2018 15:14 META-INF/kotlinx-metadata-jvm.kotlin_module
132 08-13-2018 10:58 META-INF/kotlinx-metadata.kotlin_module
101 08-16-2018 15:13 META-INF/metadata.jvm.kotlin_module
130 08-16-2018 15:13 META-INF/metadata.kotlin_module
These seems to be there because we embed r8 which includes a shadow copy of kotlin's stdlib.
This can trigger warnings when people build against builder.jar because these module files conflicts with the normal stdlib on the classpath.
We should remove them.