Fixed
Status Update
No update yet.
Comments
ve...@google.com
ve...@google.com
Hi Ed, Thank you so much for these suggestions. I've been reviewing them and merging them in. Hopefully it should be live. I've included a thank you note too in the article.
ev...@willowtreeapps.com
Great! Thanks a lot, I'll look for the live updates soon!
ev...@willowtreeapps.com
Attached bug reports
ve...@google.com
kc...@google.com
Oops, looks like this is related to
We need to support both of the cases
1) if the dialog is not showing or about to be shown, and there's lockout, we need to return the lockout error immediately
2) (this bug) if the dialog is showing, we want to delay a few seconds before dismissing the dialog / forwarding the result to the client
Josh do you have cycles to dig into this? I can't think of a clean solution right now but we can chat about it offline, maybe there's a simple way to fix this.
https://cs.corp.google.com/aosp-androidx/biometric/src/main/java/androidx/biometric/FingerprintHelperFragment.java?q=fingerprinthelperfragment.java+%22errMsgId+%3D%3D+BiometricPrompt.ERROR_LOCKOUT%22+file:%5Ebiometric/src/main/java/androidx/biometric/+package:%5Eaosp-androidx$&g=0&l=91
We need to support both of the cases
1) if the dialog is not showing or about to be shown, and there's lockout, we need to return the lockout error immediately
2) (this bug) if the dialog is showing, we want to delay a few seconds before dismissing the dialog / forwarding the result to the client
Josh do you have cycles to dig into this? I can't think of a clean solution right now but we can chat about it offline, maybe there's a simple way to fix this.
jo...@google.com
I'll try and get to this next week if that's okay.
kc...@google.com
3) Currently the FingerprintDialogFragment is shown regardless of lockout (which can result in a split second appearance), it's related to this bug and we should figure out a way to fix it as well.
kc...@google.com
aosp/929948 is merged, not sure why it didn't get closed here
Description
Artifact used androidx.biometric:biometric
Version used: 1.0.0-alpha03
Devices/Android versions reproduced on: 26, 27, 28
Note: this is a followup to
When an error is triggered from too many incorrect fingerprint attempts, the behavior is different before and after api 28.
Before api 28:
The dialog is immediately closed, not allowing the user to see what when wrong.
After api 28:
The dialog is shown for a couple of seconds with the error message, then closes itself.
This inconsistency is an issue because we don't know if we should show the error to the user ourselves. If we do, then the user will see the error presented twice > api 28, and if we don't there will be no indication on why it didn't work < api 28.