IssueTracker

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 3c819141d3be0a6194a6d02e5642942ac15d86af
Author: Daniel Santiago Rivera <danysantiago@google.com>
Date:   Mon Feb 04 10:39:54 2019

    Use JetBrains's Kotlin metadata library.
   
    Use kotlinx-metadata-jvm to read Kotlin's Metadata annotation
    information. This library has less of an API surface than kotlin-metdata
    meaning KotlinClassMetadataUtils only exposes what Room needs. However
    it does allows us to fix the JVM descriptors (JvmDescriptorUtils) that
    are needed to match annotation processing elements to kotlin metadata
    elements.
   
    Bug: 123767877
    Test: ./gradlew room:room-compiler:test \
                    room:integration-tests:room-testapp-kotlin:cC \
                    room:integration-tests:room-testapp:cC
   
    Change-Id: Iddbe3968865b32168144294e55765a77320a40da

M       buildSrc/src/main/kotlin/androidx/build/dependencies/Dependencies.kt
M       room/compiler/build.gradle
D       room/compiler/src/main/kotlin/androidx/room/ext/KotlinMetadataElement.kt
M       room/compiler/src/main/kotlin/androidx/room/ext/element_ext.kt
A       room/compiler/src/main/kotlin/androidx/room/kotlin/JvmDescriptorUtils.kt
A       room/compiler/src/main/kotlin/androidx/room/kotlin/KotlinClassMetadataUtils.kt
A       room/compiler/src/main/kotlin/androidx/room/kotlin/KotlinMetadataElement.kt
M       room/compiler/src/main/kotlin/androidx/room/processor/MethodProcessorDelegate.kt
M       room/compiler/src/main/kotlin/androidx/room/processor/PojoProcessor.kt
M       room/compiler/src/main/kotlin/androidx/room/writer/DaoWriter.kt
A       room/compiler/src/test/kotlin/androidx/room/kotlin/JvmDescriptorUtilsTest.kt
A       room/compiler/src/test/kotlin/androidx/room/kotlin/KotlinMetadataElementTest.kt
M       room/integration-tests/kotlintestapp/src/androidTest/java/androidx/room/integration/kotlintestapp/dao/BooksDao.kt
A       room/integration-tests/kotlintestapp/src/androidTest/java/androidx/room/integration/kotlintestapp/vo/AnswerConverter.kt

https://android-review.googlesource.com/894734
https://goto.google.com/android-sha1/3c819141d3be0a6194a6d02e5642942ac15d86af

Part of the issue is that the generated code eagerly prepares the query to avoid any mutation on the params, so even if a subscription thread is used, the invocation of the DAO method in the main thread will cause the exception. A have a fix in progress that just moves the query preparing and binding to the callable used for the Rx, it does mean that if a mutable list is passed as query params and such list is mutated before the query executes then the expected query result will be wrong. However, it is somewhat reasonable to assume developers using reactive paradigms understand such implications and thus data is passed along the stream and is not kept at a higher scope where it can be mutated.

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 65e8fda6d3506a52e490e3b2dc8a649697e96551
Author: Daniel Santiago Rivera <danysantiago@google.com>
Date:   Thu Jan 31 15:16:15 2019

    Compile / prepare queries lazily for prepared query DAO methods.
   
    This change makes it so that the sql statement is prepared / compiled
    lazily for deferred INSERT, UPDATE or DELETE DAO methods with @Query.
    This avoids performing IO in the main thread due to the sql statement
    being eagerly prepare.
   
    Bug: 123695593
    Test: ./gradlew room:room-compiler:test \
                    room:integration-tests:room-testapp-kotlin:cC \
                    room:integration-tests:room-testapp:cC
   
    Change-Id: If5d6755fa97d1cf521889dc5680c77c4347ba221

M       room/compiler/src/main/kotlin/androidx/room/solver/prepared/binder/CallablePreparedQueryResultBinder.kt
M       room/compiler/src/main/kotlin/androidx/room/solver/prepared/binder/InstantPreparedQueryResultBinder.kt
M       room/compiler/src/main/kotlin/androidx/room/solver/prepared/binder/PreparedQueryResultBinder.kt
M       room/compiler/src/main/kotlin/androidx/room/writer/DaoWriter.kt
M       room/compiler/src/test/data/daoWriter/output/DeletionDao.java
M       room/compiler/src/test/data/daoWriter/output/UpdateDao.java
M       room/integration-tests/kotlintestapp/src/androidTest/java/androidx/room/integration/kotlintestapp/test/RxJava2QueryTest.kt

https://android-review.googlesource.com/891677
https://goto.google.com/android-sha1/65e8fda6d3506a52e490e3b2dc8a649697e96551

A fix for this will be available in Room 2.1.0-alpha05

Not fixed in Beta 1

The code in DAO:

@Query("DELETE FROM project WHERE id = :projectId")
abstract fun deleteById(projectId: String): Completable

generates the following in DAO impl:

@Override
  public Completable deleteById(final String projectId) {
    final SupportSQLiteStatement _stmt = __preparedStmtOfDeleteById.acquire();
    int _argIndex = 1;
    if (projectId == null) {
      _stmt.bindNull(_argIndex);
    } else {
      _stmt.bindString(_argIndex, projectId);
    }
    return Completable.fromCallable(new Callable<Void>() {
      @Override
      public Void call() throws Exception {
        __db.beginTransaction();
        try {
          _stmt.executeUpdateDelete();
          __db.setTransactionSuccessful();
          return null;
        } finally {
          __db.endTransaction();
          __preparedStmtOfDeleteById.release(_stmt);
        }
      }
    });
  }

In this code, __preparedStmtOfDeleteById.acquire() is executed on main thread and crashes the app.

Sorry, ignore my comment above, it was my mistake.