Fixed
Status Update
Comments
ap...@google.com <ap...@google.com> #2
Project: platform/frameworks/support
Branch: androidx-master-dev
commit e098f49838f5505b77c47d0a88b675430338fc77
Author: Eugene Susla <eugenesusla@google.com>
Date: Tue Feb 04 16:42:20 2020
Allow conditional startActivityForResult in ActivityResultContract
This adds an extra superclass for ActivityResultContract, that allows
customizing the action to start the activity.
This allows the common "short-circuit" behavior.
Also allows us to get rid of permissions-specific APIs.
Bug: 137198065
Bug: 151110799
Test: use the testapp to manually trigger requests,
rotating phone in the process.
Change-Id: I9d1e6f5be70406194ea30a43980389fc985125f3
M activity/activity/api/1.2.0-alpha03.txt
M activity/activity/api/current.txt
M activity/activity/api/public_plus_experimental_1.2.0-alpha03.txt
M activity/activity/api/public_plus_experimental_current.txt
M activity/activity/api/restricted_1.2.0-alpha03.txt
M activity/activity/api/restricted_current.txt
M activity/activity/src/main/java/androidx/activity/ComponentActivity.java
M activity/activity/src/main/java/androidx/activity/result/ActivityResultRegistry.java
M activity/activity/src/main/java/androidx/activity/result/contract/ActivityResultContract.java
M activity/activity/src/main/java/androidx/activity/result/contract/ActivityResultContracts.java
https://android-review.googlesource.com/1238800
Branch: androidx-master-dev
commit e098f49838f5505b77c47d0a88b675430338fc77
Author: Eugene Susla <eugenesusla@google.com>
Date: Tue Feb 04 16:42:20 2020
Allow conditional startActivityForResult in ActivityResultContract
This adds an extra superclass for ActivityResultContract, that allows
customizing the action to start the activity.
This allows the common "short-circuit" behavior.
Also allows us to get rid of permissions-specific APIs.
Bug: 137198065
Bug: 151110799
Test: use the testapp to manually trigger requests,
rotating phone in the process.
Change-Id: I9d1e6f5be70406194ea30a43980389fc985125f3
M activity/activity/api/1.2.0-alpha03.txt
M activity/activity/api/current.txt
M activity/activity/api/public_plus_experimental_1.2.0-alpha03.txt
M activity/activity/api/public_plus_experimental_current.txt
M activity/activity/api/restricted_1.2.0-alpha03.txt
M activity/activity/api/restricted_current.txt
M activity/activity/src/main/java/androidx/activity/ComponentActivity.java
M activity/activity/src/main/java/androidx/activity/result/ActivityResultRegistry.java
M activity/activity/src/main/java/androidx/activity/result/contract/ActivityResultContract.java
M activity/activity/src/main/java/androidx/activity/result/contract/ActivityResultContracts.java
Description
For example:
@Query("SELECT 0 FROM book")
suspend fun getZero(param : EnumConverter.Answer)
has the following jvm signature:
getZero(Landroidx/room/integration/kotlintestapp/vo/EnumConverter/Answer;Lkotlin/coroutines/Continuation;)Ljava/lang/Object;
which is different from the metadata siganture:
getZero(Landroidx/room/integration/kotlintestapp/vo/EnumConverter$Answer;Lkotlin/coroutines/Continuation;)Ljava/lang/Object;
hence we fail to read kotlin metadata out of it, and more specifically we can't figure out if it has a suspend modifier or not.