App crashing on rotation with: java.lang.IllegalStateException: unknown destination during restore [123803044]

Fixed

Bug

Status Update

No update yet.

Description

ar...@gmail.com

created issue #1

Feb 3, 2019 01:59AM

Component used: Navigation
Version used: 1.0.0-alpha11
Devices/Android versions reproduced on: Nexus 5X API 27

I've implemented conditional navigation for my login flow as described in this SO post:

https://stackoverflow.com/questions/51582674/navigation-architecture-component-login-screen

Now everything appears to be working, however after being navigated to the login screen and successfully logging in then navigating back to the main screen, on rotation the app crashes with the error: "java.lang.IllegalStateException: unknown destination during restore".

I've created a SO post containing the full error and navgraph for my project:

https://stackoverflow.com/q/54496008/7648952

I've also reproduced the error in this sample app:

https://github.com/sbearben/NavigationCrashSampleApp

For a bit of further information it appears this crash started to occur in version 1.0.0-alpha08.

Comments

il...@google.com <il...@google.com> Feb 3, 2019 06:19AM

Assigned to il...@google.com.

ar...@gmail.com <ar...@gmail.com> #2Feb 3, 2019 08:53PM

The removal of the nested graphs and using popUpTo the given fragment appears to prevent the crash from happening in 1.0.0-alpha11.

il...@google.com <il...@google.com> Feb 3, 2019 11:19PM

Accepted by il...@google.com.

ap...@google.com <ap...@google.com> #3Feb 4, 2019 05:18PM

Project: platform/prebuilts/androidx/internal
Branch: androidx-master-dev

commit 63bc1ff1fe7c348138295ee7efb8cdc2999622c0
Author: Ian Lake <ilake@google.com>
Date: Sun Feb 03 15:18:53 2019

Update prebuilts for Navigation 1.0.0-beta01

Include fix for

b/123803044

Test: ./gradlew bOS
Change-Id: Icb2a50975541a7bd3327054c72a591c7689c9741

M android/arch/navigation/navigation-common/1.0.0-beta01/navigation-common-1.0.0-beta01.aar
M android/arch/navigation/navigation-common/1.0.0-beta01/navigation-common-1.0.0-beta01.aar.md5
M android/arch/navigation/navigation-common/1.0.0-beta01/navigation-common-1.0.0-beta01.aar.sha1
M android/arch/navigation/navigation-fragment/1.0.0-beta01/navigation-fragment-1.0.0-beta01-sources.jar
M android/arch/navigation/navigation-fragment/1.0.0-beta01/navigation-fragment-1.0.0-beta01-sources.jar.md5
M android/arch/navigation/navigation-fragment/1.0.0-beta01/navigation-fragment-1.0.0-beta01-sources.jar.sha1
M android/arch/navigation/navigation-fragment/1.0.0-beta01/navigation-fragment-1.0.0-beta01.aar
M android/arch/navigation/navigation-fragment/1.0.0-beta01/navigation-fragment-1.0.0-beta01.aar.md5
M android/arch/navigation/navigation-fragment/1.0.0-beta01/navigation-fragment-1.0.0-beta01.aar.sha1
M android/arch/navigation/navigation-runtime/1.0.0-beta01/navigation-runtime-1.0.0-beta01.aar
M android/arch/navigation/navigation-runtime/1.0.0-beta01/navigation-runtime-1.0.0-beta01.aar.md5
M android/arch/navigation/navigation-runtime/1.0.0-beta01/navigation-runtime-1.0.0-beta01.aar.sha1
M android/arch/navigation/navigation-ui/1.0.0-beta01/navigation-ui-1.0.0-beta01.aar
M android/arch/navigation/navigation-ui/1.0.0-beta01/navigation-ui-1.0.0-beta01.aar.md5
M android/arch/navigation/navigation-ui/1.0.0-beta01/navigation-ui-1.0.0-beta01.aar.sha1

https://android-review.googlesource.com/892878

https://goto.google.com/android-sha1/63bc1ff1fe7c348138295ee7efb8cdc2999622c0

ap...@google.com <ap...@google.com> #4Feb 4, 2019 05:19PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit c775e5d1ae2ab4b194ee3c0f18523c603cf4d6ec
Author: Ian Lake <ilake@google.com>
Date: Sun Feb 03 15:04:21 2019

Return true when popping from FragmentNavigator

Since NavController only updates its back stack when
a Navigator returns true from popBackStack(), ensure
that all updates to the FragmentNavigator's back stack
(i.e., calling removeLast()) are paired with returning
true from popBackStack().

This ensures that the FragmentManager state and the
NavController states don't get out of sync.

Test: Updated FragmentNavigatorTest test
Test: tested in sample app from bug
BUG: 123803044
Change-Id: I8cfc87cba0a0369b5ae5c3ac610e31b5556ba04e

M navigation/fragment/src/androidTest/java/androidx/navigation/fragment/FragmentNavigatorTest.kt
M navigation/fragment/src/main/java/androidx/navigation/fragment/FragmentNavigator.java

https://android-review.googlesource.com/892996

https://goto.google.com/android-sha1/c775e5d1ae2ab4b194ee3c0f18523c603cf4d6ec

il...@google.com <il...@google.com> #5Feb 4, 2019 05:29PM

Marked as fixed.

This is actually an issue where the NavController's back stack state is going out of sync with the FragmentManager / FragmentNavigator's state. This has been fixed and will be available in the next release.

ca...@gmail.com <ca...@gmail.com> #6Feb 8, 2019 12:36AM

Nice job! A quick response!

be...@gmail.com <be...@gmail.com> #7May 1, 2019 08:23PM

I still get this error using the lastest 1.0.0 release :

implementation 'android.arch.navigation:navigation-fragment-ktx:1.0.0'
implementation "android.arch.navigation:navigation-ui-ktx:1.0.0"

I'm using nested graphs.

il...@google.com <il...@google.com> #8May 1, 2019 08:27PM

Re #7 - please file a new bug with a sample app that reproduces your issue.

be...@gmail.com <be...@gmail.com> #9May 1, 2019 09:24PM

Done.

https://issuetracker.google.com/131733658