Fixed
Status Update
Comments
ne...@gmail.com <ne...@gmail.com> #3
Thank you for the quick fix.
Is there an ETA for the next release?
Is there an ETA for the next release?
il...@google.com <il...@google.com>
ap...@google.com <ap...@google.com> #4
2.2.0-rc01 should be out this week.
il...@google.com <il...@google.com> #5
Project: platform/frameworks/support
Branch: androidx-master-dev
commit a1957df3709a06f4e6482fb0e4d39ded4f230a70
Author: Rahul Ravikumar <rahulrav@google.com>
Date: Mon Jul 29 09:48:05 2019
Workaround NPE in PersistableBundle.getExtras().
Test: Existing unit tests pass. Ran integration test app.
Fixes: b/138441699
Change-Id: I0b48e0009a7d83c343a3d26112b94c057470c281
M work/workmanager/src/main/java/androidx/work/impl/background/systemjob/SystemJobService.java
https://android-review.googlesource.com/1092870
https://goto.google.com/android-sha1/a1957df3709a06f4e6482fb0e4d39ded4f230a70
Branch: androidx-master-dev
commit a1957df3709a06f4e6482fb0e4d39ded4f230a70
Author: Rahul Ravikumar <rahulrav@google.com>
Date: Mon Jul 29 09:48:05 2019
Workaround NPE in PersistableBundle.getExtras().
Test: Existing unit tests pass. Ran integration test app.
Fixes:
Change-Id: I0b48e0009a7d83c343a3d26112b94c057470c281
M work/workmanager/src/main/java/androidx/work/impl/background/systemjob/SystemJobService.java
Description
IT's reset here prematurely:
class LoaderInfo {
...
@MainThread
Loader<D> destroy(boolean reset) {
....
if ((observer == null || observer.hasDeliveredData()) && !reset) {
return this.mLoader;
} else {
this.mLoader.reset(); <----------- THIS IS CALLED, BUT SHOULD NOT, because observer.hasDeliveredData()==false
return this.mPriorLoader;
}
}
}
Offending peace of code:
static class LoaderObserver<D> implements Observer<D> {
....
public void onChanged(@Nullable D data) {
this.mCallback.onLoadFinished(this.mLoader, data);
this.mDeliveredData = true; <----------- THIS LINE SHOULD BE BEFORE onLoadFinished
}
}