Support behavior differs from native for APIs 23-27. [124066957]

Fixed

Bug

[AOSP] assigned

Status Update

No update yet.

Description

na...@gmail.com

created issue #1

Feb 8, 2019 11:33AM

Artifact used (ex. androidx.biometric:biometric:1.0.0-alpha03)
Devices/Android versions reproduced on: emulator APIs 23-27

In all samples, including official one (

https://github.com/googlesamples/android-FingerprintDialog/blob/4b89afb161da61c69687181bbe90ff5379e226ee/Application/src/main/java/com/example/android/fingerprintdialog/FingerprintUiHelper.java#L51) two methods of FingerprintManager are used to check if authentication is available.

public boolean isFingerprintAuthAvailable() {
// The line below prevents the false positive inspection from Android Studio
// noinspection ResourceType
return mFingerprintManager.isHardwareDetected()
&& mFingerprintManager.hasEnrolledFingerprints();
}

But FingerprintHelperFragment also checks
mContext.getPackageManager().hasSystemFeature(PackageManager.FEATURE_FINGERPRINT)
which can return false, even if scanner exists and fingerprint is configured, and FingerprintManager can be used for authentication.

If this behavior can be reproduced on emulator, so probably it can happen on real device too.

Comments

le...@gmail.com <le...@gmail.com> #2Feb 10, 2019 12:43PM

Project: platform/frameworks/support
Branch: androidx-main

commit c46d3e79b2ea8b839358f0215b0a432ef8fad7a2
Author: Clara Fok <clarafok@google.com>
Date: Fri Nov 04 15:23:25 2022

Convert androidx.activity.Cancellable to kotlin

Test: ./gradlew activity:activity:cC
Bug: 257291701
Change-Id: I057f3e54811e7399e40083ef5e3915adc4fa425d

M activity/activity/src/main/java/androidx/activity/Cancellable.kt

https://android-review.googlesource.com/2288554

na...@gmail.com <na...@gmail.com> #3Feb 11, 2019 08:44AM

Project: platform/frameworks/support
Branch: androidx-main

commit 7fd8a3206a49baefee8340f0839fcd4de7716788
Author: Clara Fok <clarafok@google.com>
Date: Fri Nov 04 15:13:23 2022

Rename androidx.activity.Cancellable from .java to .kt

Test: n/a
Bug:257291701
Change-Id: I7f2ff8ce79af41c6437fb9a0f1be90e8990495e8

M activity/activity/src/main/java/androidx/activity/Cancellable.kt

https://android-review.googlesource.com/2288553

gu...@gmail.com <gu...@gmail.com> #4May 13, 2019 06:49PM

Project: platform/frameworks/support
Branch: androidx-main

commit 4d21e0a45f19ed238ef30756f576930af07449c2
Author: Clara Fok <clarafok@google.com>
Date: Fri Nov 04 13:25:08 2022

Convert ActivityResultCallback to kotlin

Including clean up in test usages of this interface

Test: ./gradlew activity:activity:cC
Bug: 257291701
Relnote: Converted ActvitiyResultCallback to kotlin. Maintains source and binary comptability.
Change-Id: Ifc5e5e1a9a7ed4e281007830fb8d4c74237c63ce

M activity/activity/api/current.txt
M activity/activity/api/public_plus_experimental_current.txt
M activity/activity/api/restricted_current.txt
M activity/activity/src/androidTest/java/androidx/activity/result/ActivityResultRegistryTest.kt
M activity/activity/src/main/java/androidx/activity/result/ActivityResultCallback.kt

https://android-review.googlesource.com/2288334

kc...@google.com <kc...@google.com> #5Jun 20, 2019 01:45AM

Assigned to kc...@google.com.

Project: platform/frameworks/support
Branch: androidx-main

commit ae5bcbc9174b9767f143bfd9629a69fcd3ed325d
Author: Clara Fok <clarafok@google.com>
Date: Fri Nov 04 13:06:36 2022

Rename ActivityResultCallback from .java to .kt

Test: n/a
Bug: 257291701
Change-Id: I43a8c76cb51e3eee4a1ec2cb6f0128753d85965d

M activity/activity/src/main/java/androidx/activity/result/ActivityResultCallback.kt

https://android-review.googlesource.com/2288333

kc...@google.com <kc...@google.com> #6Jun 21, 2019 01:51AM

Project: platform/frameworks/support
Branch: androidx-main

commit 91f60f5adb619fc0a2ddc866c94670a2f046799a
Author: Clara Fok <clarafok@google.com>
Date: Fri Nov 04 16:59:43 2022

Convert OnBackPressedCallback to kotlin

Test: ./gradlew activity:activity:cC
Bug: 257291701
Relnote: OnBackPressedCallback is now in Kotlin
Change-Id: Ide1b056e438b403c9b1888bc7dfedf283f1ff168

M activity/activity/api/current.txt
M activity/activity/api/public_plus_experimental_current.txt
M activity/activity/api/restricted_current.txt
M activity/activity/src/main/java/androidx/activity/OnBackPressedCallback.kt

https://android-review.googlesource.com/2288079

kc...@google.com <kc...@google.com> #7Jun 21, 2019 07:19PM

Project: platform/frameworks/support
Branch: androidx-main

commit 324a9ebeb0c23ca0113a925c83a4b90a74c7dc54
Author: Clara Fok <clarafok@google.com>
Date: Fri Nov 04 15:57:01 2022

Rename OnBackPressedCallback from .java to .kt

Test: n/a
Bug: 257291701
Change-Id: I3645ebd21c0ea9c243fad3007bdd3d2472806dcc

M activity/activity/src/main/java/androidx/activity/OnBackPressedCallback.kt

https://android-review.googlesource.com/2288078

an...@google.com <an...@google.com> #8Jun 24, 2019 10:15AM

Project: platform/frameworks/support
Branch: androidx-main

commit a6ec8cc8df1fd6e8a4407ad15569d77914e9adb3
Author: Ian Lake <ilake@google.com>
Date: Wed Jan 25 00:05:20 2023

Move OnBackPressedDispatcher extension to main artifact

As the main activity artifact is automatically included
whenever a developer depends on activity-ktx and these are
in an atomic library group, we can move the Kotlin
extension from activity-ktx to activity itself now that
the class itself has been moved to Kotlin.

Relnote: n/a
Test: ./gradlew checkApi
BUG: 257291701
Change-Id: I13482de2e25bd6e084f4b299dddd43b2bcf7a4c7

A activity/activity-ktx/api/current.ignore
M activity/activity-ktx/api/current.txt
M activity/activity-ktx/api/public_plus_experimental_current.txt
A activity/activity-ktx/api/restricted_current.ignore
M activity/activity-ktx/api/restricted_current.txt
D activity/activity-ktx/src/androidTest/java/androidx/activity/OnBackPressedDispatcherTest.kt
D activity/activity-ktx/src/main/java/androidx/activity/OnBackPressedDispatcher.kt
M activity/activity/api/current.txt
M activity/activity/api/public_plus_experimental_current.txt
M activity/activity/api/restricted_current.txt
M activity/activity/src/androidTest/java/androidx/activity/OnBackPressedDispatcherTest.kt
M activity/activity/src/main/java/androidx/activity/OnBackPressedDispatcher.kt

https://android-review.googlesource.com/2401943

kc...@google.com <kc...@google.com> #9Jul 8, 2019 10:14PM

Reassigned to cu...@google.com.

Project: platform/frameworks/support
Branch: androidx-main

commit d54d4417476c5ddc37251a910bdf37e9d278357e
Author: Ian Lake <ilake@google.com>
Date: Tue Jan 24 23:57:45 2023

Replace usages of Consumer with a lambda

Now that OnBackPressedCallback and
OnBackPressedDispatcher are both written in Kotlin,
we can convert the callback between the two to be a
lambda method, rather than using a Consumer<Boolean>.

Test: tests still pass
BUG: 257291701
Change-Id: I0e2e4a3e7e9d6a3aeab1b8d2283fff321d45f44f

M activity/activity/src/main/java/androidx/activity/OnBackPressedCallback.kt
M activity/activity/src/main/java/androidx/activity/OnBackPressedDispatcher.kt

https://android-review.googlesource.com/2401942

cu...@google.com <cu...@google.com> Jul 9, 2019 12:53AM

Accepted by cu...@google.com.

ap...@google.com <ap...@google.com> #10Jul 9, 2019 07:16PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit 453e6f7acd7b7a1310487fc912f78c0fd2e72dd3
Author: Ian Lake <ilake@google.com>
Date: Tue Jan 24 23:43:12 2023

Convert OnBackPressedDispatcher to Kotlin

Relnote: "`OnBackPressedDispatcher` is now written in Kotlin."
Test: ./gradlew checkApi
BUG: 257291701
Change-Id: I18ac79d3cd20fc29159542b729935d3b8d2e4506

M activity/activity/api/current.txt
M activity/activity/api/public_plus_experimental_current.txt
M activity/activity/api/restricted_current.txt
M activity/activity/src/main/java/androidx/activity/OnBackPressedDispatcher.kt

https://android-review.googlesource.com/2401941

kc...@google.com <kc...@google.com> #11Jul 19, 2019 03:04AM

Project: platform/frameworks/support
Branch: androidx-main

commit 57dd231f03ef3f5d107f7c9be9b0f5dd200d7ec4
Author: Ian Lake <ilake@google.com>
Date: Tue Jan 24 23:01:48 2023

Rename OnBackPressedDispatcher.java to .kt

Test: n/a
BUG: 257291701
Change-Id: Id490de8b28b7d2a680c76c822f564fdadd5eb5f1

M activity/activity/src/main/java/androidx/activity/OnBackPressedDispatcher.kt

https://android-review.googlesource.com/2401940

[Deleted User] <[Deleted User]> #12Aug 28, 2019 05:05PM

Project: platform/frameworks/support
Branch: androidx-main

commit 76fcc8653339d275c9bfad10e4c68cd9c8ef0dfd
Author: Ian Lake <ilake@google.com>
Date: Fri Jan 27 00:45:07 2023

Update wear module with OnBackPressedDispatcherOwner

With the move of OnBackPressedDispatcherOwner to Kotlin,
implementations must now override a property rather
than implement a getter.

Test: ./gradlew bOS
BUG: 257291701
Change-Id: Iaf4f466f38a23c5522de019d38080b04c9f7b7ff

M wear/compose/compose-navigation/build.gradle
M wear/compose/compose-navigation/src/androidTest/kotlin/androidx/wear/compose/navigation/SwipeDismissableNavHostTest.kt

https://android-review.googlesource.com/2405513

kc...@google.com <kc...@google.com> #13Aug 28, 2019 05:23PM

Project: platform/frameworks/support
Branch: androidx-main

commit a63f1351aab5e387a829711f14de221274119bcd
Author: Ian Lake <ilake@google.com>
Date: Thu Jan 26 22:51:46 2023

Update navigation module with OnBackPressedDispatcherOwner

With the move of OnBackPressedDispatcherOwner to Kotlin,
implementations must now override a property rather
than implement a getter.

Test: ./gradlew bOS
BUG: 257291701
Change-Id: Iad795301ff2e6a16b42be6b85e6370ac399e43fd

M navigation/navigation-compose/build.gradle
M navigation/navigation-compose/src/androidTest/java/androidx/navigation/compose/NavHostTest.kt

https://android-review.googlesource.com/2404345

[Deleted User] <[Deleted User]> #14Aug 28, 2019 07:16PM

Project: platform/frameworks/support
Branch: androidx-main

commit fa9a4dd728bc575c6e3536f2d5f9564f50b8eeee
Author: Ian Lake <ilake@google.com>
Date: Thu Jan 26 19:33:26 2023

Update compose module with OnBackPressedDispatcherOwner

With the move to OnBackPressedDispatcherOwner to Kotlin,
implementations must now override a property rather
than implement a getter.

Test: ./gradlew bOS
BUG: 257291701
Change-Id: If45fa4c4624a0a71745f4f11f133a3eddcf4dddf

M compose/ui/ui-tooling/build.gradle
M compose/ui/ui-tooling/src/androidMain/kotlin/androidx/compose/ui/tooling/ComposeViewAdapter.kt

https://android-review.googlesource.com/2404338

[Deleted User] <[Deleted User]> #15Sep 2, 2019 01:11PM

Project: platform/frameworks/support
Branch: androidx-main

commit 322bd9508ff202efcdb765778d76baa5fe98795b
Author: Ian Lake <ilake@google.com>
Date: Thu Jan 26 19:05:37 2023

Convert OnBackPressedDispatcherOwner to Kotlin

Relnote: "`OnBackPressedDispatcherOwner` is now written
in Kotlin. This is a **source incompatible change** for those
classes written in Kotlin - you must now override the
`onBackPressedDispatcher` property rather than implementing
the previous `getOnBackPressedDispatcher` function."
Test: ./gradlew checkApi
BUG: 257291701

Change-Id: Ia277dc57731597b869c4e86d3f8c13896a6ce56f

M activity/activity-compose/src/androidTest/java/androidx/activity/compose/BackHandlerTest.kt
M activity/activity-compose/src/androidTest/java/androidx/activity/compose/BackPressedDispatcherOwnerTest.kt
M activity/activity/api/current.txt
M activity/activity/api/public_plus_experimental_current.txt
M activity/activity/api/restricted_current.txt
M activity/activity/src/androidTest/java/androidx/activity/ViewTreeOnBackPressedDispatcherTest.kt
M activity/activity/src/main/java/androidx/activity/ComponentDialog.kt
M activity/activity/src/main/java/androidx/activity/OnBackPressedCallback.kt
M activity/activity/src/main/java/androidx/activity/OnBackPressedDispatcherOwner.kt

https://android-review.googlesource.com/2404337

kc...@google.com <kc...@google.com> #16Sep 3, 2019 05:55PM

Project: platform/frameworks/support
Branch: androidx-main

commit c0ae191b22d3b679c0282ebfad7cc35670afc3b4
Author: Ian Lake <ilake@google.com>
Date: Thu Jan 26 18:24:49 2023

Rename OnBackPressedDispatcherOwner.java to .kt

Part of the Kotlin conversion process.

Test: n/a
BUG: 257291701
Change-Id: Ic0b969a9f98d461ec48195309989f740891ebb9f

M activity/activity/src/main/java/androidx/activity/OnBackPressedDispatcherOwner.kt

https://android-review.googlesource.com/2404336

cu...@google.com <cu...@google.com> #17Sep 4, 2019 05:45PM

Project: platform/frameworks/support
Branch: androidx-main

commit c83511c81d5fd0c87577180301ca1b1231d24c13
Author: Ian Lake <ilake@google.com>
Date: Mon Jan 30 18:44:32 2023

Update compose module with ActivityResultRegistryOwner

With the move of ActivityResultRegistryOwner to Kotlin,
implementations must now override a property rather
than implement a getter.

Test: ./gradlew bOS
BUG: 257291701
Change-Id: I490b9b69d5bd4d9c608ca8d3c9a196d3e70fe801

M compose/ui/ui-tooling/src/androidMain/kotlin/androidx/compose/ui/tooling/ComposeViewAdapter.kt

https://android-review.googlesource.com/2407774