Fixed
Status Update
No update yet.
Comments
ap...@google.com
Hi Ed, Thank you so much for these suggestions. I've been reviewing them and merging them in. Hopefully it should be live. I've included a thank you note too in the article.
il...@google.com
Great! Thanks a lot, I'll look for the live updates soon!
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 4ae14c4c4c2f345ff2abe65db90560209e50fdc1
Author: Ian Lake <ilake@google.com>
Date: Fri Mar 08 11:11:11 2019
Add @CallSuper to onActivityResult in FragmentActivity
Classes that extend FragmentActivity should always
call super.onActivityResult() to allow FragmentTransactions
within the method and to ensure that Fragments that have
called startActivityForResult() receive a callback.
This allows Lint to warn the user ahead of time.
Test: verified visually through IDE
Fixes: 124120586
Change-Id: I81d810abca9ae71256e494a96daffb28f0b373bc
M fragment/src/main/java/androidx/fragment/app/FragmentActivity.java
https://android-review.googlesource.com/923894
https://goto.google.com/android-sha1/4ae14c4c4c2f345ff2abe65db90560209e50fdc1
Branch: androidx-master-dev
commit 4ae14c4c4c2f345ff2abe65db90560209e50fdc1
Author: Ian Lake <ilake@google.com>
Date: Fri Mar 08 11:11:11 2019
Add @CallSuper to onActivityResult in FragmentActivity
Classes that extend FragmentActivity should always
call super.onActivityResult() to allow FragmentTransactions
within the method and to ensure that Fragments that have
called startActivityForResult() receive a callback.
This allows Lint to warn the user ahead of time.
Test: verified visually through IDE
Fixes: 124120586
Change-Id: I81d810abca9ae71256e494a96daffb28f0b373bc
M fragment/src/main/java/androidx/fragment/app/FragmentActivity.java
Description
Version used: 1.1.0-alpha04
Classes that extend from FragmentActivity (or, by extension, AppCompatActivity) should always call super.onNewIntent(intent) to unlock the ability to do FragmentTransactions in onNewIntent().
This will allow Lint to warn developers ahead of time that they need to call super instead of only after debugging why they get an IllegalStateException.