Fixed
Status Update
Comments
rm...@google.com <rm...@google.com> #2
Would you accept external contributions for this ticket? I would gladly contribute implementation for this.
uc...@google.com <uc...@google.com>
xa...@google.com <xa...@google.com> #3
Absolutely, we'd be happy to accept a pull request for this if you'd like follow our
so...@google.com <so...@google.com>
so...@google.com <so...@google.com> #4
xo...@google.com <xo...@google.com> #5
Project: platform/frameworks/support
Branch: androidx-main
Author: Csaba Kozák <
Link:
[GH] Add support for List<Enum> arguments in typesafe navigation
Expand for full commit details
[GH] Add support for List<Enum> arguments in typesafe navigation
## Proposed Changes
Add support for List<Enum> arguments in typesafe navigation
## Testing
Test: ./gradlew navigation:navigation-common:test
Test: ./gradlew navigation:navigation-common:cC
Test: ./gradlew navigation:navigation-runtime:cC
## Issues Fixed
Fixes: 375559962
This is an imported pull request from https://github.com/androidx/androidx/pull/725.
Resolves #725
Github-Pr-Head-Sha: 79289f5cd89a355aa44ac1a7190301cde1e03ae9
GitOrigin-RevId: 5d12e8b036e98d45944806f1d16a00b0769b49e2
Change-Id: Ie67dc9665634751da06fad21c93e9475627e7e62
Files:
- M
navigation/navigation-common/src/androidTest/java/androidx/navigation/serialization/RouteDecoderTest.kt
- M
navigation/navigation-common/src/androidTest/java/androidx/navigation/serialization/RouteFilledTest.kt
- M
navigation/navigation-common/src/main/java/androidx/navigation/serialization/NavTypeConverter.kt
- M
navigation/navigation-common/src/test/java/androidx/navigation/serialization/NavArgumentGeneratorTest.kt
- M
navigation/navigation-runtime/src/androidTest/java/androidx/navigation/NavControllerRouteTest.kt
Hash: 061287da098c4249bbe0b3a10add04feb9bdf5ae
Date: Mon Nov 18 22:24:48 2024
xo...@google.com <xo...@google.com> #6
Fixed externally and will be available in navigation 2.8.5
xo...@google.com <xo...@google.com> #7
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.navigation:navigation-common:2.9.0-alpha04
androidx.navigation:navigation-runtime:2.9.0-alpha04
androidx.navigation:navigation-common:2.8.5
androidx.navigation:navigation-runtime:2.8.5
Description
However, for some specific repositories (I've noticed this with robolectric), it won't.
Steps to reproduce:
Create a new Android studio project.
In the Project build.gradle file, under buildscript, define the variable:
ext.robolectricVersion = '4.0.1'
In the Module build.gradle file, add the dependency:
dependencies {
testImplementation "org.robolectric:robolectric:$rootProject.robolectricVersion"
}
Note that Android studio does not warn about an outdated dependency.
Change the Module build.gradle file as follows:
dependencies {
testImplementation "org.robolectric:robolectric:4.0.1"
}
Note that there is now a warning.
Github repo displaying problem:
Build: 3.3.1, AI-182.5107.16.33.5264788, 201901282352,
AI-182.5107.16.33.5264788, JRE 1.8.0_152-release-1248-b01x64 JetBrains s.r.o, OS Windows 7(amd64) v6.1 Service Pack 1, screens 1920x1080
Android Gradle Plugin: 3.3.1
Gradle: 4.10.1
NDK: from local.properties: (not specified); latest from SDK: (not found);
LLDB: pinned revision 3.1 not found; latest from SDK: (package not found);
CMake: from local.properties: (not specified); latest from SDK: (not found); from PATH: (not found);
IMPORTANT: Please read