Fixed
Status Update
Comments
il...@google.com <il...@google.com>
il...@google.com <il...@google.com>
ap...@google.com <ap...@google.com> #2
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 51be9d9b5db05aeb2672b4094cf2d896ade15336
Author: Ian Lake <ilake@google.com>
Date: Fri Mar 22 10:12:06 2019
Avoid parsing Activity classes at inflation time
Instead of eagerly parsing the android:name on
<activity> destinations, build a ComponentName
out of the String itself, allowing lazy
instantiation of classes, such as is required
for dynamic feature modules.
Test: tested in sample app on bug
Fixes: 124538597
Change-Id: I4b4751f8524be68faa7d4223488900657da4edde
M navigation/runtime/src/main/java/androidx/navigation/ActivityNavigator.java
https://android-review.googlesource.com/932917
https://goto.google.com/android-sha1/51be9d9b5db05aeb2672b4094cf2d896ade15336
Branch: androidx-master-dev
commit 51be9d9b5db05aeb2672b4094cf2d896ade15336
Author: Ian Lake <ilake@google.com>
Date: Fri Mar 22 10:12:06 2019
Avoid parsing Activity classes at inflation time
Instead of eagerly parsing the android:name on
<activity> destinations, build a ComponentName
out of the String itself, allowing lazy
instantiation of classes, such as is required
for dynamic feature modules.
Test: tested in sample app on bug
Fixes: 124538597
Change-Id: I4b4751f8524be68faa7d4223488900657da4edde
M navigation/runtime/src/main/java/androidx/navigation/ActivityNavigator.java
il...@google.com <il...@google.com> #3
We no longer try to resolve the activity class at inflation time. This fix will be available in Navigation 2.1.0-alpha02
Description
Version used: 1.0.0-beta02
Devices/Android versions reproduced on: All
I have a problem when I use Navigation with Dynamic Feature Module.
If the module is not installed, crash occurs when load Navigation Graph which includes <activity>.
It occurs in `ActivityNavigator.Destination#onInflate`
Is there any way to prevent crash?
If there is not, I request the feature.
I created sample project and attach it.
Please uncheck `Dynamic features to deploy` in `Run > Edit Configurations`, and then run sample app.
(I don't implement about downloading the module yet in this sample.)
Thank you.