Fixed
Status Update
No update yet.
Comments
da...@google.com
Thanks for reporting this. This is a bug, 'CREATE VIRTUAL TABLE txt3 USING fts4(tokenize=simple "tokenchars=.=" "separators=X");' is a valid FTS creation statement and should be support by Room.
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 6cd537ed7fc855b93fa81242b1f78b209f0d7f67
Author: Daniel Santiago Rivera <danysantiago@google.com>
Date: Fri Feb 22 10:06:44 2019
Allow Tokenizer Args for the SIMPLE Tokenizer
This changes fixes tokenizer args not being added to the create
statement when the tokenizer being used was SIMPLE.
Bug: 125427014
Test: ./gradlew room:room-compiler:test
Change-Id: I728923dbad748f78cd7efae8daaf654fb63865c5
M room/compiler/src/main/kotlin/androidx/room/vo/FtsOptions.kt
M room/compiler/src/test/kotlin/androidx/room/vo/FtsEntityTest.kt
M room/runtime/src/test/java/androidx/room/util/FtsTableInfoTest.java
https://android-review.googlesource.com/910013
https://goto.google.com/android-sha1/6cd537ed7fc855b93fa81242b1f78b209f0d7f67
Branch: androidx-master-dev
commit 6cd537ed7fc855b93fa81242b1f78b209f0d7f67
Author: Daniel Santiago Rivera <danysantiago@google.com>
Date: Fri Feb 22 10:06:44 2019
Allow Tokenizer Args for the SIMPLE Tokenizer
This changes fixes tokenizer args not being added to the create
statement when the tokenizer being used was SIMPLE.
Bug: 125427014
Test: ./gradlew room:room-compiler:test
Change-Id: I728923dbad748f78cd7efae8daaf654fb63865c5
M room/compiler/src/main/kotlin/androidx/room/vo/FtsOptions.kt
M room/compiler/src/test/kotlin/androidx/room/vo/FtsEntityTest.kt
M room/runtime/src/test/java/androidx/room/util/FtsTableInfoTest.java
Description
Version used: 2.1.0.alpha04
Devices/Android versions reproduced on:
This line:
if (includeTokenizer && tokenizer != androidx.room.FtsOptions.TOKENIZER_SIMPLE)
in FtsOptions.kt
disables the addition of custom separators and tokenchars to the "simple" tokenizer, but there is no documentation that this is not possible or why its not. Is this a bug or a feature ?