Fixed
Status Update
Comments
an...@google.com <an...@google.com> #2
3) ViewOverlayApi14 has a bug and adds new views in a wrong order
ap...@google.com <ap...@google.com> #3
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 863462a41d0708ab9044f826e85250cb3d20ffa8
Author: Andrey Kulikov <andreykulikov@google.com>
Date: Fri Feb 22 16:18:09 2019
Improve GhostView logic on APIs < 21
Starting from API 21 we use platform's GhostView which has this features comparing to the current ported version:
1) If you add multiple views as a ghosts for the same parent they would be added in the order in which they would be drown in the original hierarchy
2) They will also be drawn on top of other overlay views(not ghosts).
We reimplement this logic in the ported version and start using this on all APIs expect Pie. We can't use it on Pie as we can't enable a shadow support for a canvas on this API version.
Plus I fixed wrong insertion ordering for ViewOverlayApi14 and wrong matrix calculation for transformMatrixToLocal on APIs < 21.
Bug: 125777978
Bug: 117521193
Bug: 123768642
Test: added new tests for GhostView which verifies the correct drawing order of the views
Change-Id: Ie8a0c952cd15b2c3d29a816c02e49a8adff85a96
M samples/SupportTransitionDemos/src/main/res/layout/red_square.xml
A transition/src/androidTest/java/androidx/transition/GhostViewTest.java
A transition/src/main/java/androidx/transition/CanvasUtils.java
M transition/src/main/java/androidx/transition/ChangeTransform.java
M transition/src/main/java/androidx/transition/GhostView.java
D transition/src/main/java/androidx/transition/GhostViewApi14.java
A transition/src/main/java/androidx/transition/GhostViewHolder.java
M transition/src/main/java/androidx/transition/GhostViewPlatform.java
A transition/src/main/java/androidx/transition/GhostViewPort.java
M transition/src/main/java/androidx/transition/GhostViewUtils.java
M transition/src/main/java/androidx/transition/ViewGroupUtils.java
M transition/src/main/java/androidx/transition/ViewOverlayApi14.java
M transition/src/main/java/androidx/transition/ViewUtilsBase.java
M transition/src/main/res/values/ids.xml
https://android-review.googlesource.com/909754
https://goto.google.com/android-sha1/863462a41d0708ab9044f826e85250cb3d20ffa8
Branch: androidx-master-dev
commit 863462a41d0708ab9044f826e85250cb3d20ffa8
Author: Andrey Kulikov <andreykulikov@google.com>
Date: Fri Feb 22 16:18:09 2019
Improve GhostView logic on APIs < 21
Starting from API 21 we use platform's GhostView which has this features comparing to the current ported version:
1) If you add multiple views as a ghosts for the same parent they would be added in the order in which they would be drown in the original hierarchy
2) They will also be drawn on top of other overlay views(not ghosts).
We reimplement this logic in the ported version and start using this on all APIs expect Pie. We can't use it on Pie as we can't enable a shadow support for a canvas on this API version.
Plus I fixed wrong insertion ordering for ViewOverlayApi14 and wrong matrix calculation for transformMatrixToLocal on APIs < 21.
Bug: 125777978
Bug: 117521193
Bug: 123768642
Test: added new tests for GhostView which verifies the correct drawing order of the views
Change-Id: Ie8a0c952cd15b2c3d29a816c02e49a8adff85a96
M samples/SupportTransitionDemos/src/main/res/layout/red_square.xml
A transition/src/androidTest/java/androidx/transition/GhostViewTest.java
A transition/src/main/java/androidx/transition/CanvasUtils.java
M transition/src/main/java/androidx/transition/ChangeTransform.java
M transition/src/main/java/androidx/transition/GhostView.java
D transition/src/main/java/androidx/transition/GhostViewApi14.java
A transition/src/main/java/androidx/transition/GhostViewHolder.java
M transition/src/main/java/androidx/transition/GhostViewPlatform.java
A transition/src/main/java/androidx/transition/GhostViewPort.java
M transition/src/main/java/androidx/transition/GhostViewUtils.java
M transition/src/main/java/androidx/transition/ViewGroupUtils.java
M transition/src/main/java/androidx/transition/ViewOverlayApi14.java
M transition/src/main/java/androidx/transition/ViewUtilsBase.java
M transition/src/main/res/values/ids.xml
Description
1) If you add multiple views as a ghosts for the same parent they would be added in the order in which they would be drown in the original hierarchy
2) They will also be drawn on top of other overlay views(not ghosts)