Fixed
Status Update
No update yet.
Comments
vi...@google.com
vi...@google.com
Yigit, do you have time to fix it?
reemission of the same liveData is racy
reemission of the same liveData is racy
[Deleted User] <[Deleted User]>
yea i'll take it.
vi...@google.com
Thanks for the detailed analysis. This may not be an issue anymore since we've started using Main.immediate there but I' not sure; I'll try to create a test case.
il...@google.com
ap...@google.com
just emitting same live data reproduces the issue.
@Test
fun raceTest() {
val subLiveData = MutableLiveData(1)
val subject = liveData(testScope.coroutineContext) {
emitSource(subLiveData)
emitSource(subLiveData) //crashes
}
subject.addObserver().apply {
testScope.advanceUntilIdle()
}
}
@Test
fun raceTest() {
val subLiveData = MutableLiveData(1)
val subject = liveData(testScope.coroutineContext) {
emitSource(subLiveData)
emitSource(subLiveData) //crashes
}
subject.addObserver().apply {
testScope.advanceUntilIdle()
}
}
il...@google.com
With 2.2.0-alpha04 (that use Main.immediate), the issue seems to be still there (I tested it by calling emitSource() twice, like your test case)
Description
I'm trying to confirm some threading assumptions in a codebase. It currently boils down to the following question:
Can I assume that Fragment.onViewCreated() and Fragment.onResume() are always called on the application's main thread?
As far as I can tell there is no reason for either to be called on a worker thread, but I'm worried my assumption might cause trouble in the future. I'd like to request the addition of "@MainThread" and/or "@AnyThread" to those methods to alleviate that uncertainty.