R8 is incompatible with library android-retrostreams [127691114]

Fixed

Bug

Status Update

No update yet.

Description

to...@gmail.com

created issue #1

Mar 7, 2019 09:26AM

I'm using the android-retrostreams library to use Java 8+ APIs in my project (library link:

https://github.com/retrostreams/android-retrostreams). When building with the latest AGP 3.5.0-alpha06 using R8 for optimization, an error will occur with the following message:

Execution failed for task ':app:transformClassesAndResourcesWithR8ForFullRelease'.
> java.lang.IllegalArgumentException: Multiple entries with same key: Method java9.util.concurrent.ForkJoinPool.<init> Proto VB void byte=Encoded method Method java9.util.concurrent.ForkJoinPool.<init> Proto VB void byte and Method java9.util.concurrent.ForkJoinPool.<init> Proto VB void byte=Encoded method Method java9.util.concurrent.ForkJoinPool.<init> Proto VB void byte

If I manually turn off R8 (android.enableR8=false) to use Proguard, it builds completely fine.
I attached a super simple Android project (relevant code pulled from my main project), build with "./gradlew assembleRelease" should be able to reproduce this issue.

Retrostreams.zip

131 KB

Download

Comments

ch...@google.com <ch...@google.com> #2Mar 7, 2019 09:33AM

Assigned to ch...@google.com.

Thanks for the report and for supplying the reproduction! I will look into what is going on and start working on a fix.

ap...@google.com <ap...@google.com> #3Mar 7, 2019 10:53AM

Project: r8
Branch: master

commit 25d66bd92c48be6c77623395da2899be368dabd6
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Thu Mar 07 11:52:11 2019

Fix constructor collision bug in unused argument removal

Bug: 127691114
Change-Id: I55c6692dda1e9ab3b57353a60281468b6ba9ce30

M src/main/java/com/android/tools/r8/ir/optimize/UnusedArgumentsCollector.java
A src/test/java/com/android/tools/r8/ir/optimize/unusedarguments/UnusedArgumentsInstanceConstructorCollisionTest.java

https://r8-review.googlesource.com/35360

ap...@google.com <ap...@google.com> #4Mar 7, 2019 10:55AM

Project: r8
Branch: d8-1.4

commit 746ad29934a90359809ff15e3cd7cc4ca29ae4d6
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Thu Mar 07 11:53:37 2019

Version 1.4.67

Cherry pick: Fix constructor collision bug in unused argument removal
CL:

https://r8-review.googlesource.com/c/r8/+/35360

Bug: 127691114
Change-Id: Ia0d372cfe13b46c72edf73faf00f817968e1e067

M src/main/java/com/android/tools/r8/Version.java
M src/main/java/com/android/tools/r8/ir/optimize/UnusedArgumentsCollector.java
A src/test/java/com/android/tools/r8/ir/optimize/unusedarguments/UnusedArgumentsInstanceConstructorCollisionTest.java

https://r8-review.googlesource.com/35361

ch...@google.com <ch...@google.com> #5Mar 7, 2019 01:56PM

Marked as fixed.

Thanks again for the report. This should now be fixed on ToT. You should be able to test the latest release of R8 by making the following changes to build.gradle:

buildscript {
repositories {
maven {
url '

http://storage.googleapis.com/r8-releases/raw'
}
}
dependencies {
classpath 'com.android.tools:r8:1.4.67' // Must be before the Gradle Plugin for Android.
classpath 'com.android.tools.build:gradle:...'
}
}

Issue 127691114

Description

Issue summary

Comments

ch...@google.com <ch...@google.com> #2Mar 7, 2019 09:33AM

ap...@google.com <ap...@google.com> #3Mar 7, 2019 10:53AM

ap...@google.com <ap...@google.com> #4Mar 7, 2019 10:55AM

ch...@google.com <ch...@google.com> #5Mar 7, 2019 01:56PM

Add comment

Issue metadata