Fixed
Status Update
No update yet.
Comments
ve...@google.com
ve...@google.com
We probably should make this work without a new API, otherwise developers would need to provide these flags, which is hard and complicated and entirely what the library should aim to simplify
For the support version of the library, we can probably make outside touches not dismiss the dialog.
We can have either
1) back button (existing)
2) potentially add a new "cancel" button
For the support version of the library, we can probably make outside touches not dismiss the dialog.
We can have either
1) back button (existing)
2) potentially add a new "cancel" button
[Deleted User] <[Deleted User]>
I'm unable to reproduce this issue on Samsung S7
Can you capture a video and a bugreport on both
1) Pixel Android 9 - cannot reproduce, sensor is on the back, and dialog works for me
2) Huawei mate 20 Android 8.1.0?
My suspicion is that on the Huawei device, we're going through the FingerprintManager path on support library, and Huawei is overlaying it with their own in-display FP UI. The UI should consume touches and not propagate them, otherwise the dialog will be canceled.
Can you capture a video and a bugreport on both
1) Pixel Android 9 - cannot reproduce, sensor is on the back, and dialog works for me
2) Huawei mate 20 Android 8.1.0?
My suspicion is that on the Huawei device, we're going through the FingerprintManager path on support library, and Huawei is overlaying it with their own in-display FP UI. The UI should consume touches and not propagate them, otherwise the dialog will be canceled.
ve...@google.com
The issue we were seeing on Samsung drives is it is very easy to fat-finger and tap the screen because the fingerprint sensor is on the front. This was with the compat dialog. I think always setting Dialog#setCanceledOnTouchOutside(false) is a reasonable solution as you can still use the back button to cancel the dialog.
si...@medici.md
The safer way seems to me like disallowing the library from being dismissed from taps outside. The back button is still there, which gives the user an escape hatch.
ve...@google.com
Attached wrong bug number, fixed in following commit
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 2aa297a0d4a014a06766b1658b6c9438ecff30fc
Author: Kevin Chyn <kchyn@google.com>
Date: Thu Jul 18 16:42:48 2019
Do not allow the fingerprint dialog to be canceled due to touches outside
It's safer to disallow this, since on some devices the sensor is on the
home button, etc, where it's easier to miss. Since the support library
is supposed to simplify developer's lives, we should just default to
preventing this on all pre-P devices, rather than potentially exposing
an API for developers to toggle based on device type (too complicated).
Fixes: 125447052
Test: Touches outside no longer cancel authentication. Back button cancels
authentication still.
Change-Id: I6639b2ecdf18f82a242fffba63eeb8ca45d53dc9
M biometric/src/main/java/androidx/biometric/FingerprintDialogFragment.java
https://android-review.googlesource.com/1087531
https://goto.google.com/android-sha1/2aa297a0d4a014a06766b1658b6c9438ecff30fc
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 2aa297a0d4a014a06766b1658b6c9438ecff30fc
Author: Kevin Chyn <kchyn@google.com>
Date: Thu Jul 18 16:42:48 2019
Do not allow the fingerprint dialog to be canceled due to touches outside
It's safer to disallow this, since on some devices the sensor is on the
home button, etc, where it's easier to miss. Since the support library
is supposed to simplify developer's lives, we should just default to
preventing this on all pre-P devices, rather than potentially exposing
an API for developers to toggle based on device type (too complicated).
Fixes: 125447052
Test: Touches outside no longer cancel authentication. Back button cancels
authentication still.
Change-Id: I6639b2ecdf18f82a242fffba63eeb8ca45d53dc9
M biometric/src/main/java/androidx/biometric/FingerprintDialogFragment.java
si...@medici.md
I didn't get how you marked it to fixed. I'm using Honor 9 Lite phone and clicking outside the Biometric prompt is still cancelling the dialog
si...@medici.md
Using Xiaomi Mi A2, when the biometricprompt comes up and i press outside the dialog box, the biometric prompt closes. I'm using androidx.biometric:biometric:1.0.1 library
si...@medici.md
Using Vivo v11 Pro and OnePlus 7 Pro, when the biometricprompt comes up and I press outside the dialog box or press the back button, the biometric prompt closes. I'm using androidx.biometric:biometric:1.2.0_alpha01 library.
How can I prevent this?
How can I prevent this?
kc...@google.com
Any updates regarding solution to this issue?
ap...@google.com
this issue still exists, kindly re-verify it ..
kc...@google.com
il...@google.com
this issue still exists, kindly re-verify it , even in alpha version.
si...@medici.md
this issue is still there, please retest and provide fix.
ap...@google.com
Not fixed and not work on emulator Nexus 5x API 33
ba...@gmail.com
Dialog is style-able only for API < P.
Device used
Emulators
Steps to reproduce
Use BiometricPrompt on devices below Android P and devices above Android P.
Frequency
Always
Expected output
Button is colored according to buttonBarNegativeButtonStyle but isn't on Android P and above
Current output
Button is colored with default value.
See attached screenshots.
Device used
Emulators
Steps to reproduce
Use BiometricPrompt on devices below Android P and devices above Android P.
Frequency
Always
Expected output
Button is colored according to buttonBarNegativeButtonStyle but isn't on Android P and above
Current output
Button is colored with default value.
See attached screenshots.
kc...@google.com
This is the expected behavior, on P and above, the dialog is provided/customizable by the OEM and has system theming instead of app-theming.
Description
Version used: 1.0.0-alpha03
Theme used: Dark - Theme.MaterialComponents.NoActionBar
Devices/Android versions reproduced on:
- Relevant code to trigger the issue.
You can find reproduce project over here:
You need to switch comment on following lines of build.gradle in sample:
//implementation 'androidx.biometric:biometric:1.0.0-alpha03'
implementation project(':library')
- A screenrecord or screenshots showing the issue (if UI related).
Screenshot and its capture are attached.
As you can see custom theme applied to dialog is not applied to content created by FingerprintDialogFragment.
It is simply because content is created by an inflator getting theme from context object only.
final View layout = LayoutInflater.from(getContext())
.inflate(R.layout.fingerprint_dialog_layout, null);
however dialog itself respects customizations. As a result no way to set text color on fingerprint dialog (actually managed to set title color later, but content is not manageable)