Fixed
Status Update
Comments
ve...@google.com <ve...@google.com>
ve...@google.com <ve...@google.com> #2
Hi Ed, Thank you so much for these suggestions. I've been reviewing them and merging them in. Hopefully it should be live. I've included a thank you note too in the article.
[Deleted User] <[Deleted User]> #3
Great! Thanks a lot, I'll look for the live updates soon!
ve...@google.com <ve...@google.com> #4
Thank you for the details. We’ve investigated, but have been unable to reproduce it with the steps provided (video attached for reference). If you are able to reproduce the issue again or have additional information to help us (to identify what steps were missing to reproduce the issue), please let us know.
Below is the code snippet used.
dependencies {
implementation fileTree(dir: 'libs', include: ['*.jar'])
implementation "org.jetbrains.kotlin:kotlin-stdlib-jdk8:$kotlin_version"
implementation 'androidx.appcompat:appcompat:1.1.0-alpha02'
implementation 'androidx.constraintlayout:constraintlayout:1.1.3'
implementation 'com.google.android.material:material:1.1.0-alpha03'
//implementation 'androidx.biometric:biometric:1.0.0-alpha03'
implementation project(':library')
testImplementation 'junit:junit:4.12'
androidTestImplementation 'androidx.test:runner:1.1.1'
androidTestImplementation 'androidx.test.espresso:espresso-core:3.1.1'
Note: Please upload the files to google drive and share the folder to android-bugreport@google.com, then share the link here.
Below is the code snippet used.
dependencies {
implementation fileTree(dir: 'libs', include: ['*.jar'])
implementation "org.jetbrains.kotlin:kotlin-stdlib-jdk8:$kotlin_version"
implementation 'androidx.appcompat:appcompat:1.1.0-alpha02'
implementation 'androidx.constraintlayout:constraintlayout:1.1.3'
implementation 'com.google.android.material:material:1.1.0-alpha03'
//implementation 'androidx.biometric:biometric:1.0.0-alpha03'
implementation project(':library')
testImplementation 'junit:junit:4.12'
androidTestImplementation 'androidx.test:runner:1.1.1'
androidTestImplementation 'androidx.test.espresso:espresso-core:3.1.1'
Note: Please upload the files to google drive and share the folder to android-bugreport@google.com, then share the link here.
si...@medici.md <si...@medici.md> #5
Hello;
As mentioned previously, you have to uncomment original library
implementation 'androidx.biometric:biometric:1.0.0-alpha03'
and comment out following line as:
// implementation project(':library'). Because on :library, I have fixed the problem.
Please apply this change and re-try.
As mentioned previously, you have to uncomment original library
implementation 'androidx.biometric:biometric:1.0.0-alpha03'
and comment out following line as:
// implementation project(':library'). Because on :library, I have fixed the problem.
Please apply this change and re-try.
ve...@google.com <ve...@google.com> #6
Thank you for the details. Please provide the following additional information:
Screen record of the issue, for clarity
Please capture screen record or video of the issue using following steps:
adb shell screenrecord /sdcard/video.mp4
Subsequently use following command to pull the recorded file:
adb pull /sdcard/video.mp4
Attach the file to this issue.
Note: Please upload the files to google drive and share the folder to android-bugreport@google.com, then share the link here.
Screen record of the issue, for clarity
Please capture screen record or video of the issue using following steps:
adb shell screenrecord /sdcard/video.mp4
Subsequently use following command to pull the recorded file:
adb pull /sdcard/video.mp4
Attach the file to this issue.
Note: Please upload the files to google drive and share the folder to android-bugreport@google.com, then share the link here.
si...@medici.md <si...@medici.md> #7
Screenshot was already provided on the first post. You just need to switch comments on two lines in order to reproduce.
si...@medici.md <si...@medici.md> #8
still exists using `1.0.0-alpha04`
si...@medici.md <si...@medici.md> #9
> You just need to switch comments on two lines in order to reproduce.
I have switched on example repository. so you can just pull and run to see on Emulator api 26.
I have switched on example repository. so you can just pull and run to see on Emulator api 26.
kc...@google.com <kc...@google.com> #10
Ilya do you want to take a stab at this one
ap...@google.com <ap...@google.com> #11
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 59e8ee43f0cb0a341823e169a807ff08f8dbe466
Author: Ilya Matyukhin <ilyamaty@google.com>
Date: Mon Jul 15 12:38:59 2019
Fix fingerprint dialog not using the parent's theme
Bug: 127878106
Test: shows custom text colors from the app's theme
Change-Id: I2bd68a26f1ad621e2ccb384ace816c4927f6948b
M biometric/build.gradle
M biometric/res/layout/fingerprint_dialog_layout.xml
M biometric/src/main/java/androidx/biometric/FingerprintDialogFragment.java
https://android-review.googlesource.com/1040144
https://goto.google.com/android-sha1/59e8ee43f0cb0a341823e169a807ff08f8dbe466
Branch: androidx-master-dev
commit 59e8ee43f0cb0a341823e169a807ff08f8dbe466
Author: Ilya Matyukhin <ilyamaty@google.com>
Date: Mon Jul 15 12:38:59 2019
Fix fingerprint dialog not using the parent's theme
Bug: 127878106
Test: shows custom text colors from the app's theme
Change-Id: I2bd68a26f1ad621e2ccb384ace816c4927f6948b
M biometric/build.gradle
M biometric/res/layout/fingerprint_dialog_layout.xml
M biometric/src/main/java/androidx/biometric/FingerprintDialogFragment.java
kc...@google.com <kc...@google.com>
il...@google.com <il...@google.com> #12
sinan, thanks for reporting the bug! The fix will be available in androidx.biometric:biometric:1.0.0-alpha05.
Please note, the order of the arguments in the BiometricPrompt constructor has changed.
The executor is now the third argument, and the callback is the second, like this:
val biometricPrompt = BiometricPrompt(this, object : BiometricPrompt.AuthenticationCallback() {...}, MainThreadExecutor())
Also, the Support Library components depend on AppCompat themes to get styled correctly. You can migrate your themes like this, for example:
Theme.MaterialComponents.NoActionBar -> Theme.AppCompat.NoActionBar
ThemeOverlay.MaterialComponents.MaterialAlertDialog -> ThemeOverlay.AppCompat.Dialog.Alert
Widget.MaterialComponents.Button.TextButton -> Widget.AppCompat.Button
TextAppearance.MaterialComponents.Headline6 -> TextAppearance.AppCompat.Headline
TextAppearance.MaterialComponents.Body1 -> TextAppearance.AppCompat.Body1
In addition to that, you would want to use the "alertDialogTheme" attribute as opposed to "android:alertDialogTheme" to have your customizations picked up by your AppCompat theme. Example:
<item name="alertDialogTheme">@style/AppDialogStyle</item>
Please note, the order of the arguments in the BiometricPrompt constructor has changed.
The executor is now the third argument, and the callback is the second, like this:
val biometricPrompt = BiometricPrompt(this, object : BiometricPrompt.AuthenticationCallback() {...}, MainThreadExecutor())
Also, the Support Library components depend on AppCompat themes to get styled correctly. You can migrate your themes like this, for example:
Theme.MaterialComponents.NoActionBar -> Theme.AppCompat.NoActionBar
ThemeOverlay.MaterialComponents.MaterialAlertDialog -> ThemeOverlay.AppCompat.Dialog.Alert
Widget.MaterialComponents.Button.TextButton -> Widget.AppCompat.Button
TextAppearance.MaterialComponents.Headline6 -> TextAppearance.AppCompat.Headline
TextAppearance.MaterialComponents.Body1 -> TextAppearance.AppCompat.Body1
In addition to that, you would want to use the "alertDialogTheme" attribute as opposed to "android:alertDialogTheme" to have your customizations picked up by your AppCompat theme. Example:
<item name="alertDialogTheme">@style/AppDialogStyle</item>
si...@medici.md <si...@medici.md> #13
Hey, thanks for your interest and effort. I will be looking forward to update library we have used.
ap...@google.com <ap...@google.com> #14
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 120b7741ca685f5b15667a322fbd2dbeedf6e748
Author: Kevin Chyn <kchyn@google.com>
Date: Thu Jul 18 15:41:04 2019
Update BiometricPromptDemo to use AppCompat theme
Currently crashes due to java.lang.IllegalStateException: You need to use a Theme.AppCompat theme (or descendant) with this activity.
Bug: 127878106
Test: Emulator API23
Change-Id: Id5eba5ee7a98455e82cf68af3c259846866d9543
M samples/BiometricDemos/src/main/res/values/styles.xml
https://android-review.googlesource.com/1087228
https://goto.google.com/android-sha1/120b7741ca685f5b15667a322fbd2dbeedf6e748
Branch: androidx-master-dev
commit 120b7741ca685f5b15667a322fbd2dbeedf6e748
Author: Kevin Chyn <kchyn@google.com>
Date: Thu Jul 18 15:41:04 2019
Update BiometricPromptDemo to use AppCompat theme
Currently crashes due to java.lang.IllegalStateException: You need to use a Theme.AppCompat theme (or descendant) with this activity.
Bug: 127878106
Test: Emulator API23
Change-Id: Id5eba5ee7a98455e82cf68af3c259846866d9543
M samples/BiometricDemos/src/main/res/values/styles.xml
ba...@gmail.com <ba...@gmail.com> #15
Dialog is style-able only for API < P.
Device used
Emulators
Steps to reproduce
Use BiometricPrompt on devices below Android P and devices above Android P.
Frequency
Always
Expected output
Button is colored according to buttonBarNegativeButtonStyle but isn't on Android P and above
Current output
Button is colored with default value.
See attached screenshots.
Device used
Emulators
Steps to reproduce
Use BiometricPrompt on devices below Android P and devices above Android P.
Frequency
Always
Expected output
Button is colored according to buttonBarNegativeButtonStyle but isn't on Android P and above
Current output
Button is colored with default value.
See attached screenshots.
kc...@google.com <kc...@google.com> #16
This is the expected behavior, on P and above, the dialog is provided/customizable by the OEM and has system theming instead of app-theming.
Description
Version used: 1.0.0-alpha03
Theme used: Dark - Theme.MaterialComponents.NoActionBar
Devices/Android versions reproduced on:
- Relevant code to trigger the issue.
You can find reproduce project over here:
You need to switch comment on following lines of build.gradle in sample:
//implementation 'androidx.biometric:biometric:1.0.0-alpha03'
implementation project(':library')
- A screenrecord or screenshots showing the issue (if UI related).
Screenshot and its capture are attached.
As you can see custom theme applied to dialog is not applied to content created by FingerprintDialogFragment.
It is simply because content is created by an inflator getting theme from context object only.
final View layout = LayoutInflater.from(getContext())
.inflate(R.layout.fingerprint_dialog_layout, null);
however dialog itself respects customizations. As a result no way to set text color on fingerprint dialog (actually managed to set title color later, but content is not manageable)