Fixed
Status Update
No update yet.
Comments
il...@google.com
il...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 87230c0d52d3d534692a31c8ffbb378fc3508111
Author: Chris Craik <ccraik@google.com>
Date: Tue Oct 08 08:28:15 2019
Remove warmup log and array alloc from critical path
Bug:142058671
Test: ./gradlew benchmark:benchmark-benchmark:cC # with systrace / method tracing
When transitioning out of warmup, saw array allocation in method
trace, and log work in systrace. Still more improvements to make here.
Change-Id: Ibddbc3dd90e7802d3777f690be1a684ced4fc339
M benchmark/common/src/main/java/androidx/benchmark/BenchmarkState.kt
M benchmark/common/src/main/java/androidx/benchmark/WarmupManager.kt
https://android-review.googlesource.com/1134877
https://goto.google.com/android-sha1/87230c0d52d3d534692a31c8ffbb378fc3508111
Branch: androidx-master-dev
commit 87230c0d52d3d534692a31c8ffbb378fc3508111
Author: Chris Craik <ccraik@google.com>
Date: Tue Oct 08 08:28:15 2019
Remove warmup log and array alloc from critical path
Bug:142058671
Test: ./gradlew benchmark:benchmark-benchmark:cC # with systrace / method tracing
When transitioning out of warmup, saw array allocation in method
trace, and log work in systrace. Still more improvements to make here.
Change-Id: Ibddbc3dd90e7802d3777f690be1a684ced4fc339
M benchmark/common/src/main/java/androidx/benchmark/BenchmarkState.kt
M benchmark/common/src/main/java/androidx/benchmark/WarmupManager.kt
Description
Version used: 1.1.0-alpha04
Classes that extend from FragmentActivity (or, by extension, AppCompatActivity) should always call super.onActivityResult(requestCode, resultCode, data) to unlock the ability to do FragmentTransactions in onActivityResult() and ensure that Fragments that have called startActivityForResult get their callbacks to onActivityResult themselves.
This will allow Lint to warn developers ahead of time that they need to call super instead of only after debugging why they get an IllegalStateException.