Fixed
Status Update
Comments
il...@google.com <il...@google.com> #2
Project: platform/frameworks/support
Branch: androidx-main
commit b697d397d051f91a6f6ed95a55af421f048f3c89
Author: Sanura Njaka <sanura@google.com>
Date: Wed Aug 02 12:16:12 2023
Folding lifecycle-livedata-core-ktx back into main
module
Now that Lifecycle tests are written in kotlin, LiveDataTest
can be moved from lifecycle-livedata-core-ktx into LiveDataTest
within the main lifecycle-livedata-core module.
Test: ./gradlew bOS
Bug: 274800183
Change-Id: I98806ad751bd674a554de665e0e16bf05d67900d
D lifecycle/lifecycle-livedata-core-ktx/src/test/java/androidx/lifecycle/LiveDataTest.kt
M lifecycle/lifecycle-livedata-core/src/test/java/androidx/lifecycle/LiveDataTest.kt
https://android-review.googlesource.com/2690010
Branch: androidx-main
commit b697d397d051f91a6f6ed95a55af421f048f3c89
Author: Sanura Njaka <sanura@google.com>
Date: Wed Aug 02 12:16:12 2023
Folding lifecycle-livedata-core-ktx back into main
module
Now that Lifecycle tests are written in kotlin, LiveDataTest
can be moved from lifecycle-livedata-core-ktx into LiveDataTest
within the main lifecycle-livedata-core module.
Test: ./gradlew bOS
Bug: 274800183
Change-Id: I98806ad751bd674a554de665e0e16bf05d67900d
D lifecycle/lifecycle-livedata-core-ktx/src/test/java/androidx/lifecycle/LiveDataTest.kt
M lifecycle/lifecycle-livedata-core/src/test/java/androidx/lifecycle/LiveDataTest.kt
ja...@gmail.com <ja...@gmail.com> #3
Project: platform/frameworks/support
Branch: androidx-main
commit cd3c1d7751462b5e42ae54e2d68299f955dcb6c3
Author: Sanura Njaka <sanura@google.com>
Date: Mon Aug 07 07:34:20 2023
Folding lifecycle-livedata-ktx back into main
module
Now that Lifecycle tests are written in kotlin, all files in lifecycle-livedata-ktx can now be added into the main lifecycle-livedata module.
RelNote: "All files from the lifecycle-livedata-ktx modules have been moved into the main lifecycle-livedata module"
Test: ./gradlew bOS
Bug: 274800183
Change-Id: I10c6f70c82a64e80eec704f548911f42bdd0b56a
M lifecycle/lifecycle-livedata-ktx/api/current.ignore
M lifecycle/lifecycle-livedata-ktx/api/current.txt
M lifecycle/lifecycle-livedata-ktx/api/restricted_current.ignore
M lifecycle/lifecycle-livedata-ktx/api/restricted_current.txt
M lifecycle/lifecycle-livedata/api/current.txt
M lifecycle/lifecycle-livedata/api/restricted_current.txt
M lifecycle/lifecycle-livedata/build.gradle
M lifecycle/lifecycle-livedata/src/androidTest/java/androidx.lifecycle/FlowAsLiveDataIntegrationTest.kt
M lifecycle/lifecycle-livedata/src/main/java/androidx/lifecycle/CoroutineLiveData.kt
M lifecycle/lifecycle-livedata/src/main/java/androidx/lifecycle/FlowLiveData.kt
M lifecycle/lifecycle-livedata/src/test/java/androidx/lifecycle/BuildLiveDataTest.kt
M lifecycle/lifecycle-livedata/src/test/java/androidx/lifecycle/FlowAsLiveDataTest.kt
M lifecycle/lifecycle-livedata/src/test/java/androidx/lifecycle/LiveDataAsFlowTest.kt
M lifecycle/lifecycle-livedata/src/test/java/androidx/lifecycle/LiveDataFlowJavaTest.java
M lifecycle/lifecycle-livedata/src/test/java/androidx/lifecycle/ScopesRule.kt
https://android-review.googlesource.com/2695173
Branch: androidx-main
commit cd3c1d7751462b5e42ae54e2d68299f955dcb6c3
Author: Sanura Njaka <sanura@google.com>
Date: Mon Aug 07 07:34:20 2023
Folding lifecycle-livedata-ktx back into main
module
Now that Lifecycle tests are written in kotlin, all files in lifecycle-livedata-ktx can now be added into the main lifecycle-livedata module.
RelNote: "All files from the lifecycle-livedata-ktx modules have been moved into the main lifecycle-livedata module"
Test: ./gradlew bOS
Bug: 274800183
Change-Id: I10c6f70c82a64e80eec704f548911f42bdd0b56a
M lifecycle/lifecycle-livedata-ktx/api/current.ignore
M lifecycle/lifecycle-livedata-ktx/api/current.txt
M lifecycle/lifecycle-livedata-ktx/api/restricted_current.ignore
M lifecycle/lifecycle-livedata-ktx/api/restricted_current.txt
M lifecycle/lifecycle-livedata/api/current.txt
M lifecycle/lifecycle-livedata/api/restricted_current.txt
M lifecycle/lifecycle-livedata/build.gradle
M lifecycle/lifecycle-livedata/src/androidTest/java/androidx.lifecycle/FlowAsLiveDataIntegrationTest.kt
M lifecycle/lifecycle-livedata/src/main/java/androidx/lifecycle/CoroutineLiveData.kt
M lifecycle/lifecycle-livedata/src/main/java/androidx/lifecycle/FlowLiveData.kt
M lifecycle/lifecycle-livedata/src/test/java/androidx/lifecycle/BuildLiveDataTest.kt
M lifecycle/lifecycle-livedata/src/test/java/androidx/lifecycle/FlowAsLiveDataTest.kt
M lifecycle/lifecycle-livedata/src/test/java/androidx/lifecycle/LiveDataAsFlowTest.kt
M lifecycle/lifecycle-livedata/src/test/java/androidx/lifecycle/LiveDataFlowJavaTest.java
M lifecycle/lifecycle-livedata/src/test/java/androidx/lifecycle/ScopesRule.kt
ub...@gmail.com <ub...@gmail.com> #4
Project: platform/frameworks/support
Branch: androidx-main
commit 32c1896b0506529674f03076a1141daaa0749b28
Author: Sanura Njaka <sanura@google.com>
Date: Tue Aug 22 11:20:50 2023
Moving ScopesRule into util package
ScopesRule.kt will now be included in lifecycle-livedata's util package
Test: ./gradlew bOS
BUg: 274800183
Change-Id: I2df34eebffcdacc716ce0235e29601436918f955
M lifecycle/lifecycle-livedata/src/test/java/androidx/lifecycle/BuildLiveDataTest.kt
M lifecycle/lifecycle-livedata/src/test/java/androidx/lifecycle/FlowAsLiveDataTest.kt
M lifecycle/lifecycle-livedata/src/test/java/androidx/lifecycle/LiveDataAsFlowTest.kt
M lifecycle/lifecycle-livedata/src/test/java/androidx/lifecycle/util/ScopesRule.kt
https://android-review.googlesource.com/2721674
Branch: androidx-main
commit 32c1896b0506529674f03076a1141daaa0749b28
Author: Sanura Njaka <sanura@google.com>
Date: Tue Aug 22 11:20:50 2023
Moving ScopesRule into util package
ScopesRule.kt will now be included in lifecycle-livedata's util package
Test: ./gradlew bOS
BUg: 274800183
Change-Id: I2df34eebffcdacc716ce0235e29601436918f955
M lifecycle/lifecycle-livedata/src/test/java/androidx/lifecycle/BuildLiveDataTest.kt
M lifecycle/lifecycle-livedata/src/test/java/androidx/lifecycle/FlowAsLiveDataTest.kt
M lifecycle/lifecycle-livedata/src/test/java/androidx/lifecycle/LiveDataAsFlowTest.kt
M lifecycle/lifecycle-livedata/src/test/java/androidx/lifecycle/util/ScopesRule.kt
ja...@gmail.com <ja...@gmail.com> #5
Project: platform/frameworks/support
Branch: androidx-main
commit 4140c78328013f4fea4bd48f286c46a98c358270
Author: Marcello Galhardo <mgalhardo@google.com>
Date: Fri Jan 26 14:43:43 2024
Move `lifecycle-viewmodel-ktx` source to the base module
* Transferred source code from `lifecycle-viewmodel-ktx` to the main `lifecycle-viewmodel` module.
* Kotlin STD Lib is now a dependency in the base AndroidX Lifecycle artifacts, separate `-ktx` modules for Kotlin extensions are no longer needed.
* Renamed the file from `ViewModel` to `ViewModelCoroutineScope` to reflect the content: coroutines support. Use `file:JvmName("ViewModelKt")` to maintain source compatibility.
* Add a resolutionStrategy to `:playground` and `:presentation` in `:tv:integration-tests` to resolve "minifyReleaseWithR8 FAILED: Class is defined multiple times" issue caused by moving classes from `-ktx` to the base module.
RelNote: "The `lifecycle-viewmodel-ktx` kotlin extensions have now been moved to the base lifecycle module."
Bug: 274800183
Test: ViewModelCoroutinesTest
Change-Id: Id787b6db6817e69e4ec50748a07ccdbef074e99d
A lifecycle/lifecycle-viewmodel-ktx/api/current.ignore
M lifecycle/lifecycle-viewmodel-ktx/api/current.txt
A lifecycle/lifecycle-viewmodel-ktx/api/restricted_current.ignore
M lifecycle/lifecycle-viewmodel-ktx/api/restricted_current.txt
M lifecycle/lifecycle-viewmodel-ktx/build.gradle
M lifecycle/lifecycle-viewmodel/api/current.txt
M lifecycle/lifecycle-viewmodel/api/restricted_current.txt
M lifecycle/lifecycle-viewmodel/build.gradle
M lifecycle/lifecycle-viewmodel/src/androidTest/java/androidx/lifecycle/ViewModelCoroutineScopeTest.kt
M lifecycle/lifecycle-viewmodel/src/main/java/androidx/lifecycle/ViewModelCoroutineScope.kt
M tv/integration-tests/playground/build.gradle
M tv/integration-tests/presentation/build.gradle
https://android-review.googlesource.com/2930010
Branch: androidx-main
commit 4140c78328013f4fea4bd48f286c46a98c358270
Author: Marcello Galhardo <mgalhardo@google.com>
Date: Fri Jan 26 14:43:43 2024
Move `lifecycle-viewmodel-ktx` source to the base module
* Transferred source code from `lifecycle-viewmodel-ktx` to the main `lifecycle-viewmodel` module.
* Kotlin STD Lib is now a dependency in the base AndroidX Lifecycle artifacts, separate `-ktx` modules for Kotlin extensions are no longer needed.
* Renamed the file from `ViewModel` to `ViewModelCoroutineScope` to reflect the content: coroutines support. Use `file:JvmName("ViewModelKt")` to maintain source compatibility.
* Add a resolutionStrategy to `:playground` and `:presentation` in `:tv:integration-tests` to resolve "minifyReleaseWithR8 FAILED: Class is defined multiple times" issue caused by moving classes from `-ktx` to the base module.
RelNote: "The `lifecycle-viewmodel-ktx` kotlin extensions have now been moved to the base lifecycle module."
Bug: 274800183
Test: ViewModelCoroutinesTest
Change-Id: Id787b6db6817e69e4ec50748a07ccdbef074e99d
A lifecycle/lifecycle-viewmodel-ktx/api/current.ignore
M lifecycle/lifecycle-viewmodel-ktx/api/current.txt
A lifecycle/lifecycle-viewmodel-ktx/api/restricted_current.ignore
M lifecycle/lifecycle-viewmodel-ktx/api/restricted_current.txt
M lifecycle/lifecycle-viewmodel-ktx/build.gradle
M lifecycle/lifecycle-viewmodel/api/current.txt
M lifecycle/lifecycle-viewmodel/api/restricted_current.txt
M lifecycle/lifecycle-viewmodel/build.gradle
M lifecycle/lifecycle-viewmodel/src/androidTest/java/androidx/lifecycle/ViewModelCoroutineScopeTest.kt
M lifecycle/lifecycle-viewmodel/src/main/java/androidx/lifecycle/ViewModelCoroutineScope.kt
M tv/integration-tests/playground/build.gradle
M tv/integration-tests/presentation/build.gradle
ub...@gmail.com <ub...@gmail.com> #6
Project: platform/frameworks/support
Branch: androidx-main
commit ce327843c4c6bfeb3410a1203e0e2aac0f0a59cc
Author: Marcello Galhardo <mgalhardo@google.com>
Date: Fri Jan 26 16:21:38 2024
Move `lifecycle-livedata-core-ktx` source to the base module
* Transferred source code from `lifecycle-livedata-core-ktx` to the base `lifecycle-livedata-core` module.
* Kotlin STD Lib is now a dependency in the base AndroidX Lifecycle artifacts, separate `-ktx` modules for Kotlin extensions are no longer needed.
RelNote: "The `lifecycle-livedata-core-ktx` kotlin extensions have now been moved to the base lifecycle module."
Bug: 274800183
Test: manual
Change-Id: I54a3d4346b4a9c5861f5f3bdb0079dbb27f29668
A lifecycle/lifecycle-livedata-core-ktx/api/current.ignore
M lifecycle/lifecycle-livedata-core-ktx/api/current.txt
A lifecycle/lifecycle-livedata-core-ktx/api/restricted_current.ignore
M lifecycle/lifecycle-livedata-core-ktx/api/restricted_current.txt
M lifecycle/lifecycle-livedata-core-ktx/build.gradle
M lifecycle/lifecycle-livedata-core/api/current.txt
M lifecycle/lifecycle-livedata-core/api/restricted_current.txt
M lifecycle/lifecycle-livedata-core/src/main/java/androidx/lifecycle/LiveData.kt
https://android-review.googlesource.com/2927827
Branch: androidx-main
commit ce327843c4c6bfeb3410a1203e0e2aac0f0a59cc
Author: Marcello Galhardo <mgalhardo@google.com>
Date: Fri Jan 26 16:21:38 2024
Move `lifecycle-livedata-core-ktx` source to the base module
* Transferred source code from `lifecycle-livedata-core-ktx` to the base `lifecycle-livedata-core` module.
* Kotlin STD Lib is now a dependency in the base AndroidX Lifecycle artifacts, separate `-ktx` modules for Kotlin extensions are no longer needed.
RelNote: "The `lifecycle-livedata-core-ktx` kotlin extensions have now been moved to the base lifecycle module."
Bug: 274800183
Test: manual
Change-Id: I54a3d4346b4a9c5861f5f3bdb0079dbb27f29668
A lifecycle/lifecycle-livedata-core-ktx/api/current.ignore
M lifecycle/lifecycle-livedata-core-ktx/api/current.txt
A lifecycle/lifecycle-livedata-core-ktx/api/restricted_current.ignore
M lifecycle/lifecycle-livedata-core-ktx/api/restricted_current.txt
M lifecycle/lifecycle-livedata-core-ktx/build.gradle
M lifecycle/lifecycle-livedata-core/api/current.txt
M lifecycle/lifecycle-livedata-core/api/restricted_current.txt
M lifecycle/lifecycle-livedata-core/src/main/java/androidx/lifecycle/LiveData.kt
ja...@gmail.com <ja...@gmail.com> #7
Project: platform/frameworks/support
Branch: androidx-main
commit b08ac008ee00cedd68d5f21a54c4035a7778c875
Author: Marcello Galhardo <mgalhardo@google.com>
Date: Wed Feb 07 11:19:04 2024
Move `lifecycle-runtime-ktx` source to the base module
* Transferred source code from `lifecycle-runtime-ktx` to the main `lifecycle-runtime` module.
* Kotlin STD Lib is now a dependency in the base AndroidX Lifecycle artifacts, separate `-ktx` modules for Kotlin extensions are no longer needed.
* Changed the method signature of `androidx.lifecycle.View.findViewTreeLifecycleOwner` from `View.findViewTreeLifecycleOwner()` to `findViewTreeLifecycleOwner(view)` to avoid a conflicting overload.
* Add a resolutionStrategy to `:playground` and `:presentation` in `:tv:integration-tests` to resolve "minifyReleaseWithR8 FAILED: Class is defined multiple times" issue caused by moving classes from `-ktx` to the base module.
RelNote: "The `lifecycle-runtime-ktx` kotlin extensions have now been moved to the base lifecycle module."
Bug: 274800183
Test: FlowWithLifecycleTest
Test: LaunchWhenTest
Test: PausingDispatcherTest
Test: RepeatOnLifecycleTest
Test: ViewTreeLifecycleOwnerTest
Test: WithLifecycleStateTest
Change-Id: Ic368640a7e66dd0b748601d61b7aa23d99e5a1d6
D lifecycle/lifecycle-runtime-compose/api/current.ignore
D lifecycle/lifecycle-runtime-compose/api/restricted_current.ignore
A lifecycle/lifecycle-runtime-ktx/api/current.ignore
M lifecycle/lifecycle-runtime-ktx/api/current.txt
A lifecycle/lifecycle-runtime-ktx/api/restricted_current.ignore
M lifecycle/lifecycle-runtime-ktx/api/restricted_current.txt
M lifecycle/lifecycle-runtime-ktx/build.gradle
D lifecycle/lifecycle-runtime-ktx/src/androidInstrumentedTest/kotlin/androidx/lifecycle/ViewTreeLifecycleOwnerTest.kt
M lifecycle/lifecycle-runtime/api/current.txt
M lifecycle/lifecycle-runtime/api/restricted_current.txt
M lifecycle/lifecycle-runtime/build.gradle
M lifecycle/lifecycle-runtime/src/androidInstrumentedTest/kotlin/androidx/lifecycle/Expectations.kt
M lifecycle/lifecycle-runtime/src/androidInstrumentedTest/kotlin/androidx/lifecycle/FakeLifecycleOwner.kt
M lifecycle/lifecycle-runtime/src/androidInstrumentedTest/kotlin/androidx/lifecycle/FlowWithLifecycleTest.kt
M lifecycle/lifecycle-runtime/src/androidInstrumentedTest/kotlin/androidx/lifecycle/LaunchWhenTest.kt
M lifecycle/lifecycle-runtime/src/androidInstrumentedTest/kotlin/androidx/lifecycle/PausingDispatcherTest.kt
M lifecycle/lifecycle-runtime/src/androidInstrumentedTest/kotlin/androidx/lifecycle/RepeatOnLifecycleTest.kt
M lifecycle/lifecycle-runtime/src/androidInstrumentedTest/kotlin/androidx/lifecycle/TaskTracker.kt
M lifecycle/lifecycle-runtime/src/androidInstrumentedTest/kotlin/androidx/lifecycle/TrackedExecutor.kt
M lifecycle/lifecycle-runtime/src/androidInstrumentedTest/kotlin/androidx/lifecycle/WithLifecycleStateTest.kt
M lifecycle/lifecycle-runtime/src/androidMain/AndroidManifest.xml
M lifecycle/lifecycle-runtime/src/androidMain/kotlin/androidx/lifecycle/View.android.kt
M lifecycle/lifecycle-runtime/src/commonMain/kotlin/androidx/lifecycle/FlowExt.kt
M lifecycle/lifecycle-runtime/src/commonMain/kotlin/androidx/lifecycle/RepeatOnLifecycle.kt
M lifecycle/lifecycle-runtime/src/commonMain/kotlin/androidx/lifecycle/WithLifecycleState.kt
M tv/integration-tests/playground/build.gradle
M tv/integration-tests/presentation/build.gradle
https://android-review.googlesource.com/2928837
Branch: androidx-main
commit b08ac008ee00cedd68d5f21a54c4035a7778c875
Author: Marcello Galhardo <mgalhardo@google.com>
Date: Wed Feb 07 11:19:04 2024
Move `lifecycle-runtime-ktx` source to the base module
* Transferred source code from `lifecycle-runtime-ktx` to the main `lifecycle-runtime` module.
* Kotlin STD Lib is now a dependency in the base AndroidX Lifecycle artifacts, separate `-ktx` modules for Kotlin extensions are no longer needed.
* Changed the method signature of `androidx.lifecycle.View.findViewTreeLifecycleOwner` from `View.findViewTreeLifecycleOwner()` to `findViewTreeLifecycleOwner(view)` to avoid a conflicting overload.
* Add a resolutionStrategy to `:playground` and `:presentation` in `:tv:integration-tests` to resolve "minifyReleaseWithR8 FAILED: Class is defined multiple times" issue caused by moving classes from `-ktx` to the base module.
RelNote: "The `lifecycle-runtime-ktx` kotlin extensions have now been moved to the base lifecycle module."
Bug: 274800183
Test: FlowWithLifecycleTest
Test: LaunchWhenTest
Test: PausingDispatcherTest
Test: RepeatOnLifecycleTest
Test: ViewTreeLifecycleOwnerTest
Test: WithLifecycleStateTest
Change-Id: Ic368640a7e66dd0b748601d61b7aa23d99e5a1d6
D lifecycle/lifecycle-runtime-compose/api/current.ignore
D lifecycle/lifecycle-runtime-compose/api/restricted_current.ignore
A lifecycle/lifecycle-runtime-ktx/api/current.ignore
M lifecycle/lifecycle-runtime-ktx/api/current.txt
A lifecycle/lifecycle-runtime-ktx/api/restricted_current.ignore
M lifecycle/lifecycle-runtime-ktx/api/restricted_current.txt
M lifecycle/lifecycle-runtime-ktx/build.gradle
D lifecycle/lifecycle-runtime-ktx/src/androidInstrumentedTest/kotlin/androidx/lifecycle/ViewTreeLifecycleOwnerTest.kt
M lifecycle/lifecycle-runtime/api/current.txt
M lifecycle/lifecycle-runtime/api/restricted_current.txt
M lifecycle/lifecycle-runtime/build.gradle
M lifecycle/lifecycle-runtime/src/androidInstrumentedTest/kotlin/androidx/lifecycle/Expectations.kt
M lifecycle/lifecycle-runtime/src/androidInstrumentedTest/kotlin/androidx/lifecycle/FakeLifecycleOwner.kt
M lifecycle/lifecycle-runtime/src/androidInstrumentedTest/kotlin/androidx/lifecycle/FlowWithLifecycleTest.kt
M lifecycle/lifecycle-runtime/src/androidInstrumentedTest/kotlin/androidx/lifecycle/LaunchWhenTest.kt
M lifecycle/lifecycle-runtime/src/androidInstrumentedTest/kotlin/androidx/lifecycle/PausingDispatcherTest.kt
M lifecycle/lifecycle-runtime/src/androidInstrumentedTest/kotlin/androidx/lifecycle/RepeatOnLifecycleTest.kt
M lifecycle/lifecycle-runtime/src/androidInstrumentedTest/kotlin/androidx/lifecycle/TaskTracker.kt
M lifecycle/lifecycle-runtime/src/androidInstrumentedTest/kotlin/androidx/lifecycle/TrackedExecutor.kt
M lifecycle/lifecycle-runtime/src/androidInstrumentedTest/kotlin/androidx/lifecycle/WithLifecycleStateTest.kt
M lifecycle/lifecycle-runtime/src/androidMain/AndroidManifest.xml
M lifecycle/lifecycle-runtime/src/androidMain/kotlin/androidx/lifecycle/View.android.kt
M lifecycle/lifecycle-runtime/src/commonMain/kotlin/androidx/lifecycle/FlowExt.kt
M lifecycle/lifecycle-runtime/src/commonMain/kotlin/androidx/lifecycle/RepeatOnLifecycle.kt
M lifecycle/lifecycle-runtime/src/commonMain/kotlin/androidx/lifecycle/WithLifecycleState.kt
M tv/integration-tests/playground/build.gradle
M tv/integration-tests/presentation/build.gradle
il...@google.com <il...@google.com>
al...@google.com <al...@google.com> #8
Project: platform/frameworks/support
Branch: androidx-main
commit ce705f9552422d5cccd145244b3402fbade2768f
Author: Marcello Galhardo <mgalhardo@google.com>
Date: Mon Feb 12 15:13:37 2024
Move `lifecycle-runtime-ktx-lint` to base module
* Rename `lifecycle-runtime-ktx-lint` to `lifecycle-runtime-lint`.
* Move `lintPublish` from obsolete `lifecycle-runtime-ktx` to `lifecycle-runtime`.
Bug: 274800183
Test: manual
Change-Id: I83bc2787fb3636b32e772f100bb8733793829708
M lifecycle/lifecycle-runtime-ktx/build.gradle
M lifecycle/lifecycle-runtime-lint/build.gradle
M lifecycle/lifecycle-runtime-lint/src/main/java/androidx/lifecycle/lint/LifecycleRuntimeIssueRegistry.kt
M lifecycle/lifecycle-runtime-lint/src/main/java/androidx/lifecycle/lint/LifecycleWhenChecks.kt
M lifecycle/lifecycle-runtime-lint/src/main/java/androidx/lifecycle/lint/RepeatOnLifecycleDetector.kt
M lifecycle/lifecycle-runtime-lint/src/main/resources/META-INF/services/com.android.tools.lint.client.api.IssueRegistry
M lifecycle/lifecycle-runtime-lint/src/test/java/androidx/lifecycle/runtime/lint/ApiLintVersionsTest.kt
M lifecycle/lifecycle-runtime-lint/src/test/java/androidx/lifecycle/runtime/lint/LifecycleWhenChecksTest.kt
M lifecycle/lifecycle-runtime-lint/src/test/java/androidx/lifecycle/runtime/lint/RepeatOnLifecycleDetectorTest.kt
M lifecycle/lifecycle-runtime-lint/src/test/java/androidx/lifecycle/runtime/lint/WhenMethodsTest.kt
M lifecycle/lifecycle-runtime-lint/src/test/java/androidx/lifecycle/runtime/lint/stubs/Stubs.kt
M lifecycle/lifecycle-runtime/build.gradle
M settings.gradle
https://android-review.googlesource.com/2957874
Branch: androidx-main
commit ce705f9552422d5cccd145244b3402fbade2768f
Author: Marcello Galhardo <mgalhardo@google.com>
Date: Mon Feb 12 15:13:37 2024
Move `lifecycle-runtime-ktx-lint` to base module
* Rename `lifecycle-runtime-ktx-lint` to `lifecycle-runtime-lint`.
* Move `lintPublish` from obsolete `lifecycle-runtime-ktx` to `lifecycle-runtime`.
Bug: 274800183
Test: manual
Change-Id: I83bc2787fb3636b32e772f100bb8733793829708
M lifecycle/lifecycle-runtime-ktx/build.gradle
M lifecycle/lifecycle-runtime-lint/build.gradle
M lifecycle/lifecycle-runtime-lint/src/main/java/androidx/lifecycle/lint/LifecycleRuntimeIssueRegistry.kt
M lifecycle/lifecycle-runtime-lint/src/main/java/androidx/lifecycle/lint/LifecycleWhenChecks.kt
M lifecycle/lifecycle-runtime-lint/src/main/java/androidx/lifecycle/lint/RepeatOnLifecycleDetector.kt
M lifecycle/lifecycle-runtime-lint/src/main/resources/META-INF/services/com.android.tools.lint.client.api.IssueRegistry
M lifecycle/lifecycle-runtime-lint/src/test/java/androidx/lifecycle/runtime/lint/ApiLintVersionsTest.kt
M lifecycle/lifecycle-runtime-lint/src/test/java/androidx/lifecycle/runtime/lint/LifecycleWhenChecksTest.kt
M lifecycle/lifecycle-runtime-lint/src/test/java/androidx/lifecycle/runtime/lint/RepeatOnLifecycleDetectorTest.kt
M lifecycle/lifecycle-runtime-lint/src/test/java/androidx/lifecycle/runtime/lint/WhenMethodsTest.kt
M lifecycle/lifecycle-runtime-lint/src/test/java/androidx/lifecycle/runtime/lint/stubs/Stubs.kt
M lifecycle/lifecycle-runtime/build.gradle
M settings.gradle
se...@google.com <se...@google.com> #9
Project: platform/frameworks/support
Branch: androidx-main
commit 7497f5ec6cd6deda184e32b612f468d739916be8
Author: Marcello Galhardo <mgalhardo@google.com>
Date: Mon Feb 12 14:31:43 2024
Move `lifecycle-livedata-core-ktx-lint` to base module
* Rename `lifecycle-livedata-core-ktx-lint` to `lifecycle-livedata-core-lint`.
* Move `lintPublish` from obsolete `lifecycle-livedata-core-ktx` to `lifecycle-livedata-core`.
Bug: 274800183
Test: manual
Change-Id: Ib306e4c199d8a26d3465ad479249497909c46ff4
M lifecycle/lifecycle-livedata-core-ktx/build.gradle
M lifecycle/lifecycle-livedata-core-lint/build.gradle
M lifecycle/lifecycle-livedata-core-lint/src/main/java/androidx/lifecycle/lint/LiveDataCoreIssueRegistry.kt
M lifecycle/lifecycle-livedata-core-lint/src/main/java/androidx/lifecycle/lint/NonNullableMutableLiveDataDetector.kt
M lifecycle/lifecycle-livedata-core-lint/src/main/resources/META-INF/services/com.android.tools.lint.client.api.IssueRegistry
M lifecycle/lifecycle-livedata-core-lint/src/test/java/androidx/lifecycle/livedata/core/lint/ApiLintVersionsTest.kt
M lifecycle/lifecycle-livedata-core-lint/src/test/java/androidx/lifecycle/livedata/core/lint/NonNullableMutableLiveDataDetectorTest.kt
M lifecycle/lifecycle-livedata-core-lint/src/test/java/androidx/lifecycle/livedata/core/lint/stubs/Stubs.kt
M lifecycle/lifecycle-livedata-core/build.gradle
M settings.gradle
https://android-review.googlesource.com/2957873
Branch: androidx-main
commit 7497f5ec6cd6deda184e32b612f468d739916be8
Author: Marcello Galhardo <mgalhardo@google.com>
Date: Mon Feb 12 14:31:43 2024
Move `lifecycle-livedata-core-ktx-lint` to base module
* Rename `lifecycle-livedata-core-ktx-lint` to `lifecycle-livedata-core-lint`.
* Move `lintPublish` from obsolete `lifecycle-livedata-core-ktx` to `lifecycle-livedata-core`.
Bug: 274800183
Test: manual
Change-Id: Ib306e4c199d8a26d3465ad479249497909c46ff4
M lifecycle/lifecycle-livedata-core-ktx/build.gradle
M lifecycle/lifecycle-livedata-core-lint/build.gradle
M lifecycle/lifecycle-livedata-core-lint/src/main/java/androidx/lifecycle/lint/LiveDataCoreIssueRegistry.kt
M lifecycle/lifecycle-livedata-core-lint/src/main/java/androidx/lifecycle/lint/NonNullableMutableLiveDataDetector.kt
M lifecycle/lifecycle-livedata-core-lint/src/main/resources/META-INF/services/com.android.tools.lint.client.api.IssueRegistry
M lifecycle/lifecycle-livedata-core-lint/src/test/java/androidx/lifecycle/livedata/core/lint/ApiLintVersionsTest.kt
M lifecycle/lifecycle-livedata-core-lint/src/test/java/androidx/lifecycle/livedata/core/lint/NonNullableMutableLiveDataDetectorTest.kt
M lifecycle/lifecycle-livedata-core-lint/src/test/java/androidx/lifecycle/livedata/core/lint/stubs/Stubs.kt
M lifecycle/lifecycle-livedata-core/build.gradle
M settings.gradle
ap...@google.com <ap...@google.com> #10
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.lifecycle:lifecycle-livedata-core:2.8.0-alpha02
androidx.lifecycle:lifecycle-livedata-core-ktx:2.8.0-alpha02
androidx.lifecycle:lifecycle-runtime:2.8.0-alpha02
androidx.lifecycle:lifecycle-runtime-compose:2.8.0-alpha02
androidx.lifecycle:lifecycle-runtime-ktx:2.8.0-alpha02
androidx.lifecycle:lifecycle-viewmodel:2.8.0-alpha02
androidx.lifecycle:lifecycle-viewmodel-ktx:2.8.0-alpha02
il...@google.com <il...@google.com> #11
We've changed how @ContentView functions. The previous form of:
@ContentView(R.layout.main)
class MainFragment : Fragment() {
}
becomes
class MainFragment : Fragment(R.layout.main) {
}
While the default FragmentFactory (and AppComponentFactory for Activities on API 28+) still require a no-argument constructor, Fragment and ComponentActivity/FragmentActivity/AppCompatActivity allow your no-argument constructor or custom constructor to call up to a second constructor which takes a @LayoutRes int of the layout you want to inflate. That second constructor is annotated with @ContentView and will be used for future Tools integrations.
@ContentView(R.layout.main)
class MainFragment : Fragment() {
}
becomes
class MainFragment : Fragment(R.layout.main) {
}
While the default FragmentFactory (and AppComponentFactory for Activities on API 28+) still require a no-argument constructor, Fragment and ComponentActivity/FragmentActivity/AppCompatActivity allow your no-argument constructor or custom constructor to call up to a second constructor which takes a @LayoutRes int of the layout you want to inflate. That second constructor is annotated with @ContentView and will be used for future Tools integrations.
zh...@gmail.com <zh...@gmail.com> #12
Layout IDs will become non-usable in annotations, in application modules?
------
Is it to deliberately kill code such as:
https://github.com/square/mortar/blob/d7bb8e5b5dd773376d940319a49bce9bf7c1058c/mortar-sample/src/main/java/com/example/mortar/screen/ChatListScreen.java#L33
and
https://github.com/lyft/scoop/blob/8d8e499bf3e6399676d314a18094a99a57b99a46/scoop-basics/src/main/java/com/example/scoop/basics/ui/layoutsample/screen/LayoutScreen.java#L10
?
------
Is it to deliberately kill code such as:
and
?
il...@google.com <il...@google.com> #13
For discussion on non-final IDs in app modules and why the Tools team is considering it, see the section on resource namespacing part of the "What's New With the Android Gradle Plugin" talk from AndroidDevSummit: https://www.youtube.com/watch?v=GlwvVJNWlWg&t=1318
ta...@gmail.com <ta...@gmail.com> #14
I've seen in recent changelog that giving layout in constructors is also supported in AppCompatActivity. Is this something supported in older API levels?
il...@google.com <il...@google.com> #15
Re #14 as per the Javadoc: https://developer.android.com/reference/androidx/appcompat/app/AppCompatActivity?hl=en#AppCompatActivity(int)
"This should generally be called from your constructor that takes no parameters, as is required for API 27 and lower or when using the default AppComponentFactory."
"This should generally be called from your constructor that takes no parameters, as is required for API 27 and lower or when using the default AppComponentFactory."
Description
Version used: Version 1.0.0-alpha04
Since `R.layout` is non-final in library projects, we can't use the `@ContentView` annotation.