Support setting toolbar (ActionMenuView) icon color/tint [128665405]

Infeasible

Feature Request

androidx-bug-bounty

Status Update

No update yet.

Description

ma...@marcardar.com

created issue #1

Mar 16, 2019 05:08AM

Currently, there is no way to set the icon color for all icons in a toolbar. Instead we have to set the color on each icon separately. But this is very bad because we almost always want to ensure all the icons are the same color.

Furthermore, there is no easy way to do this. Either the icon colors have to be set programmatically or we have to add an extra drawable (e.g drawable XML tinting some existing drawable) for each menu item.

Please add a method to ActionMenuView to set the tint color (icon color) to be applied to all icons.

Comments

ia...@gmail.com <ia...@gmail.com> #2Feb 12, 2021 01:03AM

Hey ! I am interested to work on this. Can I get some guidance on how to submit this feature?

Thanks!!!

al...@google.com <al...@google.com> #3Feb 17, 2021 09:28PM

Assigned to ia...@gmail.com.

Certainly! I can help sponsor this and review your CLs.

See the README for a quick guide to contributing or the more in-depth Getting Started guide that covers using Android Studio, testing, and more.

ja...@gmail.com <ja...@gmail.com> #4May 29, 2021 10:47PM

Comment has been deleted.

Message last modified on Jun 1, 2021 01:59PM

as...@google.com <as...@google.com> Apr 18, 2022 01:27PM

Reassigned to ju...@google.com.

ap...@google.com <ap...@google.com> #5May 13, 2022 08:32PM

Project: platform/frameworks/support
Branch: androidx-main

commit 2af1286be31bde13991cb3554d046db3691d90be
Author: Julia McClellan <juliamcclellan@google.com>
Date: Mon Apr 25 15:44:17 2022

Support setting the tint of all icons in a toolbar.

Test: unit tests for the toolbar method
Bug: 128665405
Relnote: Added setIconTint method to Toolbar and ActionMenuView
Change-Id: I704433bb807a06aa61e60ea3b9be68d2bbcff96a

M appcompat/appcompat/src/androidTest/java/androidx/appcompat/widget/ToolbarTest.java
M appcompat/appcompat/api/restricted_current.txt
M appcompat/appcompat/api/current.txt
M appcompat/appcompat/src/main/java/androidx/appcompat/widget/Toolbar.java
M appcompat/appcompat/api/public_plus_experimental_current.txt
M appcompat/appcompat/src/main/java/androidx/appcompat/widget/ActionMenuView.java
M appcompat/appcompat/src/androidTest/res/layout/appcompat_toolbar_activity.xml

https://android-review.googlesource.com/2077722

ju...@google.com <ju...@google.com> May 16, 2022 01:15PM

Marked as fixed.

ju...@google.com <ju...@google.com> May 25, 2022 08:30PM

Status: Assigned (reopened)

ap...@google.com <ap...@google.com> #6Jun 3, 2022 07:01PM

Project: platform/frameworks/support
Branch: androidx-main

commit b4e760795289651b85191452ec1fc67cbca43fd7
Author: Julia McClellan <juliamcclellan@google.com>
Date: Wed May 25 20:46:27 2022

Revert "Support setting the tint of all icons in a toolbar."

This reverts commit 2af1286be31bde13991cb3554d046db3691d90be.

Reason for revert: This implementation doesn't correctly set the tint of an item if, after the toolbar's tint is set, a menu defined in XML is inflated into the toolbar which has items with tint defined in the XML. There isn't a clean way to handle this case given the structure of the library.

Test: N/A
Relnote: Remove setIconTint method from Toolbar and ActionMenuView
Bug: 128665405
Bug: 233373535
Change-Id: I00619f993e57e7b72b9432ff841450d2445c28a6

M appcompat/appcompat/src/androidTest/java/androidx/appcompat/widget/ToolbarTest.java
M appcompat/appcompat/api/restricted_current.txt
M appcompat/appcompat/api/current.txt
M appcompat/appcompat/api/public_plus_experimental_current.txt
M appcompat/appcompat/src/main/java/androidx/appcompat/widget/Toolbar.java
M appcompat/appcompat/src/main/java/androidx/appcompat/widget/ActionMenuView.java
M appcompat/appcompat/src/androidTest/res/layout/appcompat_toolbar_activity.xml

https://android-review.googlesource.com/2106827

ju...@google.com <ju...@google.com> #7Jun 3, 2022 07:06PM

Status: Won't Fix (Infeasible)

Given the structure of the library, there isn't a good way to ensure the tint of icons on a toolbar are set correctly in all cases. For instance if, after the toolbar's tint is set, a menu defined in XML is inflated into the toolbar which has items with tint defined in the XML, it isn't feasible to override the tint from the XML for those items.