Can't refactor class [128851036]

Fixed

Bug

Reviewed (L1)

Status Update

No update yet.

Description

pe...@gmail.com

created issue #1

Mar 19, 2019 10:35AM

When trying to refactor and move a class from one module (A) to another module (B) (where A already has a dependency to B). The UI doesn't work

Build: 3.3.2, AI-182.5107.16.33.5314842, 201902152344,

AI-182.5107.16.33.5314842, JRE 1.8.0_152-release-1248-b01x64 JetBrains s.r.o, OS Mac OS X(x86_64) v10.13.6 unknown, screens 1440x900; Retina

Android Gradle Plugin: 3.3.0
Gradle: 4.10.1
NDK: from local.properties: (not specified); latest from SDK: (not found);
LLDB: pinned revision 3.1 not found; latest from SDK: (package not found);
CMake: from local.properties: (not specified); latest from SDK: (not found); from PATH: (not found);
Source: user_sentiment_feedback

IMPORTANT: Please read

https://developer.android.com/studio/report-bugs.html carefully and supply all required information.

Comments

rm...@google.com <rm...@google.com> #2Mar 20, 2019 08:31AM

Assigned to pe...@gmail.com.

Can you be more specific about 'The UI doesnt work'? Is the Android Studio freezing after the refactoring or is it issue with Layout editor?

If the issue is specific to Android Studio freezing post refactoring , can you share the idea.log file found@ (select Help > Show Log in Finder/Explorer) if this issue reproduces again

pe...@gmail.com <pe...@gmail.com> #3Mar 20, 2019 11:50AM

When trying to move a class from one module to another the Move dialog opens. Both preview and refactor buttons are enabled. When clicking Refactor "something" happens (we see a short flickering, but then it goes away) but it doesn't refactor. The dialog is now still showing the original "Move" options, but clicking either Refactor or Preview does nothing (the class/classes don't get moved at all) and there is no error message or anything indicating what went wrong?

pe...@gmail.com <pe...@gmail.com> #4Mar 20, 2019 11:54AM

Tried it again and here is the log (got an error):

2019-03-20 12:51:15,064 [thread 186] ERROR - oring.BaseRefactoringProcessor - text range null for AndroidLightField:view_toolbar_authenticate; class org.jetbrains.android.augment.AndroidLightField
java.lang.IllegalArgumentException: text range null for AndroidLightField:view_toolbar_authenticate; class org.jetbrains.android.augment.AndroidLightField
at com.intellij.usageView.UsageInfo.<init>(UsageInfo.java:46)
at com.intellij.usageView.UsageInfo.<init>(UsageInfo.java:116)
at com.intellij.usageView.UsageInfo.<init>(UsageInfo.java:138)
at org.jetbrains.kotlin.idea.refactoring.move.moveDeclarations.ConflictUsageInfo.<init>(MoveKotlinDeclarationsProcessor.kt:124)
at org.jetbrains.kotlin.idea.refactoring.move.moveDeclarations.MoveKotlinDeclarationsProcessor.getConflictsAsUsages(MoveKotlinDeclarationsProcessor.kt:172)
at org.jetbrains.kotlin.idea.refactoring.move.moveFilesOrDirectories.MoveKotlinFileHandler.findUsages(MoveKotlinFileHandler.kt:129)
at org.jetbrains.kotlin.idea.refactoring.move.moveFilesOrDirectories.MoveKotlinFileHandler.findUsages(MoveKotlinFileHandler.kt:116)
at com.intellij.refactoring.move.moveFilesOrDirectories.MoveFilesOrDirectoriesProcessor.findElementUsages(MoveFilesOrDirectoriesProcessor.java:121)
at com.intellij.refactoring.move.moveFilesOrDirectories.MoveFilesOrDirectoriesProcessor.findUsages(MoveFilesOrDirectoriesProcessor.java:109)
at org.jetbrains.kotlin.idea.refactoring.move.moveDeclarations.KotlinAwareMoveFilesOrDirectoriesProcessor.findUsages(KotlinAwareMoveFilesOrDirectoriesProcessor.kt:59)
at com.intellij.openapi.application.impl.ApplicationImpl.runReadAction(ApplicationImpl.java:959)
at com.intellij.openapi.application.ReadAction.compute(ReadAction.java:57)
at com.intellij.refactoring.BaseRefactoringProcessor.lambda$doRun$0(BaseRefactoringProcessor.java:189)
at com.intellij.openapi.progress.impl.CoreProgressManager$2.run(CoreProgressManager.java:247)
at com.intellij.openapi.progress.impl.CoreProgressManager$TaskRunnable.run(CoreProgressManager.java:736)
at com.intellij.openapi.progress.impl.CoreProgressManager$5.run(CoreProgressManager.java:434)
at com.intellij.openapi.progress.impl.CoreProgressManager.lambda$runProcess$1(CoreProgressManager.java:157)
at com.intellij.openapi.progress.impl.CoreProgressManager.registerIndicatorAndRun(CoreProgressManager.java:580)
at com.intellij.openapi.progress.impl.CoreProgressManager.executeProcessUnderProgress(CoreProgressManager.java:525)
at com.intellij.openapi.progress.impl.ProgressManagerImpl.executeProcessUnderProgress(ProgressManagerImpl.java:85)
at com.intellij.openapi.progress.impl.CoreProgressManager.runProcess(CoreProgressManager.java:144)
at com.intellij.openapi.application.impl.ApplicationImpl.lambda$null$10(ApplicationImpl.java:574)
at com.intellij.openapi.application.impl.ApplicationImpl$1.run(ApplicationImpl.java:314)
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
at java.lang.Thread.run(Thread.java:745)
2019-03-20 12:51:15,066 [thread 186] ERROR - oring.BaseRefactoringProcessor - Android Studio 3.3.2 Build #AI-182.5107.16.33.5314842
2019-03-20 12:51:15,066 [thread 186] ERROR - oring.BaseRefactoringProcessor - JDK: 1.8.0_152-release
2019-03-20 12:51:15,066 [thread 186] ERROR - oring.BaseRefactoringProcessor - VM: OpenJDK 64-Bit Server VM
2019-03-20 12:51:15,066 [thread 186] ERROR - oring.BaseRefactoringProcessor - Vendor: JetBrains s.r.o
2019-03-20 12:51:15,066 [thread 186] ERROR - oring.BaseRefactoringProcessor - OS: Mac OS X
2019-03-20 12:51:15,066 [thread 186] ERROR - oring.BaseRefactoringProcessor - Last Action: $Paste
2019-03-20 12:51:17,463 [thread 186] ERROR - oring.BaseRefactoringProcessor - text range null for AndroidLightField:view_toolbar_authenticate; class org.jetbrains.android.augment.AndroidLightField
java.lang.IllegalArgumentException: text range null for AndroidLightField:view_toolbar_authenticate; class org.jetbrains.android.augment.AndroidLightField
at com.intellij.usageView.UsageInfo.<init>(UsageInfo.java:46)
at com.intellij.usageView.UsageInfo.<init>(UsageInfo.java:116)
at com.intellij.usageView.UsageInfo.<init>(UsageInfo.java:138)
at org.jetbrains.kotlin.idea.refactoring.move.moveDeclarations.ConflictUsageInfo.<init>(MoveKotlinDeclarationsProcessor.kt:124)
at org.jetbrains.kotlin.idea.refactoring.move.moveDeclarations.MoveKotlinDeclarationsProcessor.getConflictsAsUsages(MoveKotlinDeclarationsProcessor.kt:172)
at org.jetbrains.kotlin.idea.refactoring.move.moveFilesOrDirectories.MoveKotlinFileHandler.findUsages(MoveKotlinFileHandler.kt:129)
at org.jetbrains.kotlin.idea.refactoring.move.moveFilesOrDirectories.MoveKotlinFileHandler.findUsages(MoveKotlinFileHandler.kt:116)
at com.intellij.refactoring.move.moveFilesOrDirectories.MoveFilesOrDirectoriesProcessor.findElementUsages(MoveFilesOrDirectoriesProcessor.java:121)
at com.intellij.refactoring.move.moveFilesOrDirectories.MoveFilesOrDirectoriesProcessor.findUsages(MoveFilesOrDirectoriesProcessor.java:109)
at org.jetbrains.kotlin.idea.refactoring.move.moveDeclarations.KotlinAwareMoveFilesOrDirectoriesProcessor.findUsages(KotlinAwareMoveFilesOrDirectoriesProcessor.kt:59)
at com.intellij.openapi.application.impl.ApplicationImpl.runReadAction(ApplicationImpl.java:959)
at com.intellij.openapi.application.ReadAction.compute(ReadAction.java:57)
at com.intellij.refactoring.BaseRefactoringProcessor.lambda$doRun$0(BaseRefactoringProcessor.java:189)
at com.intellij.openapi.progress.impl.CoreProgressManager$2.run(CoreProgressManager.java:247)
at com.intellij.openapi.progress.impl.CoreProgressManager$TaskRunnable.run(CoreProgressManager.java:736)
at com.intellij.openapi.progress.impl.CoreProgressManager$5.run(CoreProgressManager.java:434)
at com.intellij.openapi.progress.impl.CoreProgressManager.lambda$runProcess$1(CoreProgressManager.java:157)
at com.intellij.openapi.progress.impl.CoreProgressManager.registerIndicatorAndRun(CoreProgressManager.java:580)
at com.intellij.openapi.progress.impl.CoreProgressManager.executeProcessUnderProgress(CoreProgressManager.java:525)
at com.intellij.openapi.progress.impl.ProgressManagerImpl.executeProcessUnderProgress(ProgressManagerImpl.java:85)
at com.intellij.openapi.progress.impl.CoreProgressManager.runProcess(CoreProgressManager.java:144)
at com.intellij.openapi.application.impl.ApplicationImpl.lambda$null$10(ApplicationImpl.java:574)
at com.intellij.openapi.application.impl.ApplicationImpl$1.run(ApplicationImpl.java:314)
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
at java.lang.Thread.run(Thread.java:745)
2019-03-20 12:51:17,464 [thread 186] ERROR - oring.BaseRefactoringProcessor - Android Studio 3.3.2 Build #AI-182.5107.16.33.5314842
2019-03-20 12:51:17,464 [thread 186] ERROR - oring.BaseRefactoringProcessor - JDK: 1.8.0_152-release
2019-03-20 12:51:17,464 [thread 186] ERROR - oring.BaseRefactoringProcessor - VM: OpenJDK 64-Bit Server VM
2019-03-20 12:51:17,464 [thread 186] ERROR - oring.BaseRefactoringProcessor - Vendor: JetBrains s.r.o
2019-03-20 12:51:17,464 [thread 186] ERROR - oring.BaseRefactoringProcessor - OS: Mac OS X
2019-03-20 12:51:17,464 [thread 186] ERROR - oring.BaseRefactoringProcessor - Last Action: $Paste

pe...@gmail.com <pe...@gmail.com> #5Mar 20, 2019 11:57AM

The classes are Custom Views (in Kotlin) using synthetic view imports. The related layouts are not included in the move (only Kotlin classes). I'd expect to see a warning in the dialog or something rather than the current behaviour?

rm...@google.com <rm...@google.com> #6Mar 22, 2019 06:25AM

Reassigned to ra...@google.com.

Thank you for your feedback. Team may reach out for more feedback in reproducing or triaging this issue.

ra...@google.com <ra...@google.com> #7May 11, 2019 05:49AM

Fix pending.

ra...@google.com <ra...@google.com> #8May 17, 2019 10:43PM

Marked as fixed.

Fixed for 3.5 Beta 4.