Change theme
Help
Press space for more information.
Show links for this issue (Shortcut: i, l)
Copy issue ID
Previous Issue (Shortcut: k)
Next Issue (Shortcut: j)
Sign in to use full features.
Vote: I am impacted
Notification menu
Refresh (Shortcut: Shift+r)
Go home (Shortcut: u)
Use Markdown for this comment
Set severity, which reflects how much the issue affects the use of the product
Change issue status back to 'Assigned'
Pending code changes (auto-populated)
[ID: 84651]
Story points rate the relative effort of work in a Fibonacci-like format: 0, 0.5, 1, 2, 3, 5, 8, 13, 20, 40, 100. Each team will estimate work on a slightly different scale, which means the values in this field are likely only meaningful to the team that owns the Buganizer component in which the issue resides.
See Atlassian's Agile Coach for more information on how to use story points for estimation: https://www.atlassian.com/agile/project-management/estimation [ID: 746686]
Set the version(s) of the product affected by this issue (comma-separated list)
Set the version(s) of the product in which the issue should be fixed (comma-separated list)
Set the version(s) of the product in which the issue fix was verified (comma-separated list)
Set if this issue occurs in production
[ID: 85206]
Set Reporter
Set Type
Set priority, which reflects how soon the issue should be fixed
Set Status
Set Assignee
Set Verifier
Remove item
View or edit staffing
View issue level access limits(Press Alt + Right arrow for more information)
Description
#1Version used: 2.0.0
Devices/Android versions reproduced on: n/a
Android Studio 3.3.2
Build #AI-182.5107.16.33.5314842, built on February 15, 2019
JRE: 1.8.0_152-release-1248-b01 amd64
JVM: OpenJDK 64-Bit Server VM by JetBrains s.r.o
Linux 4.15.0-46-generic
com.android.tools.build:gradle:3.3.2
gradle-4.10.3-all
I have a destination with a nullable String argument:
<fragment
android:id="@+id/editFragment"
android:name="com.commonsware.todo.ui.edit.EditFragment"
android:label="@string/app_name" >
<argument
android:name="modelId"
app:argType="string"
app:nullable="true" />
</fragment>
I have an action that attempts to declare null as the default value:
<action
android:id="@+id/createModel"
app:destination="@id/editFragment" >
<argument
android:name="modelId"
android:defaultValue="@null" />
</action>
The generated SafeArgs code treats @null as a String:
private data class CreateModel(val modelId: String = "@null") : NavDirections {
override fun getActionId(): Int = R.id.createModel
override fun getArguments(): Bundle {
val result = Bundle()
result.putString("modelId", this.modelId)
return result
}
}
fun createModel(modelId: String = "@null"): NavDirections = CreateModel(modelId)
IOW, I am seeing similar symptoms to
If I remove the default value, the SafeArgs-generated code goes back to supporting null, just without a default null:
private data class CreateModel(val modelId: String?) : NavDirections {
override fun getActionId(): Int = R.id.createModel
override fun getArguments(): Bundle {
val result = Bundle()
result.putString("modelId", this.modelId)
return result
}
}
fun createModel(modelId: String?): NavDirections = CreateModel(modelId)
Let me know if you need additional information -- thanks!