IssueTracker

Could you look into it @christofferqa?

The issue is with this class:

class MySpi : Spi {
    @Volatile
    private var myApi: Api? = null

    // Incorrectly rewritten to return null;
    override fun createApi(): Api {
        return myApi ?: synchronized(this) {
            myApi ?: MyApi().also { myApi = it }
        }
    }
}

The error seems to be that the ArgumentPropagator believes that the fieldState of myApi is ExactDynamicType(@NotNull MyApi) while it should be ExactDynamicType(@Nullable MyApi)

It then removes the first branch (assuming myApi is not null):

return myApi ?: synchronized(this) {
            myApi ?: MyApi().also { myApi = it }
        }

is rewritten into:

return myApi

And then it eventually concludes that myApi is always null, replacing the code by

return null

The ArgumentPropagatorCodeScanner analyzes the assignment myApi = it and correctly set join the state to ExactDynamicType(@NotNull MyApi)

However the ArgumentPropagator fails to understand that myApi can be read before being written in the method, relying on the default null value, so it fails to join null to the dynamic type.

Yes I can take a look. Would it be possible for you to add a regression test of this issue?

Project: r8
Branch: main
Author: Christoffer Adamsen <christofferqa@google.com>
Link:      https://r8-review.googlesource.com/101407

Reproduce field propagation issue with ServiceLoader

Reproduce field propagation issue with ServiceLoader 
 
Bug: b/389737060 
Change-Id: Id850448f68b999194bc0380dfca625f4f68bc31b