Fixed
Status Update
Comments
vi...@google.com <vi...@google.com> #2
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 164bb50bcabe96a05e80c2d9ce03533e1dc6d26e
Author: Ian Lake <ilake@google.com>
Date: Mon Oct 14 11:03:23 2019
Fix FragmentContainerView inflation with obfuscation
Instead of using a literal for the class name, using
FragmentContainerView.class.getName() to support
obfuscation via ProGuard.
Test: ran testapp with obfuscation
Fixes: 142657034
Change-Id: I9ae40ddb5d3308790d6963f09f3eb110837dbb4c
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentLayoutInflaterFactory.java
https://android-review.googlesource.com/1142236
https://goto.google.com/android-sha1/164bb50bcabe96a05e80c2d9ce03533e1dc6d26e
Branch: androidx-master-dev
commit 164bb50bcabe96a05e80c2d9ce03533e1dc6d26e
Author: Ian Lake <ilake@google.com>
Date: Mon Oct 14 11:03:23 2019
Fix FragmentContainerView inflation with obfuscation
Instead of using a literal for the class name, using
FragmentContainerView.class.getName() to support
obfuscation via ProGuard.
Test: ran testapp with obfuscation
Fixes: 142657034
Change-Id: I9ae40ddb5d3308790d6963f09f3eb110837dbb4c
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentLayoutInflaterFactory.java
vi...@google.com <vi...@google.com> #3
li...@gmail.com <li...@gmail.com> #4
I am very sorry to reply this so late. i thought it was very clear in comment #1 .
This is not a bug, just want to add a new feature.
In my case, i need to expand the height of the toolbar, and we want the menu button to be vertically in center of this toolbar, but buttonGravity api only accept Gravity.TOP or Gravity.BOTTOM, so we can only achieve it in a hack way ( set the value of buttonGravity to Gravity.CENTER_VERTICAL ), and i push my code tohttps://github.com/lixi0912/ToolbarExpandHeightDemo
This is not a bug, just want to add a new feature.
In my case, i need to expand the height of the toolbar, and we want the menu button to be vertically in center of this toolbar, but buttonGravity api only accept Gravity.TOP or Gravity.BOTTOM, so we can only achieve it in a hack way ( set the value of buttonGravity to Gravity.CENTER_VERTICAL ), and i push my code to
vi...@google.com <vi...@google.com> #5
We have passed this defect onto the development team and will update this issue with more information as it becomes available.
Description
Version used: 1.1.0-alpha04
Theme used: Theme.MaterialComponents.DayNight.NoActionBar
Devices/Android versions reproduced on: android pie
- When I set toolbar_maxButtonHeight, since buttonGravity can only be set to top and bottom, it does not meet the CENTER_VERTICAL requirements of the design.