Using Deep Link causes a "flash" that appears like multiple apps are opening [130362979]

Fixed

Bug

Status Update

No update yet.

Description

br...@gmail.com

created issue #1

Apr 11, 2019 07:16PM

Component used: Navigation
Version used: 2.1.0-alpha02
Devices/Android versions reproduced on: Pixel 3XL, APi 28

When using an implicit deep link to open an app to a destination that is not the root/home destination, the user experiences a weird "flash" on the device, where it appears to open the app, and then open the app again. See the attached animated gif for a demo of the flash effect.

The attached sample app, QueryString can be used to reproduce the issue. The app contains two destination fragments, RootFragment and ChildFragment. In the navigation graph, RootFragment is the start destination, and contains an action to navigate to ChildFragment. Child Fragment also has a <deeplink> with it's URI set to "

bradball.net/child".

To reproduce the "flash" effect:
1. open, build, and install the sample app on a device or emulator
2. Open the app to make sure it's working
3. Close the app (swipe it away from the recents screen).
3. Open a link to

https://bradball.net/child from another app. On an emulator, you can send a text message to the messages app with the URL in the message, and then tap on the link in the messages app.

When you tap on the link in the messages app, you'll see the "flash" of the app opening, and the the app opening again.

QueryString.zip

1.1 MB

Download

screenflash.gif

3.5 MB

View

Download

Comments

il...@google.com <il...@google.com> #2Apr 11, 2019 08:22PM

Assigned to il...@google.com.

since these are in public API (:/) we need to do this in 1.2

th...@gmail.com <th...@gmail.com> #3Apr 11, 2019 08:43PM

since it is already marked as deprecated, we can probably do it by now.

br...@gmail.com <br...@gmail.com> #4Apr 11, 2019 09:24PM

Opening diff shortly

il...@google.com <il...@google.com> Jun 3, 2019 05:57PM

Reassigned to jb...@google.com.

ap...@google.com <ap...@google.com> #5Jun 3, 2019 09:45PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit d576cbdc911cba16638a44fd8223391a90a07ef7
Author: Mike Nakhimovich <digitalbuddha@users.noreply.github.com>
Date: Tue Aug 11 09:30:34 2020

[GH] Hide deprecated internal API.

## Proposed Changes

* `RoomDatabase.java` has protected `mCallbacks` field which is leaking in the API docs, we should @Hide it.

## Testing

Test: Ran unit tests locally

## Issues Fixed

Fixes: 76109329

This is an imported pull request from

https://github.com/androidx/androidx/pull/61.

Resolves #61
Github-Pr-Head-Sha: 6440daa3a63752c7f9d5ba2a390248cd85bc634f
GitOrigin-RevId: fe92d8466a59b44b218b6ca3cbd57dcda17992f7

Change-Id: Id599cdf5b02b32bdae0166266fb7da967598fe92

A room/runtime/api/current.ignore
M room/runtime/api/current.txt
M room/runtime/api/public_plus_experimental_current.txt
M room/runtime/api/restricted_current.txt
M room/runtime/src/main/java/androidx/room/RoomDatabase.java

https://android-review.googlesource.com/1396827

jb...@google.com <jb...@google.com> #6Jun 3, 2019 09:50PM

Marked as fixed.

This has been fixed internally, and will be available in the Navigation 2.1.0-alpha06 release.

Issue 130362979