Using Deep Link causes a "flash" that appears like multiple apps are opening [130362979]

Fixed

Bug

Status Update

No update yet.

Description

br...@gmail.com

created issue #1

Apr 11, 2019 07:16PM

Component used: Navigation
Version used: 2.1.0-alpha02
Devices/Android versions reproduced on: Pixel 3XL, APi 28

When using an implicit deep link to open an app to a destination that is not the root/home destination, the user experiences a weird "flash" on the device, where it appears to open the app, and then open the app again. See the attached animated gif for a demo of the flash effect.

The attached sample app, QueryString can be used to reproduce the issue. The app contains two destination fragments, RootFragment and ChildFragment. In the navigation graph, RootFragment is the start destination, and contains an action to navigate to ChildFragment. Child Fragment also has a <deeplink> with it's URI set to "

bradball.net/child".

To reproduce the "flash" effect:
1. open, build, and install the sample app on a device or emulator
2. Open the app to make sure it's working
3. Close the app (swipe it away from the recents screen).
3. Open a link to

https://bradball.net/child from another app. On an emulator, you can send a text message to the messages app with the URL in the message, and then tap on the link in the messages app.

When you tap on the link in the messages app, you'll see the "flash" of the app opening, and the the app opening again.

QueryString.zip

1.1 MB

Download

screenflash.gif

3.5 MB

View

Download

Comments

il...@google.com <il...@google.com> #2Apr 11, 2019 08:22PM

Assigned to il...@google.com.

Project: platform/frameworks/support
Branch: androidx-master-dev

commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019

Change the way to detect mismatch between POJO and query

This fixes cursor mismatch warnings with expandProjection.

Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8

M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt

https://android-review.googlesource.com/1123258

https://goto.google.com/android-sha1/b90079595f33f58fece04026a97faa0d243acdb1

th...@gmail.com <th...@gmail.com> #3Apr 11, 2019 08:43PM

The following changes were cherrypicked through Coastguard (

https://android-build.googleplex.com/coastguard/)
Release Track: (

https://android-build.googleplex.com/coastguard/dashboard/6093116828680192/#/cherrypickHistory/all)
Created: 2019-10-14 17:23:42.610596+00:00
Changes: aosp/1123258

br...@gmail.com <br...@gmail.com> #4Apr 11, 2019 09:24PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020

Re-factor how errors are dismissed when query is re-written

This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically (

b/140759491

).
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.

This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.

Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f

M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt

https://android-review.googlesource.com/1288456

il...@google.com <il...@google.com> Jun 3, 2019 05:57PM

Reassigned to jb...@google.com.

ap...@google.com <ap...@google.com> #5Jun 3, 2019 09:45PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit bf078f4a67eba20592a5830e75a5e6adbd63d1a0
Author: jbwoods <jbwoods@google.com>
Date: Mon Jun 03 13:12:21 2019

Disable double activity animation when opening app with deeplink

When using handleDeepLink(Intent) to open an app, Navigation enforces
that Intents that set the NEW_TASK flag also set the CLEAR_TASK flag.
This ensures a consistent activity back stack, and means that the
Activity should be created twice when the calling app only uses
NEW_TASK. Both Activity creations are currently being animated, causing
what appears as a flash before the app starts.

This change ensures that the second Activity creation animation is
disabled.

Test: Tested in app, all tests pass.
BUG: 130362979
Change-Id: Ie765aea34176508b7c1b4b897ca25e0d11b2d819

M navigation/runtime/src/main/java/androidx/navigation/NavController.java

https://android-review.googlesource.com/975586

https://goto.google.com/android-sha1/bf078f4a67eba20592a5830e75a5e6adbd63d1a0

jb...@google.com <jb...@google.com> #6Jun 3, 2019 09:50PM

Marked as fixed.

This has been fixed internally, and will be available in the Navigation 2.1.0-alpha06 release.

Issue 130362979