ShareTargetXmlParser uses hardcoded resource name [130500127]

Fixed

Bug

Status Update

No update yet.

Description

ck...@gmail.com

created issue #1

Apr 15, 2019 01:37AM

ShareTargetXmlParser currently uses a hardcoded resource name of "shortcuts" to read the share targets. It silently fails to parse share targets when they are specified in a resource file using a different name, e.g.

<meta-data
android:name="android.app.shortcuts"
android:resource="@xml/my_shortcuts_here" />

Relevant ShareTargetXmlParser code:

https://android.googlesource.com/platform/frameworks/support/+/237c8946756af4b0fe9d0fa3965593e247d53698/sharetarget/src/main/java/androidx/sharetarget/ShareTargetXmlParser.java#103

Mark Murphy wrote a blog post about this:

https://commonsware.com/blog/2019/04/14/about-share-targets-magic-names.html

Comments

mm...@commonsware.com <mm...@commonsware.com> #2Jun 13, 2019 04:21PM

Project: platform/frameworks/support
Branch: androidx-main

commit 06035833f0e98b6116774b743c75c2cc7c334326
Author: Ember Rose <emberrose@google.com>
Date: Mon May 17 15:52:36 2021

Create @AppCompatShadowedAttributes

This annotation is restricted to intra-androidx library usage. When
applied to a View in AppCompat, it will direct the annotation processor
to infer shadowed attributes for the View based on what interfaces from
Core it implements, e.g.: TintableBackgroundView.

Test: N/A
Relnote: Improved AppCompat support
Bug: 188446121
Change-Id: I2d7387a017585bcea14a8d8a857b9b60930bc1c5

M resourceinspection/resourceinspection-annotation/api/restricted_current.txt
A resourceinspection/resourceinspection-annotation/src/main/java/androidx/resourceinspection/annotation/AppCompatShadowedAttributes.java

https://android-review.googlesource.com/1709335

me...@google.com <me...@google.com> #3Jun 13, 2019 05:55PM

Marked as fixed, reassigned to me...@google.com.

Project: platform/frameworks/support
Branch: androidx-main

commit 42f9ba7d4ccd46960123b403df5ca28803643059
Author: Ember Rose <emberrose@google.com>
Date: Mon May 17 17:41:24 2021

Refactor resource inspection processor model

Extract an Attribute interface to generate code for either shadowed or
annotated regular attributes.

Test: ResourceInspectionProcessorTest
Bug: 188446121
Change-Id: I131f017c433ec9e44a6fb364c903467894735377

M resourceinspection/resourceinspection-processor/src/main/kotlin/androidx/resourceinspection/processor/InspectionCompanionGeneration.kt
M resourceinspection/resourceinspection-processor/src/main/kotlin/androidx/resourceinspection/processor/LayoutInspectionStep.kt
M resourceinspection/resourceinspection-processor/src/main/kotlin/androidx/resourceinspection/processor/Models.kt

https://android-review.googlesource.com/1709337

Issue 130500127

Description

Issue summary

Comments

mm...@commonsware.com <mm...@commonsware.com> #2Jun 13, 2019 04:21PM

me...@google.com <me...@google.com> #3Jun 13, 2019 05:55PM

Add comment

Issue metadata