Default arguments is null for startDestination in OnDestinationChangedListener [130630686]

Fixed

Bug

Status Update

No update yet.

Description

ev...@gmail.com

created issue #1

Apr 17, 2019 10:19AM

Component used: Navigation
Version used:2.0.0
Devices/Android versions reproduced on:Emulator 8.0, Pixel 2 XL 9.x

So basically for reproduce you need simple flow:
1. Graph with Fragment with arguments with default values as default destination
2. Main Activity launcher which hosts the graph
3. in Activity.onCreate() start listen for destination changes:
navController.addOnDestinationChangedListener { controller, destination, arguments -> }
4. When activity first creates onDestinationChanged() gets called but arguments is null.

Fragment will receive those default arguments tho.
This happens only if fragment is startDestination. If we navigate to this fragment otherwise (clicks, menus) with NavController.navigate() default arguments will be at place.

Comments

il...@google.com <il...@google.com> #2Apr 17, 2019 05:57PM

A couple of questions:

1. Have you saw crash in real device or only in simulators?
2. Do you use dynamic feature for language ID?

ev...@gmail.com <ev...@gmail.com> #3Apr 17, 2019 07:50PM

Tested on Android 12 Emulator with custom executor, but cannot repro this issue.

il...@google.com <il...@google.com> Apr 17, 2019 08:48PM

Accepted by il...@google.com.

ap...@google.com <ap...@google.com> #4Apr 18, 2019 05:40PM

Marked as fixed.

Second crash in the description is from a real device. Experienced it myself on two different Xiaomi phones, plus lots of crashes from users in the Google Play console.
Dynamic features are not used in the application.

As a wild guess, I have downgraded build tools from 31.0.0 to 30.0.3, compileSdk from 31 to 30, and moved all work with Language ID to the service in a separate process (just to be sure that crash can kill secondary process instead of main). This combination is in beta for 2 days by now and I don't see any SIGSEGV crashes.

il...@google.com <il...@google.com> #5Apr 18, 2019 05:45PM

Hmm, I feel the crash might be something related to separate/secondary process.

I also changed compileSdk and targetSDK to 31 but still cannot repro this issue.

ev...@gmail.com <ev...@gmail.com> #6Apr 18, 2019 05:57PM

On the contrary, there was no separate process before, when crashes started.

In the new build (with the aforementioned changes) I can see SIGSEGV crash, but only one instead of dozens and it has a bit different backtrace:

signal 11 (SIGSEGV), code 1 (SEGV_MAPERR)
liblanguage_id_jni.so (offset 0x11e000)

backtrace:
  #00  pc 000000000003c7c0  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 000000000003b960  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 000000000003bb48  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 000000000003bafc  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 0000000000036c98  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 0000000000032714  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 0000000000031cac  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 0000000000057438  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/oat/arm64/base.odex (offset 0x57000)

Issue 130630686