[ViewPager2] Using SwipeRefreshLayout in ViewPager2 is broken for swipe-refresh gesture [131115697]

Fixed

Bug

Status Update

No update yet.

Description

ja...@skrasek.com

created issue #1

Apr 23, 2019 12:22PM

If I use SwipeRefreshLayout in ViewPager2, it is very difficult to make the swipe-refresh gesture. Almost every time it catches the gesture and evaluates it as page-swipe gesture (which may not happen since the the x-velocity is pretty small).
(Tabs are horizontally laid out, swipe-refresh is vertical)

This worked in ViewPager.
Used version: androidx.viewpager2:viewpager2:1.0.0-alpha03

Not sure if its related to

https://issuetracker.google.com/issues/123006042

Comments

jg...@google.com <jg...@google.com> #2Apr 24, 2019 06:32PM

Since this is happening in Tink, rather than in the AndroidX library, it would be best to open an issue with that project, as there isn't an easy way for us to fix this.

ja...@skrasek.com <ja...@skrasek.com> #3Apr 25, 2019 08:15AM

@2 I don't know what "Tink" is, but here, created:

https://github.com/google/tink/issues/534

Would this mean that this bug report should be written there as well:

https://issuetracker.google.com/issues/176215143
?

TabBug.zip

137 KB

Download

jg...@google.com <jg...@google.com> #4Apr 29, 2019 11:26AM

Tink is the library that does the heavy lifting in Jetpack Security.

And yes, potentially raising that issue with the Tink team directly could help.

ja...@skrasek.com <ja...@skrasek.com> #5May 22, 2019 10:54AM

@4 Well why didn't Google offer it there? Crashes are far more important than warning logs...
Here, created it there too:

https://github.com/google/tink/issues/535

je...@google.com <je...@google.com> #6May 23, 2019 11:00AM

Anyone here solved the issue? I have implemented the jetpack security and got the same crashes.

je...@google.com <je...@google.com> May 23, 2019 05:53PM

Accepted by je...@google.com.

je...@google.com <je...@google.com> #7May 24, 2019 04:59PM

same warning

je...@google.com <je...@google.com> #8May 30, 2019 03:05PM

same logs for me

th...@gmail.com <th...@gmail.com> #9May 31, 2019 11:39AM

same warning for me

je...@google.com <je...@google.com> #10Jun 18, 2019 10:15AM

Does anyone find any solution to it? I am also facing the same warning.

ja...@skrasek.com <ja...@skrasek.com> #11Jun 18, 2019 12:44PM

th...@gmail.com <th...@gmail.com> #12Jun 18, 2019 07:10PM

je...@google.com <je...@google.com> Jun 27, 2019 12:52PM

Marked as fixed.

ja...@skrasek.com <ja...@skrasek.com> #13Jul 8, 2019 08:12AM

at...@onedaycat.com <at...@onedaycat.com> #14Jul 10, 2019 06:06AM

je...@google.com <je...@google.com> #15Jul 10, 2019 10:15AM

Status: Assigned (reopened)

je...@google.com <je...@google.com> Jul 15, 2019 12:53PM

Accepted by je...@google.com.

je...@google.com <je...@google.com> #16Jul 15, 2019 08:09PM

Project: platform/frameworks/support
Branch: androidx-main

commit a505a060ec741478e4096e8d160e136de18e8f39
Author: Daniel Angell <danielangell@google.com>
Date: Thu Oct 13 12:14:15 2022

Upgrade tink to 1.7.0 in security-crypto

Changed some calls into Tink to avoid deprecation warnings.

Bug: 185219606 (and likely others)
Test: Ran the security-crypto test suite
Change-Id: I7b1dcb3bf3f5d018a93ac3b06280724559f63ded

M security/security-crypto/build.gradle
M security/security-crypto/src/main/java/androidx/security/crypto/EncryptedFile.java
M security/security-crypto/src/main/java/androidx/security/crypto/EncryptedSharedPreferences.java

https://android-review.googlesource.com/2255035

ap...@google.com <ap...@google.com> #17Jul 24, 2019 05:44PM

It's not just fixed. It's also finally available.
i wonder what about the rare crashes though.

je...@google.com <je...@google.com> #18Jul 25, 2019 04:56PM

Marked as fixed.

I'm pretty new on this project and I haven't dug deep into all of the strange behavior reported. But having read many of the bug reports my initial guess is crashes on initialization are related to encrypted files that got restored from a backup. If you back up all of an app's files - including EncryptedSharedPreferences - and then restore after moving to a new device, factory restoring a device, or perhaps even uninstalling and reinstalling an app, you will crash and it might not be clear why. The recommended way to use the security jetpack library lends to these kinds of errors. The files get encrypted with a key that won't be available inside of a backup copy. So decryption will always fail if that key isn't there when restoring from a backup.

Issue 131115697

Description

Issue summary

Comments

jg...@google.com <jg...@google.com> #2Apr 24, 2019 06:32PM

ja...@skrasek.com <ja...@skrasek.com> #3Apr 25, 2019 08:15AM

jg...@google.com <jg...@google.com> #4Apr 29, 2019 11:26AM

ja...@skrasek.com <ja...@skrasek.com> #5May 22, 2019 10:54AM

je...@google.com <je...@google.com> #6May 23, 2019 11:00AM

je...@google.com <je...@google.com> May 23, 2019 05:53PM

je...@google.com <je...@google.com> #7May 24, 2019 04:59PM

je...@google.com <je...@google.com> #8May 30, 2019 03:05PM

th...@gmail.com <th...@gmail.com> #9May 31, 2019 11:39AM

je...@google.com <je...@google.com> #10Jun 18, 2019 10:15AM

ja...@skrasek.com <ja...@skrasek.com> #11Jun 18, 2019 12:44PM

th...@gmail.com <th...@gmail.com> #12Jun 18, 2019 07:10PM

je...@google.com <je...@google.com> Jun 27, 2019 12:52PM

ja...@skrasek.com <ja...@skrasek.com> #13Jul 8, 2019 08:12AM

at...@onedaycat.com <at...@onedaycat.com> #14Jul 10, 2019 06:06AM

je...@google.com <je...@google.com> #15Jul 10, 2019 10:15AM

je...@google.com <je...@google.com> Jul 15, 2019 12:53PM

je...@google.com <je...@google.com> #16Jul 15, 2019 08:09PM

ap...@google.com <ap...@google.com> #17Jul 24, 2019 05:44PM

je...@google.com <je...@google.com> #18Jul 25, 2019 04:56PM

Add comment

Issue metadata