Status Update
Comments
di...@gmail.com <di...@gmail.com> #2
Attached reproducing video of an app using calculateWindowSizeClass
and LocalConfiguration
:
On the second time resizing to be 50%/50% from smaller, the displayed configuration is incorrect.
uc...@google.com <uc...@google.com> #3
When resizing the activity in multi-window mode under those conditions, there are cases where:
the Activity is not recreated Activity.onConfigurationChanged is not called View.onConfigurationChanged is not called
Is this just for 33 / is there a framework bug filed? The amount of broken things in configuration land we already had to workaround in Compose is a bit untenable. It seems like we are missing a lot of test coverage in the platform to avoid these issues hitting us in the future
ch...@google.com <ch...@google.com>
je...@google.com <je...@google.com> #4
In any case this seems like more ammunition for us to push more strongly on 'pure-compose apps should always opt out of configuration changes'
di...@gmail.com <di...@gmail.com> #5
Yes, API 33 introduced this behavior, (internal) platform bug is here:
je...@google.com <je...@google.com> #6
I was incorrect, this is also reproducible on API 32 as well. Not reproducible on API 31.
di...@gmail.com <di...@gmail.com> #7
Adam/Louis, how do we want to handle this one? Is there someone on platform who should take this, or since API 32 is already out in the wild maybe this should go to devrel to push more strongly on 'pure-compose apps should always opt out of configuration changes'.
je...@google.com <je...@google.com> #8
ku...@gmail.com <ku...@gmail.com> #9
I'm having issues on pre-33 api levels on a pure compose app (has all configChanges added in the manifest file) pared with AppCompatActivity
just for multi language support. When changing the language I'm using AppCompatDelegate.setApplicationLocales(compat)
which calls onConfigurationChanged
on the activity. LocalConfiguration changes to the new configuration on 33+ but remains the same on pre-33. Workaround that i've found is calling if (Build.VERSION.SDK_INT < 33) contentView.dispatchConfigurationChanged(newConfig)
in onConfigurationChanged
. I'm guessing it's a compose issue since activity wise everything works as expected.
di...@gmail.com <di...@gmail.com> #10
LocalConfiguration
but a separate issue.
je...@google.com <je...@google.com> #11
Thanks for the heads up, I've tried to find a related issue but only managed to find this one after a brief search.
je...@google.com <je...@google.com> #12
Ok
je...@google.com <je...@google.com> #13
Thanks for the heads up, I've tried to find a related issue but only managed to find this one after a brief search.
Description
Gradle Sync continues but fails on:
"Error: No value has been specified for property 'manifestOutputDirectory'."
Build: 3.4, AI-183.5429.30.34.5452501, 201904100040,
AI-183.5429.30.34.5452501, JRE 1.8.0_152-release-1343-b01x64 JetBrains s.r.o, OS Mac OS X(x86_64) v10.14.4, screens 1680x1050; Retina
Android Gradle Plugin: 3.4.0
Gradle: 5.1.1
NDK: from local.properties: 19.1.5304403; latest from SDK: 16.1.4479499;
LLDB: LLDB 3.1 (revision: 3.1.4508709)
CMake: from local.properties: (not specified); latest from SDK: 3.6.0-rc2; from PATH: 3.14.1;
Source: user_sentiment_feedback
IMPORTANT: Please read