SafeArgs - double type support request! [131207188]

Infeasible

Feature Request

Status Update

No update yet.

Description

ba...@gmail.com

created issue #1

Apr 24, 2019 08:38PM

Component used: Navigation
Version used: 1.0.0

Unfortunately, library does not support double type for safe args. Float only from real types.

Comments

il...@google.com <il...@google.com> Apr 24, 2019 08:40PM

Assigned to da...@google.com.

jb...@google.com <jb...@google.com> Jan 27, 2020 10:54PM

Reassigned to jb...@google.com.

ap...@google.com <ap...@google.com> #2May 1, 2020 12:02AM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit fbd1c7aba1fdccff0350dcdae6b187f877963d9b
Author: Jeremy Woods <jbwoods@google.com>
Date: Tue Apr 28 14:59:43 2020

Add double support to safe arg

Safe-args currently only supports Float values. Since BaseBundle has
set/get Double methods, we also have the ability to support Doubles as
well.

Test: ./gradlew --rerun-tasks navigation:navigation-safe-args-gradle-plugin:test
Bug: 131207188
Change-Id: I82a9f75af5c744dc1b22763e241c0d79c6b0363c

M navigation/navigation-safe-args-generator/src/main/kotlin/androidx/navigation/safe/args/generator/NavParser.kt
M navigation/navigation-safe-args-generator/src/main/kotlin/androidx/navigation/safe/args/generator/Types.kt
M navigation/navigation-safe-args-generator/src/main/kotlin/androidx/navigation/safe/args/generator/java/JavaNavWriter.kt
M navigation/navigation-safe-args-generator/src/main/kotlin/androidx/navigation/safe/args/generator/java/JavaTypes.kt
M navigation/navigation-safe-args-generator/src/main/kotlin/androidx/navigation/safe/args/generator/kotlin/KotlinTypes.kt
M navigation/navigation-safe-args-generator/src/test/kotlin/androidx/navigation/safe/args/generator/JavaNavWriterTest.kt
M navigation/navigation-safe-args-generator/src/test/kotlin/androidx/navigation/safe/args/generator/KotlinNavWriterTest.kt
M navigation/navigation-safe-args-generator/src/test/kotlin/androidx/navigation/safe/args/generator/NavParserTest.kt
M navigation/navigation-safe-args-generator/src/test/test-data/expected/java_nav_writer_test/MainFragmentArgs.java
M navigation/navigation-safe-args-generator/src/test/test-data/expected/kotlin_nav_writer_test/MainFragmentArgs.kt
M navigation/navigation-safe-args-generator/src/test/test-data/naive_test.xml
M navigation/navigation-safe-args-gradle-plugin/src/test/test-data/app-project-kotlin/src/main/res/navigation/nav_test.xml

https://android-review.googlesource.com/1298034

jb...@google.com <jb...@google.com> #3May 1, 2020 12:21AM

Marked as fixed.

This has been added internally and will be available in the Navigation 2.3.0-alpha07 release.

jb...@google.com <jb...@google.com> #4May 5, 2020 05:08PM

Status: Assigned (reopened)

We need more work to support this on the library side so we will go ahead to beta without this change and add support at a later date.

jb...@google.com <jb...@google.com> #5Oct 21, 2021 03:51AM

Status: Won't Fix (Infeasible)

This requires support for doubles in NavInflater whose values are all backed by the TypedValue class, which unfortunately does not support Double values so we cannot go forward with this.

Issue 131207188