IssueTracker

Project: platform/frameworks/support
Branch: androidx-master-dev

commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date:   Wed Sep 18 16:55:49 2019

    Change the way to detect mismatch between POJO and query
   
    This fixes cursor mismatch warnings with expandProjection.
   
    Bug: 140759491
    Test: QueryMethodProcessorTest
    Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8

M       room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M       room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M       room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M       room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M       room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt

https://android-review.googlesource.com/1123258
https://goto.google.com/android-sha1/b90079595f33f58fece04026a97faa0d243acdb1

  The following changes were cherrypicked through Coastguard (https://android-build.googleplex.com/coastguard/)
  Release Track: (https://android-build.googleplex.com/coastguard/dashboard/6093116828680192/#/cherrypickHistory/all)
  Created: 2019-10-14 17:23:42.610596+00:00
  Changes: aosp/1123258
 

Project: platform/frameworks/support
Branch: androidx-master-dev

commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date:   Thu Apr 16 16:47:05 2020

    Re-factor how errors are dismissed when query is re-written
   
    This CL changes how we handle errors/warnings if query is
    re-written.
    There was a bug in expandProjection where we would report warnings
    for things that Room already fixes automatically (b/140759491).
    The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
    solved it by deferring validating of columns until after re-write
    decision is made. Unfortunately, this required changing PojoRowAdapter
    to have a dummy mapping until it is validating, make it hard to use
    as it does have a non-null mapping which is not useful.
   
    This CL partially reverts that change and instead rely on the log
    deferring logic we have in Context. This way, we don't need to break
    the stability of PojoRowAdapter while still having the ability to
    drop warnings that room fixes. This will also play nicer when we
    have different query re-writing options that can use more information
    about the query results.
   
    Bug: 153387066
    Bug: 140759491
    Test: existing tests pass
    Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f

M       room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M       room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M       room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M       room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt

https://android-review.googlesource.com/1288456

+Andrey as I was looking at his older post over at https://medium.com/@andkulikov/animate-all-the-things-transitions-in-android-914af5477d50

Indeed adding android:animateLayoutChanges="true" is not enough. Some state changes are animated properly, and some are not.

I've added these lines at the beginning of ToolbarWidgetWrapper.setDisplayOptions:

        if (android.os.Build.VERSION.SDK_INT >= 19) {
            android.transition.TransitionManager.beginDelayedTransition(mToolbar);
        }

On a v19+ device toggling display options (home, up etc) seems to be working. We also have the recently added (by Andrey) transition module, but appcompat does not depend on it, and I'd really like to not pull another dependency for appcompat.

The two things I can think of here:

1. Use the beginDelayedTransition everywhere in the toolbar implementation on v19+ (for state changes)
2. Advise applications to use the transition module APIs to wrap state change calls on Toolbar (which is ViewGroup) in their code so that it works on older platform versions.

Andrey - thoughts?

Also +Dan from the MDC team since the toolbar / appbar are a big part of the material skeleton.

I think adding enabled by default transitions for the Toolbar is a huge breaking change and can affect a lot of apps's code where developer are not expecting it(don't want an animation) or already have some animation implementation applied.
More nice idea I can think of is to just recommend to use androidx Transition library for cases like this. Are developers in control of the code when this change happens? Can they manually add TransitionManager.beginDelayedTransition(mToolbar); before applying new changes to the toolbar?

Yes, developers can certainly do that. Toolbar is a view that the app developer explicitly adds to their layouts, and since it's a ViewGroup, it can be passed to that TransitionManager API.

Marking as WAI.

Just to clarify, how should I go about integrating TransitionManager.beginDelayedTransition(mToolbar); with AndroidX Navigation?

Never mind, I got it to work using this code:

        Toolbar appBar = findViewById(R.id.toolbar);
        setSupportActionBar(appBar);

        // Hook up the app bar with the navigation
        navController = Navigation.findNavController(this, R.id.nav_host_fragment);
        NavigationUI.setupActionBarWithNavController(this, navController);
        navController.addOnDestinationChangedListener((controller, destination, arguments) -> TransitionManager.beginDelayedTransition(appBar));

Thanks for your help!

Ian - is it worth adding this somewhere in the navigation module docs?

NavigationUI is the one triggering the change in app icons, so we'll add the code on our side.

Project: platform/frameworks/support
Branch: androidx-master-dev

commit e28e8678478c7c04b55886e7071750cbdea89121
Author: jbwoods <jbwoods@google.com>
Date:   Thu Jun 27 14:32:13 2019

    Animate Toolbar Changes in NavigationUI
   
    When animateLayoutChanges is set on a Toolbar, there are errors in how
    the text within the toolbar is displayed if it has an arrow. The text
    leaves a big space on destinations with no arrow.
   
    This change checks so see if the icon will be null and then uses a
    TransitionManager to animate the toolbar text into the proper position.
    We only animate when the icon is going to disappear. If we were animate
    when the icon is appearing, the new icon and text appear stacked when
    the animation begins.
   
    Test: Tested visually in app
    BUG: 131403621
    Change-Id: I97ff213bdeb6da3282287d9b572f33c74cf9e9e7

M       navigation/navigation-ui/build.gradle
M       navigation/navigation-ui/src/main/java/androidx/navigation/ui/CollapsingToolbarOnDestinationChangedListener.java
M       navigation/navigation-ui/src/main/java/androidx/navigation/ui/ToolbarOnDestinationChangedListener.java

https://android-review.googlesource.com/1007867
https://goto.google.com/android-sha1/e28e8678478c7c04b55886e7071750cbdea89121

This has been fixed internally and will be available in the Navigation 2.1.0-beta01 release.