Fixed
Status Update
No update yet.
Comments
hu...@littlerobots.nl
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 6492a281bd17da7537f453a3fc01d182c79a169e
Author: Louis Pullen-Freilich <lpf@google.com>
Date: Mon Jul 27 17:24:43 2020
Rename BottomNavigationItem parameters
text -> label to match the Material.io documentation and the `alwaysShowLabels` parameter
onSelected -> onSelect to match the tense we use in other components
activeColor -> selectedContentColor to be more clear about what this 'color' is, and match the selected state
inactiveColor -> unselectedContentColor to be more clear about waht this 'color' is, and match the not-selected state
Additionally fixes the ordering of parameters so that all required parameters are first, followed by the Modifier param.
Bug:
Test: ./gradlew updateApi
Relnote: "Renames BottomNavigationItem's `text` parameter to `label`, `onSelected` to `onSelect`, `activeColor` to `selectedContentColor`, `inactiveColor` to `unselectedContentColor` and updates parameter ordering to match guidelines."
Change-Id: Icb605dac9b76a0204a2a9d675530da8897f817d5
M ui/ui-material/api/current.txt
M ui/ui-material/api/public_plus_experimental_current.txt
M ui/ui-material/api/restricted_current.txt
M ui/ui-material/samples/src/main/java/androidx/compose/material/samples/BottomNavigationSamples.kt
M ui/ui-material/src/androidAndroidTest/kotlin/androidx/compose/material/BottomNavigationTest.kt
M ui/ui-material/src/commonMain/kotlin/androidx/compose/material/BottomNavigation.kt
https://android-review.googlesource.com/1373097
Branch: androidx-master-dev
commit 6492a281bd17da7537f453a3fc01d182c79a169e
Author: Louis Pullen-Freilich <lpf@google.com>
Date: Mon Jul 27 17:24:43 2020
Rename BottomNavigationItem parameters
text -> label to match the Material.io documentation and the `alwaysShowLabels` parameter
onSelected -> onSelect to match the tense we use in other components
activeColor -> selectedContentColor to be more clear about what this 'color' is, and match the selected state
inactiveColor -> unselectedContentColor to be more clear about waht this 'color' is, and match the not-selected state
Additionally fixes the ordering of parameters so that all required parameters are first, followed by the Modifier param.
Bug:
Test: ./gradlew updateApi
Relnote: "Renames BottomNavigationItem's `text` parameter to `label`, `onSelected` to `onSelect`, `activeColor` to `selectedContentColor`, `inactiveColor` to `unselectedContentColor` and updates parameter ordering to match guidelines."
Change-Id: Icb605dac9b76a0204a2a9d675530da8897f817d5
M ui/ui-material/api/current.txt
M ui/ui-material/api/public_plus_experimental_current.txt
M ui/ui-material/api/restricted_current.txt
M ui/ui-material/samples/src/main/java/androidx/compose/material/samples/BottomNavigationSamples.kt
M ui/ui-material/src/androidAndroidTest/kotlin/androidx/compose/material/BottomNavigationTest.kt
M ui/ui-material/src/commonMain/kotlin/androidx/compose/material/BottomNavigation.kt
il...@google.com
hu...@littlerobots.nl
Discussed further offline, onSelect should be renamed to onClick for consistency (with Tab and other components).
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit dfd1e72afa17243e42449e955f08213f0a4afcd4
Author: Louis Pullen-Freilich <lpf@google.com>
Date: Wed Sep 09 17:04:47 2020
Renames BottomNavigationItem's onSelect parameter to onClick for consistency with other components such as Tab
Bug:
Test: ./gradlew updateApi
Relnote: "Renames BottomNavigationItem's onSelect parameter to onClick"
Change-Id: I919251069ab307d1ed5c1c3fbf5a01bf77a85047
M compose/material/material/api/current.txt
M compose/material/material/api/public_plus_experimental_current.txt
M compose/material/material/api/restricted_current.txt
M compose/material/material/samples/src/main/java/androidx/compose/material/samples/BottomNavigationSamples.kt
M compose/material/material/src/androidAndroidTest/kotlin/androidx/compose/material/BottomNavigationScreenshotTest.kt
M compose/material/material/src/androidAndroidTest/kotlin/androidx/compose/material/BottomNavigationTest.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/BottomNavigation.kt
https://android-review.googlesource.com/1423472
Branch: androidx-master-dev
commit dfd1e72afa17243e42449e955f08213f0a4afcd4
Author: Louis Pullen-Freilich <lpf@google.com>
Date: Wed Sep 09 17:04:47 2020
Renames BottomNavigationItem's onSelect parameter to onClick for consistency with other components such as Tab
Bug:
Test: ./gradlew updateApi
Relnote: "Renames BottomNavigationItem's onSelect parameter to onClick"
Change-Id: I919251069ab307d1ed5c1c3fbf5a01bf77a85047
M compose/material/material/api/current.txt
M compose/material/material/api/public_plus_experimental_current.txt
M compose/material/material/api/restricted_current.txt
M compose/material/material/samples/src/main/java/androidx/compose/material/samples/BottomNavigationSamples.kt
M compose/material/material/src/androidAndroidTest/kotlin/androidx/compose/material/BottomNavigationScreenshotTest.kt
M compose/material/material/src/androidAndroidTest/kotlin/androidx/compose/material/BottomNavigationTest.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/BottomNavigation.kt
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 7039edc63e017c5b9433fe000922eb8f48597799
Author: Ian Lake <ilake@google.com>
Date: Fri Apr 26 11:49:47 2019
Don't override isEnabled() in FragmentManager back
Update the enabled state of the OnBackPressedCallback
when the back stack changes vs just-in-time in
isEnabled().
Test: tests still pass
BUG: 131416833
Change-Id: I40f266429c5dd3e2496decff50bf431d2c52924b
M fragment/src/main/java/androidx/fragment/app/FragmentManagerImpl.java
https://android-review.googlesource.com/952798
https://goto.google.com/android-sha1/7039edc63e017c5b9433fe000922eb8f48597799
Branch: androidx-master-dev
commit 7039edc63e017c5b9433fe000922eb8f48597799
Author: Ian Lake <ilake@google.com>
Date: Fri Apr 26 11:49:47 2019
Don't override isEnabled() in FragmentManager back
Update the enabled state of the OnBackPressedCallback
when the back stack changes vs just-in-time in
isEnabled().
Test: tests still pass
BUG: 131416833
Change-Id: I40f266429c5dd3e2496decff50bf431d2c52924b
M fragment/src/main/java/androidx/fragment/app/FragmentManagerImpl.java
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 561c9b796f43e1e8c500b856d4ea3726ca9bffd7
Author: Ian Lake <ilake@google.com>
Date: Fri Apr 26 17:52:10 2019
Mark callback isEnabled methods as final
Rather than require 'just in time' checks for
overriden isEnabled() methods, make both the
setter and getter final so that the dispatcher
can know ahead of time which callback is going
to be called when onBackPressed() is actually
triggered.
Test: ./gradlew checkApi
BUG: 131416833
Change-Id: I0d7e84d7d9888f558284cc1719774ccbbdbbc4d6
M activity/api/1.0.0-beta00.txt
M activity/api/current.txt
M activity/src/main/java/androidx/activity/OnBackPressedCallback.java
https://android-review.googlesource.com/952719
https://goto.google.com/android-sha1/561c9b796f43e1e8c500b856d4ea3726ca9bffd7
Branch: androidx-master-dev
commit 561c9b796f43e1e8c500b856d4ea3726ca9bffd7
Author: Ian Lake <ilake@google.com>
Date: Fri Apr 26 17:52:10 2019
Mark callback isEnabled methods as final
Rather than require 'just in time' checks for
overriden isEnabled() methods, make both the
setter and getter final so that the dispatcher
can know ahead of time which callback is going
to be called when onBackPressed() is actually
triggered.
Test: ./gradlew checkApi
BUG: 131416833
Change-Id: I0d7e84d7d9888f558284cc1719774ccbbdbbc4d6
M activity/api/1.0.0-beta00.txt
M activity/api/current.txt
M activity/src/main/java/androidx/activity/OnBackPressedCallback.java
Description
Version used: 1.0.0-alpha07
The OnBackPressedDispatcher should be able to tell at any point what OnBackPressedCallback is enabled or disabled without polling isEnabled() to get a just-in-time answer. This avoids the issue with the current onBackPressed() logic where the system doesn't know what onBackPressed() will do until you actually press the button.
This implies that all callbacks should be calling setEnabled() at the appropriate times to enable or disable them based on their own internal state changing. To enforce this behavior, setEnabled() and isEnabled() should be final.