Fixed
Status Update
No update yet.
Comments
il...@google.com
since these are in public API (:/) we need to do this in 1.2
be...@gmail.com
since it is already marked as deprecated, we can probably do it by now.
jb...@google.com
ap...@google.com
Opening diff shortly
il...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit d576cbdc911cba16638a44fd8223391a90a07ef7
Author: Mike Nakhimovich <digitalbuddha@users.noreply.github.com>
Date: Tue Aug 11 09:30:34 2020
[GH] Hide deprecated internal API.
## Proposed Changes
* `RoomDatabase.java` has protected `mCallbacks` field which is leaking in the API docs, we should @Hide it.
## Testing
Test: Ran unit tests locally
## Issues Fixed
Fixes: 76109329
This is an imported pull request fromhttps://github.com/androidx/androidx/pull/61 .
Resolves #61
Github-Pr-Head-Sha: 6440daa3a63752c7f9d5ba2a390248cd85bc634f
GitOrigin-RevId: fe92d8466a59b44b218b6ca3cbd57dcda17992f7
Change-Id: Id599cdf5b02b32bdae0166266fb7da967598fe92
A room/runtime/api/current.ignore
M room/runtime/api/current.txt
M room/runtime/api/public_plus_experimental_current.txt
M room/runtime/api/restricted_current.txt
M room/runtime/src/main/java/androidx/room/RoomDatabase.java
https://android-review.googlesource.com/1396827
Branch: androidx-master-dev
commit d576cbdc911cba16638a44fd8223391a90a07ef7
Author: Mike Nakhimovich <digitalbuddha@users.noreply.github.com>
Date: Tue Aug 11 09:30:34 2020
[GH] Hide deprecated internal API.
## Proposed Changes
* `RoomDatabase.java` has protected `mCallbacks` field which is leaking in the API docs, we should @Hide it.
## Testing
Test: Ran unit tests locally
## Issues Fixed
Fixes: 76109329
This is an imported pull request from
Resolves #61
Github-Pr-Head-Sha: 6440daa3a63752c7f9d5ba2a390248cd85bc634f
GitOrigin-RevId: fe92d8466a59b44b218b6ca3cbd57dcda17992f7
Change-Id: Id599cdf5b02b32bdae0166266fb7da967598fe92
A room/runtime/api/current.ignore
M room/runtime/api/current.txt
M room/runtime/api/public_plus_experimental_current.txt
M room/runtime/api/restricted_current.txt
M room/runtime/src/main/java/androidx/room/RoomDatabase.java
fe...@gmail.com
I have the same error on screen rotation:
Caused by: java.lang.IllegalStateException: unknown destination during restore: com.example.fcruzgo.servicioscasabolsa2.login:id/login_graph
In my case I add the graph from a dinamic module by reflection:
val navController: NavController = findNavController(R.id.nav_host_fragment)
val loginGraph = resources.getIdentifier("login_graph", "navigation", packageName + ".login")
val destinationGraph = navController.navInflater.inflate(loginGraph)
navController.graph.addDestination(destinationGraph)
then I use destinationGraph.id to navigate to the destination, in this case the login graph that containts the login fragment.
Caused by: java.lang.IllegalStateException: unknown destination during restore: com.example.fcruzgo.servicioscasabolsa2.login:id/login_graph
In my case I add the graph from a dinamic module by reflection:
val navController: NavController = findNavController(R.id.nav_host_fragment)
val loginGraph = resources.getIdentifier("login_graph", "navigation", packageName + ".login")
val destinationGraph = navController.navInflater.inflate(loginGraph)
navController.graph.addDestination(destinationGraph)
then I use destinationGraph.id to navigate to the destination, in this case the login graph that containts the login fragment.
fe...@gmail.com
I have the same error on screen rotation:
Caused by: java.lang.IllegalStateException: unknown destination during restore: com.example.fcruzgo.servicioscasabolsa2.login:id/login_graph
In my case I add the graph from a dinamic module by reflection:
val navController: NavController = findNavController(R.id.nav_host_fragment)
val loginGraph = resources.getIdentifier("login_graph", "navigation", packageName + ".login")
val destinationGraph = navController.navInflater.inflate(loginGraph)
navController.graph.addDestination(destinationGraph)
then I use destinationGraph.id to navigate to the destination, in this case the login graph that containts the login fragment.
Component used: Navigation
Version used: 2.1.0-alpha05
Caused by: java.lang.IllegalStateException: unknown destination during restore: com.example.fcruzgo.servicioscasabolsa2.login:id/login_graph
In my case I add the graph from a dinamic module by reflection:
val navController: NavController = findNavController(R.id.nav_host_fragment)
val loginGraph = resources.getIdentifier("login_graph", "navigation", packageName + ".login")
val destinationGraph = navController.navInflater.inflate(loginGraph)
navController.graph.addDestination(destinationGraph)
then I use destinationGraph.id to navigate to the destination, in this case the login graph that containts the login fragment.
Component used: Navigation
Version used: 2.1.0-alpha05
th...@gmail.com
I still get this issue with navigation library 2.2.0 even though it says it was fixed in 2.1.0
il...@google.com
Re #6, #7 - please file a new bug with a sample project that reproduces your issue.
vi...@gmail.com
Any updates on this bug? having this issue even after updating to 2.2.0
il...@google.com
Re #10 - We have not received any reproducible sample projects with 2.2.0 that exhibit this issue. Please file a new bug with a sample project if you have one and we can take a look.
Description
Version used: 1.0.0
Devices/Android versions reproduced on: Pixel 2 API 28
Upon screen rotation (or activity recreation), the app crashes after following a few simple steps.
Steps to reproduce (see screen recording) :
1. Click on List to navigate to ListFragment
2. Click on Main to navigate to MainFragment
3. Rotate screen
Navigation features :
- NavigationUI
- Conditional navigation
- Nested graphs
- Global action with popUpTo and popUpToInclusive