Create lint check for static final usages of JBUI.scale() [132441250]

Fixed

Feature Request

Reviewed (L1)

Status Update

No update yet.

Description

rp...@google.com

created issue #1

May 10, 2019 05:54PM

JBUI.scale() can return different value at different point in time during the same AS session, for example when the user changes themes, and change the default font size. This means that storing the result of JBUI.scale() in static (final) fields is incorrect.

We should investigate creating an AS specific lint check to detect/prevent these issues.

Comments

uc...@google.com <uc...@google.com> May 10, 2019 09:54PM

Assigned to rp...@google.com.

rp...@google.com <rp...@google.com> May 16, 2019 11:07PM

Reassigned to ku...@google.com.

vi...@google.com <vi...@google.com> Feb 18, 2020 05:13AM

Reassigned to an...@google.com.

tn...@google.com <tn...@google.com> Mar 24, 2020 05:36PM

Status: New

tn...@google.com <tn...@google.com> #2Mar 24, 2020 08:11PM

ag/10828683

Btw Renaud, seems like we shouldn't just flag final static usages; even storing these things in fields seems suspect to me (how do the fields get invalidated? Putting values into instance fields seems like a caching strategy that probably won't work.)

Message last modified on Mar 24, 2020 08:11PM

rp...@google.com <rp...@google.com> #3Mar 24, 2020 08:32PM

#2: Agreed.

tn...@google.com <tn...@google.com> Mar 27, 2020 04:17PM

Marked as fixed, reassigned to tn...@google.com.