Fixed
Status Update
Comments
cc...@google.com <cc...@google.com> #2
A couple of questions:
1. Have you saw crash in real device or only in simulators?
2. Do you use dynamic feature for language ID?
1. Have you saw crash in real device or only in simulators?
2. Do you use dynamic feature for language ID?
du...@google.com <du...@google.com> #3
Tested on Android 12 Emulator with custom executor, but cannot repro this issue.
ap...@google.com <ap...@google.com> #4
-
Second crash in the description is from a real device. Experienced it myself on two different Xiaomi phones, plus lots of crashes from users in the Google Play console.
-
Dynamic features are not used in the application.
As a wild guess, I have downgraded build tools from 31.0.0 to 30.0.3, compileSdk from 31 to 30, and moved all work with Language ID to the service in a separate process (just to be sure that crash can kill secondary process instead of main). This combination is in beta for 2 days by now and I don't see any SIGSEGV crashes.
Description
```
@RunWith(Parameterized::class)
class Benchmark(val size: Long) {
companion object {
@JvmStatic
@Parameterized.Parameters(name = "size={0}")
fun data(): Array<Long> {
return arrayOf(10, 100, 1000);
}
}
@get:Rule
val benchmarkRule = BenchmarkRule()
@Test
fun myBenchmark() {
benchmarkRule.measureRepeated {
for(i in 0 until size) {
// Do work
}
}
}
}
```
The output will look something like this
```
{ "results": [
{
"name": "myBenchmark[size=10]",
"classname": "com.test.benchmark.Benchmark",
"nanos": 279000,
"warmupIterations": 652,
"repeatIterations": 1,
"runs": [ ... ]
}
}
```
While it is possible to parse the parameterized parameter from the `name` String it is annoying to have to do so. It would be much easier for further post-processing of the results if these parameters had their own block, something like:
```
// Figuring out that the parameter is named `size` would be awesome, but probably not straight forward
{ "results": [
{
"name": "myBenchmark[size=10]",
"params": {
size: 10
}
"classname": "com.test.benchmark.Benchmark",
"nanos": 279000,
"warmupIterations": 652,
"repeatIterations": 1,
"runs": [ ... ]
}
}
// This kind of output would still be easier to parse programmatically and is similar to how the parameterized runner approaches it.
{ "results": [
{
"name": "myBenchmark[size=10]",
"params": [10], // Create a parameter array that uses the `{x}` indexes from JUnit.
"classname": "com.test.benchmark.Benchmark",
"nanos": 279000,
"warmupIterations": 652,
"repeatIterations": 1,
"runs": [ ... ]
}
}
```