Room InvalidateTracker internalInit attempts to set PRAGMA temp_store in transaction causing occasional crash [132602198]

Fixed

Bug

Status Update

No update yet.

Description

[Deleted User]

created issue #1

May 13, 2019 04:14PM

Component used: Room
Version used: 2.0.0
Devices/Android versions reproduced on: SDK 28

We occasionally get a crash from sqlite because something is attempting to set PRAGMA temp_store inside of a transaction. This is not allowed (

https://github.com/sqlite/sqlite/blob/08652b5ea00316539c913fc936e2966c8d58d283/src/pragma.c#L135). We tracked it down to inside of the Room InvalidationTracker class internalInit method (

https://android.googlesource.com/platform/frameworks/support/+/android-room-release/room/runtime/src/main/java/androidx/room/InvalidationTracker.java). We believe this doesn't always happen because it appears (based on a read of the sqlite code) that it depends on the number of connections present, which is often only one during initialization, but this isn't always the case.

We have worked around this by setting this exact PRAGMA in onConfigure, so that when Room goes to do it, there is no change and therefore doesn't validate sqlite's precondition.

It would be great if Room could update to not set this PRAGMA inside of a transaction.

Thanks for your help/consideration!

Comments

ap...@google.com <ap...@google.com> #2May 21, 2019 12:12AM

Project: platform/frameworks/support
Branch: androidx-main

commit 0154910724cdc44253af1d2f8cede76264783226
Author: Aurimas Liutikas <aurimas@google.com>
Date: Thu Jun 27 15:25:02 2024

Expand native target support for annotation and collection libraries

- Enable watchos and tvos download in importMaven
- Add support for watchos and tvos targets in AndroidXMultiplatformExtension
- Enable watchos and tvos in :annotation:annotation
- Enable linuxArm64, watchos, and tvos in :collection:collection

This work is required as we work towards setting up native stubs for
compose projects.

Test: ./gradlew collection:collection:publish
Bug: 349894318
Change-Id: Idfd1faa3a826bb91ee14722f7437bdcf99cf0018

M annotation/annotation/build.gradle
M buildSrc/private/src/main/kotlin/androidx/build/AndroidXMultiplatformExtension.kt
M buildSrc/public/src/main/kotlin/androidx/build/KmpPlatforms.kt
M collection/collection/build.gradle
M development/build_log_simplifier/messages.ignore
M development/importMaven/src/main/kotlin/androidx/build/importMaven/KmpConfig.kt

https://android-review.googlesource.com/3151736

da...@google.com <da...@google.com> May 21, 2019 12:12AM

Marked as fixed.

Issue 132602198

Description

Issue summary

Comments

ap...@google.com <ap...@google.com> #2May 21, 2019 12:12AM

da...@google.com <da...@google.com> May 21, 2019 12:12AM

Add comment

Issue metadata