Explicit Deeplink in notification cause app to reuse link when restarted from recent apps [132754763]

Fixed

Bug

Status Update

No update yet.

Description

ni...@gmail.com

created issue #1

May 15, 2019 01:32PM

Component used: Navigation
Version used: 2.1.0-alpha03
Devices/Android versions reproduced on: Pixel XL Android 9

If needed I'll build a sample project but it's a behavior I have on multiple project.
Assuming my app is a simple master list, that can navigate to a detail fragment.
It can receive firebase notification that will contains an id to an element of the list. I want that on notification click, it launch the detail fragment from graph.

Here's the code I use to generate the notification:
val notificationId = news.id.hashCode()
val pendingIntent = NavDeepLinkBuilder(context)
.setDestination(R.id.newsDetailFragment)
.setArguments(NewsDetailFragmentArgs(

news.id).toBundle())
.setGraph(R.navigation.nav_main)
.setComponentName(MainActivity::class.java)
.createPendingIntent()

val notification = NotificationCompat.Builder(context, "notifications")
.setSmallIcon(R.drawable.ic_notif)
.setContentTitle(news.title)
.setContentText(news.excerptToString)
.setContentIntent(pendingIntent)
.setAutoCancel(true)
.build()

val manager = NotificationManagerCompat.from(context)
manager.notify(notificationId, notification)

This code works well, the notification goes to the detail, using back button, i can come back to main screen then exits.
Except that when I use the "recent apps" button of the phone and brings the app again, instead of starting to main list scren, it brings back the detail screen (and pressing back display main list, then exits, and we can do it again and again...)
The only way to clear the start intent is to relaunch the app from the launcher instead.

I found a 2016 stackoverflow post about deeplink but I think that things weren't as we expect them to work today.

I don't think this should be the normal behavior, but if this is not a bug because of how deep link works, can you at least hint a solution on the

https://developer.android.com/guide/navigation/navigation-deep-link page ?

Tell me if you need a full sample or a video I will update the post.

Comments

il...@google.com <il...@google.com> #2May 24, 2019 11:07PM

Assigned to jb...@google.com.

Project: platform/frameworks/support
Branch: androidx-master-dev

commit c60f33e229e31ab328ef6b59dab63b264954831c
Author: Alexandre Elias <aelias@google.com>
Date: Fri Jul 10 16:23:09 2020

Semantics no-op cleanups

Partly in response to lmr's broad code review, I did a pass of
superficial API/implementation cleanup. The main changes are:

- I changed each Boolean SemanticsProperty where false is equivalent to
not being present to take "Unit" instead. This is conceptually
clearer: it avoids questions like "can I cancel out a semantics from a
merged child by setting it to false?" Because "property = Unit" looks
weird, I also changed the style of these to "property()".

- I moved the Semantics id generator closer to where it's used, in
SemanticsModifierCore. I made it internal and an AtomicInt.
(Note that integer ids are heavily used in the Android
AccessibilityNodeInfo APIs so I can't simply remove them entirely.)

- I deleted dead code. Some examples include SemanticsHintOverrides,
a public API not connected to anything, and SemanticsPropertyKey
merge() open method which is never called. (In both cases I have
a different plan in mind for accessibility.)

Fixes: 145951226
Fixes: 145955412
Test: existing tests
Relnote: "Single-value semantics properties now use a calling style.
For example, 'semantics { hidden = true }' is now written as:
'semantics { hidden() }'."

Change-Id: Ic1afd12ea22c926babc9662f1804d80b33aa0cfc

M ui/integration-tests/benchmark/src/androidTest/java/androidx/ui/benchmark/test/LayoutNodeModifierBenchmark.kt
M ui/ui-core/api/0.1.0-dev15.txt
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_0.1.0-dev15.txt
M ui/ui-core/api/restricted_current.txt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/graphics/vector/VectorTest.kt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/semantics/SemanticsTests.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidActuals.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeView.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeViewAccessibilityDelegateCompat.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidPopup.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/Expect.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsConfiguration.kt
D ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsHintOverrides.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsModifier.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsNode.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsOwner.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsWrapper.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/semantics/SemanticsProperties.kt
M ui/ui-foundation/api/0.1.0-dev15.txt
M ui/ui-foundation/api/current.txt
M ui/ui-foundation/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-foundation/api/public_plus_experimental_current.txt
M ui/ui-foundation/api/restricted_0.1.0-dev15.txt
M ui/ui-foundation/api/restricted_current.txt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Clickable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Dialog.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Scroller.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Selectable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Toggleable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/semantics/FoundationSemanticsProperties.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ButtonTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CardTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CheckboxScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/RadioButtonScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ScaffoldTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SnackbarTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SurfaceTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ripple/RippleIndicationTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/textfield/TextFieldScreenshotTest.kt
M ui/ui-material/src/main/java/androidx/ui/material/AppBar.kt
M ui/ui-material/src/main/java/androidx/ui/material/TextFieldImpl.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/AssertsTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/CallSemanticsActionTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ErrorMessagesTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/FindersTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/PrintToStringTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ScrollToTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/TextActionsTest.kt
M ui/ui-test/src/main/java/androidx/ui/test/Actions.kt
M ui/ui-test/src/main/java/androidx/ui/test/Filters.kt
M ui/ui-text/api/0.1.0-dev15.txt
M ui/ui-text/api/current.txt
M ui/ui-text/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-text/api/public_plus_experimental_current.txt
M ui/ui-text/api/restricted_0.1.0-dev15.txt
M ui/ui-text/api/restricted_current.txt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/CoreTextField.kt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/TextSemanticsProperties.kt

https://android-review.googlesource.com/1360099

jb...@google.com <jb...@google.com> May 28, 2019 08:13PM

Accepted by jb...@google.com.

ap...@google.com <ap...@google.com> #3May 29, 2019 04:40PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 50331e2040ea746f041a2ecee8466e826b0daed8
Author: jbwoods <jbwoods@google.com>
Date: Tue May 28 16:33:53 2019

Ensure the Activity Intent is handled only once

After we handle the Activity Intent, we should save the fact that it has
already been handled. This ensures we do not keep re-handling the intent
when the activity is restarted.

Test: Added test
BUG: 132754763
Change-Id: Ie4133eb3abfbfc00a1862f89019845a8bbc3123c

M navigation/runtime/src/androidTest/java/androidx/navigation/NavControllerActivityTest.kt
M navigation/runtime/src/main/java/androidx/navigation/NavController.java

https://android-review.googlesource.com/971168

https://goto.google.com/android-sha1/50331e2040ea746f041a2ecee8466e826b0daed8

jb...@google.com <jb...@google.com> #4May 29, 2019 04:43PM

Marked as fixed.

This has been fixed internally and will be available in the Navigation 2.1.0-alpha05 release.

br...@gmail.com <br...@gmail.com> #5Jun 13, 2019 02:50PM

I'm using navigation 2.1.0-alpha05 and I still see this issue, in some cases. It doesn't happen always. For example, if I click a deeplink in an email in the Gmail app, everything works great. My app loads, the deeplink intent is handled and I go to the right destination. I can then "go back" and then background the app. And when I bring it back to the foreground from the Recents screen, it loads up where I left off (i.e. the intent is NOT rehandled). However, if I use the Google Messages app and follow the exact same procedure, the issue listed in this ticket happens (i.e. the deeplink gets rehandled over and over, each time I foreground the app and I wind up on the deep link destination every time).

il...@google.com <il...@google.com> #6Jun 13, 2019 04:10PM

Re #5 - please create a new issue with a sample project that reproduces your issue.

br...@gmail.com <br...@gmail.com> #7Jun 13, 2019 06:56PM

RE: #6, done.

https://issuetracker.google.com/issues/135168817