Fixed
Status Update
Comments
il...@google.com <il...@google.com> #2
Hi. Thanks for reporting this. Fixed in alpha-04
jb...@google.com <jb...@google.com>
ap...@google.com <ap...@google.com> #3
Project: platform/frameworks/support
Branch: androidx-main
commit e782987543a9f8ccd485e970ddc74564b24378db
Author: Vighnesh Raut <vighnesh.raut13@gmail.com>
Date: Mon Jan 02 15:27:40 2023
fix: tab row crashes when only 1 tab is added
Bug: b/264018028
Test: Added unit test
Change-Id: I6381dbac304fc1d69d3708c6655f8b595668e93f
M tv/tv-material/src/androidTest/java/androidx/tv/material/TabRowTest.kt
M tv/tv-material/src/main/java/androidx/tv/material/TabRow.kt
https://android-review.googlesource.com/2373449
Branch: androidx-main
commit e782987543a9f8ccd485e970ddc74564b24378db
Author: Vighnesh Raut <vighnesh.raut13@gmail.com>
Date: Mon Jan 02 15:27:40 2023
fix: tab row crashes when only 1 tab is added
Bug:
Test: Added unit test
Change-Id: I6381dbac304fc1d69d3708c6655f8b595668e93f
M tv/tv-material/src/androidTest/java/androidx/tv/material/TabRowTest.kt
M tv/tv-material/src/main/java/androidx/tv/material/TabRow.kt
br...@gmail.com <br...@gmail.com> #5
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.tv:tv-material:1.0.0-alpha04
il...@google.com <il...@google.com> #6
Re #5 - please create a new issue with a sample project that reproduces your issue.
Description
Version used: 2.1.0-alpha03
Devices/Android versions reproduced on: Pixel XL Android 9
If needed I'll build a sample project but it's a behavior I have on multiple project.
Assuming my app is a simple master list, that can navigate to a detail fragment.
It can receive firebase notification that will contains an id to an element of the list. I want that on notification click, it launch the detail fragment from graph.
Here's the code I use to generate the notification:
val notificationId = news.id.hashCode()
val pendingIntent = NavDeepLinkBuilder(context)
.setDestination(R.id.newsDetailFragment)
.setArguments(NewsDetailFragmentArgs(
.setGraph(R.navigation.nav_main)
.setComponentName(MainActivity::class.java)
.createPendingIntent()
val notification = NotificationCompat.Builder(context, "notifications")
.setSmallIcon(R.drawable.ic_notif)
.setContentTitle(news.title)
.setContentText(news.excerptToString)
.setContentIntent(pendingIntent)
.setAutoCancel(true)
.build()
val manager = NotificationManagerCompat.from(context)
manager.notify(notificationId, notification)
This code works well, the notification goes to the detail, using back button, i can come back to main screen then exits.
Except that when I use the "recent apps" button of the phone and brings the app again, instead of starting to main list scren, it brings back the detail screen (and pressing back display main list, then exits, and we can do it again and again...)
The only way to clear the start intent is to relaunch the app from the launcher instead.
I found a 2016 stackoverflow post about deeplink but I think that things weren't as we expect them to work today.
I don't think this should be the normal behavior, but if this is not a bug because of how deep link works, can you at least hint a solution on the
Tell me if you need a full sample or a video I will update the post.