Fixed
Status Update
Comments
il...@google.com <il...@google.com> #2
since these are in public API (:/) we need to do this in 1.2
jb...@google.com <jb...@google.com>
ap...@google.com <ap...@google.com> #3
since it is already marked as deprecated, we can probably do it by now.
br...@gmail.com <br...@gmail.com> #5
Project: platform/frameworks/support
Branch: androidx-master-dev
commit d576cbdc911cba16638a44fd8223391a90a07ef7
Author: Mike Nakhimovich <digitalbuddha@users.noreply.github.com>
Date: Tue Aug 11 09:30:34 2020
[GH] Hide deprecated internal API.
## Proposed Changes
* `RoomDatabase.java` has protected `mCallbacks` field which is leaking in the API docs, we should @Hide it.
## Testing
Test: Ran unit tests locally
## Issues Fixed
Fixes: 76109329
This is an imported pull request fromhttps://github.com/androidx/androidx/pull/61 .
Resolves #61
Github-Pr-Head-Sha: 6440daa3a63752c7f9d5ba2a390248cd85bc634f
GitOrigin-RevId: fe92d8466a59b44b218b6ca3cbd57dcda17992f7
Change-Id: Id599cdf5b02b32bdae0166266fb7da967598fe92
A room/runtime/api/current.ignore
M room/runtime/api/current.txt
M room/runtime/api/public_plus_experimental_current.txt
M room/runtime/api/restricted_current.txt
M room/runtime/src/main/java/androidx/room/RoomDatabase.java
https://android-review.googlesource.com/1396827
Branch: androidx-master-dev
commit d576cbdc911cba16638a44fd8223391a90a07ef7
Author: Mike Nakhimovich <digitalbuddha@users.noreply.github.com>
Date: Tue Aug 11 09:30:34 2020
[GH] Hide deprecated internal API.
## Proposed Changes
* `RoomDatabase.java` has protected `mCallbacks` field which is leaking in the API docs, we should @Hide it.
## Testing
Test: Ran unit tests locally
## Issues Fixed
Fixes: 76109329
This is an imported pull request from
Resolves #61
Github-Pr-Head-Sha: 6440daa3a63752c7f9d5ba2a390248cd85bc634f
GitOrigin-RevId: fe92d8466a59b44b218b6ca3cbd57dcda17992f7
Change-Id: Id599cdf5b02b32bdae0166266fb7da967598fe92
A room/runtime/api/current.ignore
M room/runtime/api/current.txt
M room/runtime/api/public_plus_experimental_current.txt
M room/runtime/api/restricted_current.txt
M room/runtime/src/main/java/androidx/room/RoomDatabase.java
il...@google.com <il...@google.com> #6
Re #5 - please create a new issue with a sample project that reproduces your issue.
Description
Version used: 2.1.0-alpha03
Devices/Android versions reproduced on: Pixel XL Android 9
If needed I'll build a sample project but it's a behavior I have on multiple project.
Assuming my app is a simple master list, that can navigate to a detail fragment.
It can receive firebase notification that will contains an id to an element of the list. I want that on notification click, it launch the detail fragment from graph.
Here's the code I use to generate the notification:
val notificationId = news.id.hashCode()
val pendingIntent = NavDeepLinkBuilder(context)
.setDestination(R.id.newsDetailFragment)
.setArguments(NewsDetailFragmentArgs(
.setGraph(R.navigation.nav_main)
.setComponentName(MainActivity::class.java)
.createPendingIntent()
val notification = NotificationCompat.Builder(context, "notifications")
.setSmallIcon(R.drawable.ic_notif)
.setContentTitle(news.title)
.setContentText(news.excerptToString)
.setContentIntent(pendingIntent)
.setAutoCancel(true)
.build()
val manager = NotificationManagerCompat.from(context)
manager.notify(notificationId, notification)
This code works well, the notification goes to the detail, using back button, i can come back to main screen then exits.
Except that when I use the "recent apps" button of the phone and brings the app again, instead of starting to main list scren, it brings back the detail screen (and pressing back display main list, then exits, and we can do it again and again...)
The only way to clear the start intent is to relaunch the app from the launcher instead.
I found a 2016 stackoverflow post about deeplink but I think that things weren't as we expect them to work today.
I don't think this should be the normal behavior, but if this is not a bug because of how deep link works, can you at least hint a solution on the
Tell me if you need a full sample or a video I will update the post.