Fixed
Status Update
Comments
ap...@google.com <ap...@google.com> #2
Project: r8
Branch: master
commit 7c9574be6837c70f70e950acee6cf6ad3cb219c0
Author: Ian Zerny <zerny@google.com>
Date: Mon Sep 16 13:57:21 2019
Report the immediate reason for keeping methods.
This cl also allows non-null dependents when computing nodes for conditional
rules.
Bug: 133652414
Bug: 132828740
Bug: 139273002
Bug: 141093535
Change-Id: Ic40353f636f804e34ed509f5d3bea9bb3851cd5d
M src/main/java/com/android/tools/r8/shaking/Enqueuer.java
A src/test/java/com/android/tools/r8/shaking/keptgraph/KeptByConditionalOnMethodTest.java
M src/test/java/com/android/tools/r8/shaking/keptgraph/KeptByKeepClassMembersNonStaticTestRunner.java
M src/test/java/com/android/tools/r8/shaking/keptgraph/KeptSingletonIsNotCyclicTest.java
M src/test/java/com/android/tools/r8/shaking/whyareyoukeeping/WhyAreYouKeepingTest.java
M src/test/java/com/android/tools/r8/utils/graphinspector/GraphInspector.java
https://r8-review.googlesource.com/42902
Branch: master
commit 7c9574be6837c70f70e950acee6cf6ad3cb219c0
Author: Ian Zerny <zerny@google.com>
Date: Mon Sep 16 13:57:21 2019
Report the immediate reason for keeping methods.
This cl also allows non-null dependents when computing nodes for conditional
rules.
Bug: 133652414
Bug: 132828740
Bug: 139273002
Bug: 141093535
Change-Id: Ic40353f636f804e34ed509f5d3bea9bb3851cd5d
M src/main/java/com/android/tools/r8/shaking/Enqueuer.java
A src/test/java/com/android/tools/r8/shaking/keptgraph/KeptByConditionalOnMethodTest.java
M src/test/java/com/android/tools/r8/shaking/keptgraph/KeptByKeepClassMembersNonStaticTestRunner.java
M src/test/java/com/android/tools/r8/shaking/keptgraph/KeptSingletonIsNotCyclicTest.java
M src/test/java/com/android/tools/r8/shaking/whyareyoukeeping/WhyAreYouKeepingTest.java
M src/test/java/com/android/tools/r8/utils/graphinspector/GraphInspector.java
ch...@google.com <ch...@google.com>
ap...@google.com <ap...@google.com> #3
Project: r8
Branch: master
commit 9e4336d889e6b3950743f18cfa0cdb491f9d8cb5
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Tue Apr 14 14:35:48 2020
Trace dependent items from consequent root set with already satisfied precondition
Bug: 153858923, 153926577, 132828740
Change-Id: I334a36b053e044e1d60d5f257276f401a512455d
M src/main/java/com/android/tools/r8/graph/DexDefinitionSupplier.java
M src/main/java/com/android/tools/r8/shaking/Enqueuer.java
M src/main/java/com/android/tools/r8/shaking/RootSetBuilder.java
M src/test/java/com/android/tools/r8/shaking/ifrule/ConsequentRootSetWithSatisfiedDependentItemsTest.java
M src/test/java/com/android/tools/r8/shaking/ifrule/IfOnClassTest.java
https://r8-review.googlesource.com/50361
Branch: master
commit 9e4336d889e6b3950743f18cfa0cdb491f9d8cb5
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Tue Apr 14 14:35:48 2020
Trace dependent items from consequent root set with already satisfied precondition
Bug: 153858923, 153926577, 132828740
Change-Id: I334a36b053e044e1d60d5f257276f401a512455d
M src/main/java/com/android/tools/r8/graph/DexDefinitionSupplier.java
M src/main/java/com/android/tools/r8/shaking/Enqueuer.java
M src/main/java/com/android/tools/r8/shaking/RootSetBuilder.java
M src/test/java/com/android/tools/r8/shaking/ifrule/ConsequentRootSetWithSatisfiedDependentItemsTest.java
M src/test/java/com/android/tools/r8/shaking/ifrule/IfOnClassTest.java
ap...@google.com <ap...@google.com> #4
Project: r8
Branch: 2.0
commit f31fba8863759c2158502f8df5319294a0efc71b
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Wed Apr 15 11:29:39 2020
Version 2.0.66
Cherry pick: Trace dependent items from consequent root set with already satisfied precondition
CL:https://r8-review.googlesource.com/c/r8/+/50361
Cherry pick: Keep bridge and synthetic information for conditional rules
CL:https://r8-review.googlesource.com/c/r8/+/50363
Cherry pick: Add a regression test for inadequate tracing of consequent root set
CL:https://r8-review.googlesource.com/c/r8/+/50360
Cherry pick: Add a format diff script in tools
CL:https://r8-review.googlesource.com/c/r8/+/49823
Bug: 153858923, 153926577, 132828740
Change-Id: Ibaa1d5b757c605b8f50881bdbf3998a3c200f3e6
M src/main/java/com/android/tools/r8/Version.java
M src/main/java/com/android/tools/r8/graph/AccessFlags.java
M src/main/java/com/android/tools/r8/graph/MethodAccessFlags.java
M src/main/java/com/android/tools/r8/ir/optimize/Inliner.java
M src/main/java/com/android/tools/r8/shaking/Enqueuer.java
M src/main/java/com/android/tools/r8/shaking/RootSetBuilder.java
A src/test/java/com/android/tools/r8/shaking/ifrule/ConsequentRootSetWithSatisfiedDependentItemsTest.java
M src/test/java/com/android/tools/r8/shaking/ifrule/IfOnClassTest.java
A src/test/java/com/android/tools/r8/shaking/ifrule/NoLongerSyntheticConstructorTest.java
M src/test/java/com/android/tools/r8/transformers/ClassFileTransformer.java
A tools/fmt-diff.py
https://r8-review.googlesource.com/50371
Branch: 2.0
commit f31fba8863759c2158502f8df5319294a0efc71b
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Wed Apr 15 11:29:39 2020
Version 2.0.66
Cherry pick: Trace dependent items from consequent root set with already satisfied precondition
CL:
Cherry pick: Keep bridge and synthetic information for conditional rules
CL:
Cherry pick: Add a regression test for inadequate tracing of consequent root set
CL:
Cherry pick: Add a format diff script in tools
CL:
Bug: 153858923, 153926577, 132828740
Change-Id: Ibaa1d5b757c605b8f50881bdbf3998a3c200f3e6
M src/main/java/com/android/tools/r8/Version.java
M src/main/java/com/android/tools/r8/graph/AccessFlags.java
M src/main/java/com/android/tools/r8/graph/MethodAccessFlags.java
M src/main/java/com/android/tools/r8/ir/optimize/Inliner.java
M src/main/java/com/android/tools/r8/shaking/Enqueuer.java
M src/main/java/com/android/tools/r8/shaking/RootSetBuilder.java
A src/test/java/com/android/tools/r8/shaking/ifrule/ConsequentRootSetWithSatisfiedDependentItemsTest.java
M src/test/java/com/android/tools/r8/shaking/ifrule/IfOnClassTest.java
A src/test/java/com/android/tools/r8/shaking/ifrule/NoLongerSyntheticConstructorTest.java
M src/test/java/com/android/tools/r8/transformers/ClassFileTransformer.java
A tools/fmt-diff.py
Description
consequentRootSet.dependentNoShrinking.forEach(
(precondition, dependentItems) -> enqueueRootItems(dependentItems));