Investigate adding memory perf/memory pressure metrics [133147125]

Fixed

Feature Request

Status Update

No update yet.

Description

du...@google.com

created issue #1

May 20, 2019 04:51PM

Highly requested feature, but obviously comes with some caveats that might be more relevant to profiling / tracing than benchmarking.

We could take a look at how RxJava does this and see if their method works with benchmarking.

https://github.com/ReactiveX/RxJava/blob/2.x/src/jmh/java/io/reactivex/MemoryPerf.java

Comments

du...@google.com <du...@google.com> Aug 16, 2019 01:47AM

Reassigned to cc...@google.com.

cc...@google.com <cc...@google.com> #2Apr 25, 2023 12:06AM

Now that we have macrobench, this is easier to build there with trace based metrics.

+Nader asked me to look into this recently, and as it's extremely similar to the existing experimental memory counter metric, it makes sense to start experimenting here.

ap...@google.com <ap...@google.com> #3May 11, 2023 12:49AM

Project: platform/frameworks/support
Branch: androidx-main

commit 0e799e8ae83261d780dd5ac5407c797330d37c7c
Author: Chris Craik <ccraik@google.com>
Date: Mon Apr 24 16:59:21 2023

Add experimental MemoryUsageMetric

Test: MemoryUsageQueryTest
Test: TrivialStartupBenchmark # Compose
Bug: 133147125
Bug: 281749311
Relnote: Added experimental MemoryUsageMetric for tracking memory usage of a target application.

Also simplifies the similar MemoryCountersQuery.

Sample output:

```
TrivialStartupBenchmark_startup[startup=HOT,compilation=None]
memoryGpuLastKb min 13,648.0, median 13,808.0, max 13,808.0
memoryHeapSizeLastKb min 2,928.0, median 3,143.0, max 3,312.0
memoryRssAnonLastKb min 38,924.0, median 38,992.0, max 39,408.0
memoryRssFileLastKb min 78,068.0, median 78,670.0, max 78,740.0
timeToInitialDisplayMs min 28.0, median 41.1, max 49.1
```

Change-Id: I564531163aae2fa317d68a0676cfaf3068d12ee5

M benchmark/benchmark-common/src/main/java/androidx/benchmark/perfetto/PerfettoConfig.kt
M benchmark/benchmark-macro/api/public_plus_experimental_current.txt
M benchmark/benchmark-macro/src/androidTest/java/androidx/benchmark/macro/perfetto/MemoryCountersQueryTest.kt
A benchmark/benchmark-macro/src/androidTest/java/androidx/benchmark/macro/perfetto/MemoryUsageQueryTest.kt
M benchmark/benchmark-macro/src/main/java/androidx/benchmark/macro/Metric.kt
M benchmark/benchmark-macro/src/main/java/androidx/benchmark/macro/perfetto/MemoryCountersQuery.kt
A benchmark/benchmark-macro/src/main/java/androidx/benchmark/macro/perfetto/MemoryUsageQuery.kt
M testutils/testutils-macrobenchmark/src/main/java/androidx/testutils/MacrobenchUtils.kt

https://android-review.googlesource.com/2560174

ra...@google.com <ra...@google.com> May 11, 2023 05:20AM

Marked as fixed.

pr...@google.com <pr...@google.com> #4Jun 8, 2023 01:31AM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.benchmark:benchmark-common:1.2.0-alpha15
androidx.benchmark:benchmark-macro:1.2.0-alpha15

Issue 133147125