ShortcutInfoCompatSaver must not depend on ListenableFuture [133171974]

Obsolete

Internal Cleanup

Status Update

No update yet.

Description

al...@google.com

created issue #1

May 20, 2019 08:26PM

Guava's implementation of standalone ListenableFuture is problematic for developers and we are removing it from the Core library's dependencies. The ShortcutInfoCompatSaver class is the sole client of this dependency, and it is not actually used within the class itself as the only bundled implementation is a no-op.

Please remove the dependency on ListenableFuture to unblock Core 1.1.0 stable release.

Comments

al...@google.com <al...@google.com> #2May 20, 2019 08:40PM

Accepted by al...@google.com.

Or when changing to textView.textMetricsParamsCompat still crash.

private fun setAsyncText(textView: AppCompatTextView, text: String?) {
if (!text.isNullOrEmpty()) {
val textFuture = PrecomputedTextCompat.getTextFuture(text!!, textView.textMetricsParamsCompat, null)
textView.setTextFuture(textFuture) //Crash
}
}

al...@google.com <al...@google.com> Jun 19, 2019 07:55PM

Status: Won't Fix (Obsolete)

sh...@gmail.com <sh...@gmail.com> #3Mar 9, 2025 04:22AM

add this line :
textView.setLayoutDirection(ViewCompat.getLayoutDirection(textView));
before :
setTextFuture(....)

Issue 133171974

Description

Issue summary

Comments

al...@google.com <al...@google.com> #2May 20, 2019 08:40PM

al...@google.com <al...@google.com> Jun 19, 2019 07:55PM

sh...@gmail.com <sh...@gmail.com> #3Mar 9, 2025 04:22AM

Add comment

Issue metadata