Optional deep link parameters not supported in graph definition [133273839]

Fixed

Feature Request

Status Update

No update yet.

Description

as...@gmail.com

created issue #1

May 22, 2019 12:40PM

Component used: Navigation
Version used: 2.0.0

When defining a deep link in the navigation graph, and exact match is required for parameter matching, with no possibility of marking parameters as optional, thus if only one parameter is omitted, all parameters will fail to be parsed.

This is especially troublesome when supporting many parameters or query configurations, as it isn't feasible to define each variation of parameter configurations.

Expected behaviour would be for NavDeepLink to enclose each parameter with an optional regex group, or to check the NavArgument for nullability.

Comments

il...@google.com <il...@google.com> #2May 23, 2019 10:08PM

Assigned to jb...@google.com.

since these are in public API (:/) we need to do this in 1.2

ap...@google.com <ap...@google.com> #3Aug 5, 2019 08:55PM

since it is already marked as deprecated, we can probably do it by now.

jb...@google.com <jb...@google.com> #4Aug 5, 2019 09:44PM

Marked as fixed.

Opening diff shortly

b9...@gmail.com <b9...@gmail.com> #5Sep 23, 2019 06:47AM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit d576cbdc911cba16638a44fd8223391a90a07ef7
Author: Mike Nakhimovich <digitalbuddha@users.noreply.github.com>
Date: Tue Aug 11 09:30:34 2020

[GH] Hide deprecated internal API.

## Proposed Changes

* `RoomDatabase.java` has protected `mCallbacks` field which is leaking in the API docs, we should @Hide it.

## Testing

Test: Ran unit tests locally

## Issues Fixed

Fixes: 76109329

This is an imported pull request from

https://github.com/androidx/androidx/pull/61.

Resolves #61
Github-Pr-Head-Sha: 6440daa3a63752c7f9d5ba2a390248cd85bc634f
GitOrigin-RevId: fe92d8466a59b44b218b6ca3cbd57dcda17992f7

Change-Id: Id599cdf5b02b32bdae0166266fb7da967598fe92

A room/runtime/api/current.ignore
M room/runtime/api/current.txt
M room/runtime/api/public_plus_experimental_current.txt
M room/runtime/api/restricted_current.txt
M room/runtime/src/main/java/androidx/room/RoomDatabase.java

https://android-review.googlesource.com/1396827

il...@google.com <il...@google.com> #6Sep 23, 2019 05:55PM

Re #5 - please file a new bug with a sample project that reproduces your issue.

Issue 133273839