Fixed
Status Update
Comments
cc...@google.com <cc...@google.com> #2
Project: platform/frameworks/support
Branch: androidx-master-dev
commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019
Change the way to detect mismatch between POJO and query
This fixes cursor mismatch warnings with expandProjection.
Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt
https://android-review.googlesource.com/1123258
https://goto.google.com/android-sha1/b90079595f33f58fece04026a97faa0d243acdb1
Branch: androidx-master-dev
commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019
Change the way to detect mismatch between POJO and query
This fixes cursor mismatch warnings with expandProjection.
Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt
Description
05-22 22:30:07.284 6029 6029 D Benchmark: cpu4 CoreDir(online=true, availableFreqs=[300000, 345600, 422400, 499200, 576000, 652800, 729600, 806400, 902400, 979200, 1056000, 1132800, 1190400, 1267200, 1344000, 1420800, 1497600, 1574400, 1651200, 1728000, 1804800, 1881600, 1958400, 2035200, 2112000, 2208000, 2265600, 2323200, 2342400, 2361600, 2457600], currentMinFreq=300000)
Looking at logcat, libperfmgr seems to be trying to change clocks, but failing a lot of the time:
05-22 22:30:11.954 806 2521 W libperfmgr: Failed to write to node: /sys/devices/system/cpu/cpu0/cpufreq/scaling_max_freq with value: 1248000, fd: 10
05-22 22:30:11.954 806 2521 W libperfmgr: Failed to write to node: /sys/devices/system/cpu/cpu0/cpufreq/scaling_min_freq with value: 1900800, fd: 11
05-22 22:30:11.954 806 2521 W libperfmgr: Failed to write to node: /sys/devices/system/cpu/cpu4/cpufreq/scaling_min_freq with value: 2457600, fd: 13
05-22 22:30:12.454 806 2521 W libperfmgr: Failed to write to node: /sys/devices/system/cpu/cpu0/cpufreq/scaling_max_freq with value: 1248000, fd: 13
05-22 22:30:12.454 806 2521 W libperfmgr: Failed to write to node: /sys/devices/system/cpu/cpu0/cpufreq/scaling_min_freq with value: 1900800, fd: 14
05-22 22:30:12.454 806 2521 W libperfmgr: Failed to write to node: /sys/devices/system/cpu/cpu4/cpufreq/scaling_min_freq with value: 2457600, fd: 10
Talked with wvw@, who mentioned they disable based on cpu governor, specifically cpu 0:
On walleye, we disable CPU 0 without bothering to set the governor. Fix is simply to set the governor even though we'll be disabling the CPU.
This issue will likely affect any devices with big cores numerically after little cores in the core list.