Lint 26.5.0-beta02 DefaultLocale triggers on Kotlin's decapitalize method [133465551]

Fixed

Bug

Reviewed (L1)

Status Update

No update yet.

Description

va...@gmail.com

created issue #1

May 24, 2019 09:10AM

`"String".decapitalize()` triggers a DefaultLocale when using Lint 26.5.0-beta02

It wants to use the overload with a Locale but there isn't one defined in Kotlin as of Version 1.3.31. I think there is one starting with Kotlin 1.3.40 but that one hasn't been released yet.

The same happens for `capitalize()`

Comments

rm...@google.com <rm...@google.com> #2May 24, 2019 09:41AM

Assigned to tn...@google.com.

I'd like to fix the formatting but I can't edit my issue.

gh...@google.com <gh...@google.com> #3Jun 16, 2019 03:09AM

Reassigned to cm...@google.com.

Our team is also running into this because we use kotlin reflection to set up mock data for previews.

Can you suggest any workaround that we can apply locally to make layout lib include kotlin reflect until it is officially fixed? We are obviously including it as a build dependency but the layout lib preview doesn't pick it up for some reason.

cm...@google.com <cm...@google.com> #4Jun 17, 2019 10:45AM

Status: Won't Fix (Obsolete)

I do not see this issue in Electric Eel Beta 4, but I do see it in Flamingo Canary 6.

va...@gmail.com <va...@gmail.com> #5Jun 17, 2019 10:50AM

I do not see this issue in Electric Eel Beta 4, but I do see it in Flamingo Canary 6.

Is it with the very same project? I'm trying to rule out whether this is related to specific library/compiler versions.

Thanks!

eu...@gmail.com <eu...@gmail.com> #6Jun 17, 2019 12:16PM

Yes, that was with the same project. I can double check with the latest versions of each IDE and get back to you though.

cm...@google.com <cm...@google.com> #7Jun 17, 2019 01:03PM

Status: In Progress (Accepted) (reopened)

Correction: I was either mistaken before, or behavior has changed, but I am now getting the KotlinReflectionNotSupportedError issue for IDE compose previews in both EE Beta 5 and Flamingo Canary 8.

Kotlin 1.6.21 AGP 7.3

Message last modified on Jun 17, 2019 01:03PM

va...@gmail.com <va...@gmail.com> #8Jun 17, 2019 01:43PM

Hi, I'm also running into this issue in the preview with Kotlin 1.7.10 on Android Studio Dolphine (2021.3.1). Have you found a workaround in the meantime?

ja...@gmail.com <ja...@gmail.com> #9Jun 17, 2019 01:45PM

We're having the same issue on Android Studio Dolphin (2021.3.1) with Kotlin 1.6.10. The issue occurs when we use class references with kotlin reflect. The behavior can only be seen in Compose Preview's runtime. Everything works perfectly fine in android runtime, though.

cm...@google.com <cm...@google.com> #10Jun 17, 2019 01:45PM

Diego, this looks to be the same problem as issue 183889504, which was marked as Fixed. Are you aware of a fix? If that issue was incorrectly marked as fixed, feel free to bounce this one back to me. Thanks!

eu...@gmail.com <eu...@gmail.com> #11Jun 17, 2019 01:51PM

This looks to be the same as https://b.corp.google.com/issues/183889504 but it is not marked as fixed. We need to look into the dependencies because it looks like reflect might not be found by the deps in the model.

ta...@gmail.com <ta...@gmail.com> #12Jun 17, 2019 01:54PM

I'm pretty sure the failure is in locating kotlin.reflect.jvm.internal.ReflectionFactoryImpl in https://github.com/JetBrains/kotlin/blob/master/libraries/stdlib/jvm/runtime/kotlin/jvm/internal/Reflection.java.

That Class.forName should redirect to the "renamed" version that we move in the classpath to the layoutlib.internal so it loads the correct JVM version in https://github.com/JetBrains/kotlin/blob/master/core/reflection.jvm/src/kotlin/reflect/jvm/internal/ReflectionFactoryImpl.java.

ja...@gmail.com <ja...@gmail.com> #13Jun 17, 2019 01:56PM

The fix for this will be in a future canary of Flamingo.

eu...@gmail.com <eu...@gmail.com> #14Jun 17, 2019 03:05PM

I'm on Flamingo 2022.2.1 Patch 1 and this isn't working quite right...Preview does not report any errors specific to Kotlin reflection anymore and will generate a preview, but it's as if the kotlin-reflect library was never loaded. For instance, given sealed class Foo, calling Foo::class.isSealed in a Preview Composable returns false, yet returns true when called in a Composable running on a physical device.

ja...@gmail.com <ja...@gmail.com> #15Jun 20, 2019 06:34PM

I noticed this as well, and created this issue https://issuetracker.google.com/issues/281014894

cm...@google.com <cm...@google.com> #16Aug 30, 2019 12:07PM

It appears to still be an issue in Android Studio Koala | 2024.1.1 Patch 1

cm...@google.com <cm...@google.com> #17Sep 6, 2019 11:50AM

Marked as fixed.

Reopening as this doesn't seem to be fixed, according to multiple reports.

za...@gmail.com <za...@gmail.com> #18Sep 16, 2019 04:20AM

I presume this is related, if not I can open a new issue.

For context, BackgroundUploadState can be any sealed class or interface and the subclasses can be data objects, objects, or classes and it makes no difference.

With this in a PreviewParameterProvider: BackgroundUploadState::class.sealedSubclasses, I get the following Render Issue error:

java.lang.IndexOutOfBoundsException: Sequence doesn't contain element at index 0.
	at _layoutlib_._internal_.kotlin.sequences.SequencesKt___SequencesKt$elementAt$1.invoke(_Sequences.kt:35)
	at _layoutlib_._internal_.kotlin.sequences.SequencesKt___SequencesKt$elementAt$1.invoke(_Sequences.kt:35)
	at _layoutlib_._internal_.kotlin.sequences.SequencesKt___SequencesKt.elementAtOrElse(_Sequences.kt:55)
	at _layoutlib_._internal_.kotlin.sequences.SequencesKt___SequencesKt.elementAt(_Sequences.kt:35)
	at androidx.compose.ui.tooling.PreviewUtils_androidKt.getPreviewProviderParameters(PreviewUtils.android.kt:62)
	at androidx.compose.ui.tooling.ComposeViewAdapter$init$3$1$composable$1$1.invoke(ComposeViewAdapter.android.kt:508)
	at androidx.compose.ui.tooling.ComposeViewAdapter$init$3$1$composable$1$1.invoke(ComposeViewAdapter.android.kt:502)
	at androidx.compose.ui.tooling.ComposeViewAdapter$init$3$1.invoke(ComposeViewAdapter.android.kt:539)
	at androidx.compose.ui.tooling.ComposeViewAdapter$init$3$1.invoke(ComposeViewAdapter.android.kt:497)
	at androidx.compose.runtime.internal.ComposableLambdaImpl.invoke(ComposableLambda.jvm.kt:109)
	at androidx.compose.runtime.internal.ComposableLambdaImpl.invoke(ComposableLambda.jvm.kt:35)
	at androidx.compose.runtime.CompositionLocalKt.CompositionLocalProvider(CompositionLocal.kt:380)
	at androidx.compose.ui.tooling.InspectableKt.Inspectable(Inspectable.android.kt:61)
	at androidx.compose.ui.tooling.ComposeViewAdapter$WrapPreview$1.invoke(ComposeViewAdapter.android.kt:444)
	at androidx.compose.ui.tooling.ComposeViewAdapter$WrapPreview$1.invoke(ComposeViewAdapter.android.kt:443)
	at androidx.compose.runtime.internal.ComposableLambdaImpl.invoke(ComposableLambda.jvm.kt:109)
	at androidx.compose.runtime.internal.ComposableLambdaImpl.invoke(ComposableLambda.jvm.kt:35)
	at androidx.compose.runtime.CompositionLocalKt.CompositionLocalProvider(CompositionLocal.kt:380)
	at androidx.compose.ui.tooling.ComposeViewAdapter.WrapPreview(ComposeViewAdapter.android.kt:438)
	at androidx.compose.ui.tooling.ComposeViewAdapter.access$WrapPreview(ComposeViewAdapter.android.kt:124)
	at androidx.compose.ui.tooling.ComposeViewAdapter$init$3.invoke(ComposeViewAdapter.android.kt:497)
	at androidx.compose.ui.tooling.ComposeViewAdapter$init$3.invoke(ComposeViewAdapter.android.kt:494)
	at androidx.compose.runtime.internal.ComposableLambdaImpl.invoke(ComposableLambda.jvm.kt:109)
	at androidx.compose.runtime.internal.ComposableLambdaImpl.invoke(ComposableLambda.jvm.kt:35)
	at androidx.compose.ui.platform.ComposeView.Content(ComposeView.android.kt:441)
	at androidx.compose.ui.platform.AbstractComposeView$ensureCompositionCreated$1.invoke(ComposeView.android.kt:259)
	at androidx.compose.ui.platform.AbstractComposeView$ensureCompositionCreated$1.invoke(ComposeView.android.kt:258)
	at androidx.compose.runtime.internal.ComposableLambdaImpl.invoke(ComposableLambda.jvm.kt:109)
	at androidx.compose.runtime.internal.ComposableLambdaImpl.invoke(ComposableLambda.jvm.kt:35)
	at androidx.compose.runtime.CompositionLocalKt.CompositionLocalProvider(CompositionLocal.kt:380)
	at androidx.compose.ui.platform.CompositionLocalsKt.ProvideCommonCompositionLocals(CompositionLocals.kt:216)
	at androidx.compose.ui.platform.AndroidCompositionLocals_androidKt$ProvideAndroidCompositionLocals$3.invoke(AndroidCompositionLocals.android.kt:132)
	at androidx.compose.ui.platform.AndroidCompositionLocals_androidKt$ProvideAndroidCompositionLocals$3.invoke(AndroidCompositionLocals.android.kt:131)
	at androidx.compose.runtime.internal.ComposableLambdaImpl.invoke(ComposableLambda.jvm.kt:109)
	at androidx.compose.runtime.internal.ComposableLambdaImpl.invoke(ComposableLambda.jvm.kt:35)
	at androidx.compose.runtime.CompositionLocalKt.CompositionLocalProvider(CompositionLocal.kt:380)
	at androidx.compose.ui.platform.AndroidCompositionLocals_androidKt.ProvideAndroidCompositionLocals(AndroidCompositionLocals.android.kt:121)
	at androidx.compose.ui.platform.WrappedComposition$setContent$1$1$3.invoke(Wrapper.android.kt:155)
	at androidx.compose.ui.platform.WrappedComposition$setContent$1$1$3.invoke(Wrapper.android.kt:154)
	at androidx.compose.runtime.internal.ComposableLambdaImpl.invoke(ComposableLambda.jvm.kt:109)
	at androidx.compose.runtime.internal.ComposableLambdaImpl.invoke(ComposableLambda.jvm.kt:35)
	at androidx.compose.runtime.CompositionLocalKt.CompositionLocalProvider(CompositionLocal.kt:401)
	at androidx.compose.ui.platform.WrappedComposition$setContent$1$1.invoke(Wrapper.android.kt:154)
	at androidx.compose.ui.platform.WrappedComposition$setContent$1$1.invoke(Wrapper.android.kt:133)
	at androidx.compose.runtime.internal.ComposableLambdaImpl.invoke(ComposableLambda.jvm.kt:109)
	at androidx.compose.runtime.internal.ComposableLambdaImpl.invoke(ComposableLambda.jvm.kt:35)
	at androidx.compose.runtime.ActualJvm_jvmKt.invokeComposable(ActualJvm.jvm.kt:97)
	at androidx.compose.runtime.ComposerImpl.doCompose(Composer.kt:3593)
	at androidx.compose.runtime.ComposerImpl.composeContent$runtime_release(Composer.kt:3520)
	at androidx.compose.runtime.CompositionImpl.composeContent(Composition.kt:743)
	at androidx.compose.runtime.Recomposer.composeInitial$runtime_release(Recomposer.kt:1114)
	at androidx.compose.runtime.CompositionImpl.composeInitial(Composition.kt:649)
	at androidx.compose.runtime.CompositionImpl.setContent(Composition.kt:635)
	at androidx.compose.ui.platform.WrappedComposition$setContent$1.invoke(Wrapper.android.kt:133)
	at androidx.compose.ui.platform.WrappedComposition$setContent$1.invoke(Wrapper.android.kt:124)
	at androidx.compose.ui.platform.AndroidComposeView.setOnViewTreeOwnersAvailable(AndroidComposeView.android.kt:1597)
	at androidx.compose.ui.platform.WrappedComposition.setContent(Wrapper.android.kt:124)
	at androidx.compose.ui.platform.WrappedComposition.onStateChanged(Wrapper.android.kt:180)
	at androidx.lifecycle.LifecycleRegistry$ObserverWithState.dispatchEvent(LifecycleRegistry.jvm.kt:320)
	at androidx.lifecycle.LifecycleRegistry.addObserver(LifecycleRegistry.jvm.kt:198)
	at androidx.compose.ui.platform.WrappedComposition$setContent$1.invoke(Wrapper.android.kt:131)
	at androidx.compose.ui.platform.WrappedComposition$setContent$1.invoke(Wrapper.android.kt:124)
	at androidx.compose.ui.platform.AndroidComposeView.onAttachedToWindow(AndroidComposeView.android.kt:1678)
	at android.view.View.dispatchAttachedToWindow(View.java:21980)
	at android.view.ViewGroup.dispatchAttachedToWindow(ViewGroup.java:3490)
	at android.view.ViewGroup.dispatchAttachedToWindow(ViewGroup.java:3497)
	at android.view.ViewGroup.dispatchAttachedToWindow(ViewGroup.java:3497)
	at android.view.ViewGroup.dispatchAttachedToWindow(ViewGroup.java:3497)
	at android.view.ViewGroup.dispatchAttachedToWindow(ViewGroup.java:3497)
	at android.view.ViewGroup.dispatchAttachedToWindow(ViewGroup.java:3497)
	at android.view.AttachInfo_Accessor.setAttachInfo(AttachInfo_Accessor.java:51)
	at com.android.layoutlib.bridge.impl.RenderSessionImpl.inflate(RenderSessionImpl.java:372)
	at com.android.layoutlib.bridge.Bridge.createSession(Bridge.java:454)
	at com.android.tools.idea.layoutlib.LayoutLibrary.createSession(LayoutLibrary.java:120)
	at com.android.tools.rendering.RenderTask.createRenderSession(RenderTask.java:779)
	at com.android.tools.rendering.RenderTask.lambda$inflate$6(RenderTask.java:927)
	at com.android.tools.rendering.RenderExecutor$runAsyncActionWithTimeout$3.run(RenderExecutor.kt:204)
	at com.android.tools.rendering.RenderExecutor$PriorityRunnable.run(RenderExecutor.kt:321)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
	at java.base/java.lang.Thread.run(Unknown Source)

cm...@google.com <cm...@google.com> #19Sep 16, 2019 10:20AM

Great to see this is fixed, which Android Studio release will have the fix included? Will the fix make its way into 2024.2.2?

za...@gmail.com <za...@gmail.com> #20Sep 16, 2019 10:49AM

No, unfortunately the fix will not be available for 2024.2.2. The next Meerkat Canary will have the fix. It should also be available in the Nightly build already.

cm...@google.com <cm...@google.com> #21Sep 16, 2019 12:28PM

Thank you for your patience while our engineering team worked to resolve this issue. A fix for this issue is now available in:

Android Studio Meerkat | 2024.3.1 Canary 3
Android Gradle Plugin 8.9.0-alpha03

We encourage you to try the latest update.

If you notice further issues or have questions, please file a new bug report.

Thank you for taking the time to submit feedback — we really appreciate it!

jo...@monzo.com <jo...@monzo.com> #22Aug 26, 2020 01:11PM

I noticed this still triggers even when explicitly using the DefaultLocale e.g. val test = "Hello World".decapitalize(Locale.getDefault()). I've attached a sample project to reproduce this.

Kotlin version: 1.4.0

Build tools: 4.1.0-rc01

Linttest.zip

3.8 MB

Download

cm...@google.com <cm...@google.com> #23Aug 26, 2020 01:59PM

Status: Assigned (reopened)

I think this is fixed by https://android.googlesource.com/platform/tools/base/+/483600284e8d0b9fea8e72e2f13d472b71afdbfb which is in 4.2 canary 8.

I don't think this made the bar for backporting to 4.1 sadly, but I'll double check.

Message last modified on Aug 26, 2020 02:15PM

cm...@google.com <cm...@google.com> #24Aug 26, 2020 02:17PM

Matthew, what do you think?

gh...@google.com <gh...@google.com> #25Sep 9, 2020 10:12PM

Marked as fixed.

comment #24 No, unfortunately I don't think we should backport that to 4.1.

The issues will be fixed "properly" in 4.2 Canary 11, which bundles Kotlin compiler 1.4 and can resolve the new decapitalize method.

By the way, since Lint in AGP 4.1 bundles Kotlin compiler 1.3, I suspect there are other issues besides just this one. For example, Lint may fail to parse sources that use Kotlin 1.4 language features.

I wish Lint could run with the exact Kotlin compiler that is used to compile the project, but that is not how things work currently. And it may not be possible because the Kotlin compiler does not have a stable API. So in general it takes some time for Lint to integrate new Kotlin language versions.

Issue 133465551

Description

Issue summary

Comments

rm...@google.com <rm...@google.com> #2May 24, 2019 09:41AM

gh...@google.com <gh...@google.com> #3Jun 16, 2019 03:09AM

cm...@google.com <cm...@google.com> #4Jun 17, 2019 10:45AM

va...@gmail.com <va...@gmail.com> #5Jun 17, 2019 10:50AM

eu...@gmail.com <eu...@gmail.com> #6Jun 17, 2019 12:16PM

cm...@google.com <cm...@google.com> #7Jun 17, 2019 01:03PM

va...@gmail.com <va...@gmail.com> #8Jun 17, 2019 01:43PM

ja...@gmail.com <ja...@gmail.com> #9Jun 17, 2019 01:45PM

cm...@google.com <cm...@google.com> #10Jun 17, 2019 01:45PM

eu...@gmail.com <eu...@gmail.com> #11Jun 17, 2019 01:51PM

ta...@gmail.com <ta...@gmail.com> #12Jun 17, 2019 01:54PM

ja...@gmail.com <ja...@gmail.com> #13Jun 17, 2019 01:56PM

eu...@gmail.com <eu...@gmail.com> #14Jun 17, 2019 03:05PM

ja...@gmail.com <ja...@gmail.com> #15Jun 20, 2019 06:34PM

cm...@google.com <cm...@google.com> #16Aug 30, 2019 12:07PM

cm...@google.com <cm...@google.com> #17Sep 6, 2019 11:50AM

za...@gmail.com <za...@gmail.com> #18Sep 16, 2019 04:20AM

cm...@google.com <cm...@google.com> #19Sep 16, 2019 10:20AM

za...@gmail.com <za...@gmail.com> #20Sep 16, 2019 10:49AM

cm...@google.com <cm...@google.com> #21Sep 16, 2019 12:28PM

jo...@monzo.com <jo...@monzo.com> #22Aug 26, 2020 01:11PM

cm...@google.com <cm...@google.com> #23Aug 26, 2020 01:59PM

cm...@google.com <cm...@google.com> #24Aug 26, 2020 02:17PM

gh...@google.com <gh...@google.com> #25Sep 9, 2020 10:12PM

Add comment

Issue metadata