Fixed
Status Update
No update yet.
Comments
il...@google.com
jb...@google.com
This particular issue is caused because the app had an error.
Specifically, in the setupDeepLinks() method of NavigationExtensions.
After handling the deep link intent, the selected item should only be changed if it is not the current selected item. Reselecting dispatches setupItemReselected(), which pops the navigation graph back to the startDestination.
This can be fixed by checking is the selected item is equal to the current graph id.
if (navHostFragment.navController.handleDeepLink(intent)
&& selectedItemId !=navHostFragment.navController.graph.id ) {
this.selectedItemId =navHostFragment.navController.graph.id
}
I know this is wrong in our NavigationAdvancedSample and we have made a pull request in that repository for this change.
There was an underlying issue in how Navigation pops destinations from the back stack. What actually should have happened here is the deep link destination should have been popped, showing the home destination.
We will try to find the best way to address the underlying issue.
Specifically, in the setupDeepLinks() method of NavigationExtensions.
After handling the deep link intent, the selected item should only be changed if it is not the current selected item. Reselecting dispatches setupItemReselected(), which pops the navigation graph back to the startDestination.
This can be fixed by checking is the selected item is equal to the current graph id.
if (navHostFragment.navController.handleDeepLink(intent)
&& selectedItemId !=
this.selectedItemId =
}
I know this is wrong in our NavigationAdvancedSample and we have made a pull request in that repository for this change.
There was an underlying issue in how Navigation pops destinations from the back stack. What actually should have happened here is the deep link destination should have been popped, showing the home destination.
We will try to find the best way to address the underlying issue.
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 2946adae6fa98352f5a7634506875d4f7cda3fdd
Author: jbwoods <jbwoods@google.com>
Date: Thu Jun 06 15:38:37 2019
Ensure FragmentNavigator pops Fragments properly
If a navigate and pop are executed on a FragmentNavigator in the same
FragmentTransaction and the FragmentManager back stack is empty, the pop
never occurs, leaving the wrong destination on top of the back stack.
This results in the incorrect Fragment being shown at the end of the
transaction.
This change removes the check for the FragmentManager back stack being
empty and enqueues the pop anyway. The FragmentManager handles popping
with an empty backstack.
Test: Adjusted test, old test pass
BUG: 133832218
Change-Id: I3d33df940dc58b548c44f38b5433a4e938621527
M navigation/navigation-fragment/src/androidTest/java/androidx/navigation/fragment/FragmentNavigatorTest.kt
M navigation/navigation-fragment/src/main/java/androidx/navigation/fragment/FragmentNavigator.java
https://android-review.googlesource.com/979194
https://goto.google.com/android-sha1/2946adae6fa98352f5a7634506875d4f7cda3fdd
Branch: androidx-master-dev
commit 2946adae6fa98352f5a7634506875d4f7cda3fdd
Author: jbwoods <jbwoods@google.com>
Date: Thu Jun 06 15:38:37 2019
Ensure FragmentNavigator pops Fragments properly
If a navigate and pop are executed on a FragmentNavigator in the same
FragmentTransaction and the FragmentManager back stack is empty, the pop
never occurs, leaving the wrong destination on top of the back stack.
This results in the incorrect Fragment being shown at the end of the
transaction.
This change removes the check for the FragmentManager back stack being
empty and enqueues the pop anyway. The FragmentManager handles popping
with an empty backstack.
Test: Adjusted test, old test pass
BUG: 133832218
Change-Id: I3d33df940dc58b548c44f38b5433a4e938621527
M navigation/navigation-fragment/src/androidTest/java/androidx/navigation/fragment/FragmentNavigatorTest.kt
M navigation/navigation-fragment/src/main/java/androidx/navigation/fragment/FragmentNavigator.java
jb...@google.com
This has been fixed internally, and will be available in the Navigation 2.1.0-alpha06 release.
Description
Version used: 2.0.0, 2.1.0-alpha04
Devices/Android versions reproduced on: Any
If this is a bug in the library, we would appreciate if you could attach:
- Sample project to trigger the issue (please see attached project)
How to reproduce:
In the current project
1. Create a deeplink for navigation to About fragment ( adb shell am start -W -a android.intent.action.VIEW -d "
2. Click on one of the buttons (REGISTER or BLANK) in About fragment in order to navigate to corresponding destination.
3. App crashes with an exception: java.lang.IllegalArgumentException: navigation destination com.example.android.navigationadvancedsample:id/action_blankFragment is unknown to this NavController.