Fixed
Status Update
No update yet.
Comments
il...@google.com
ap...@google.com
We have logic to match exact deep links, since you have a path argument maybe this doesn't fall within that case.
But definitely feel free to upload a pull request with tests for this particular test case and we can work it out there.
vi...@gmail.com
I've created
I not sure about names picked for test functions.
il...@google.com
When will you have time to review this pull request? This change is important for our project.
vi...@gmail.com
Project: platform/frameworks/support
Branch: androidx-main
commit 4eea9cb436ba82a6f61ff97a69bbe7c393df0132
Author: Osip Fatkullin <osip.fatkullin@gmail.com>
Date: Thu Apr 15 09:34:16 2021
[GH] [Navigation] Make deep link path arguments to not include slash
## Proposed Changes
Slash is used for URI path splitting. Arguments should not include more than one path section.
I purpose to replace `(.+?)` with `([^/]+?)` in resulting regexp.
## Testing
Added corresponing tests to `NavDestinationAndroidTest`
Test: ./gradlew test connectedCheck
## Issues Fixed
Fixes: [https://issuetracker.google.com/issues/184072811 )
This is an imported pull request fromhttps://github.com/androidx/androidx/pull/153 .
Resolves #153
Github-Pr-Head-Sha: f16861bc1f6b0bbba03e752cc378aa795a8522e7
GitOrigin-RevId: 5da0cf583393bce4f68ab11305f1bab3d89f0480
Change-Id: I9f147ead04b611febd2a3214cf8736b5a9afcc65
M navigation/navigation-common/src/androidTest/java/androidx/navigation/NavDestinationAndroidTest.kt
M navigation/navigation-common/src/main/java/androidx/navigation/NavDeepLink.kt
https://android-review.googlesource.com/1676867
Branch: androidx-main
commit 4eea9cb436ba82a6f61ff97a69bbe7c393df0132
Author: Osip Fatkullin <osip.fatkullin@gmail.com>
Date: Thu Apr 15 09:34:16 2021
[GH] [Navigation] Make deep link path arguments to not include slash
## Proposed Changes
Slash is used for URI path splitting. Arguments should not include more than one path section.
I purpose to replace `(.+?)` with `([^/]+?)` in resulting regexp.
## Testing
Added corresponing tests to `NavDestinationAndroidTest`
Test: ./gradlew test connectedCheck
## Issues Fixed
Fixes: [
This is an imported pull request from
Resolves #153
Github-Pr-Head-Sha: f16861bc1f6b0bbba03e752cc378aa795a8522e7
GitOrigin-RevId: 5da0cf583393bce4f68ab11305f1bab3d89f0480
Change-Id: I9f147ead04b611febd2a3214cf8736b5a9afcc65
M navigation/navigation-common/src/androidTest/java/androidx/navigation/NavDestinationAndroidTest.kt
M navigation/navigation-common/src/main/java/androidx/navigation/NavDeepLink.kt
Description
Version used: 2.1.0-alpha04
Currently if you're writing a custom navigator that has a NavHost that can be defined in XML, there's no way to use the same app:navGraph that NavHostFragment is able to use since that attribute is defined in navigation-fragment.
Besides making it hard to pick another name for same functionality (fracturing how to use different navigators), it also makes it hard for Android Studio to fill in the 'Hosts' panel in the Navigation Editor correctly for custom navigators.