OnSharedPreferenceChangeListener is not called when removing entries [134197835]

Fixed

Bug

Status Update

No update yet.

Description

ru...@gmail.com

created issue #1

Jun 1, 2019 05:31PM

I registred an OnSharedPreferenceChangeListener like usual on the SharedPreference object. Upon calling remove(someKey), the listener did not get notified.

I looked into the implementation and this seems to be caused by line 288 in EncryptedSharedPreferences, where the key is removed from the list of keys that have changed.

If you need any more info or a sample, please ask.

Comments

jm...@google.com <jm...@google.com> #2Jun 21, 2019 12:47AM

Hi Ed, Thank you so much for these suggestions. I've been reviewing them and merging them in. Hopefully it should be live. I've included a thank you note too in the article.

co...@gmail.com <co...@gmail.com> #3Jun 18, 2020 05:38PM

Great! Thanks a lot, I'll look for the live updates soon!

ng...@gmail.com <ng...@gmail.com> #4Oct 23, 2020 12:35AM

Bug still exists in 1.0.0-rc03 and 1.1.0-alpha02. I would think the priority of this would be much higher given that reactive programming is basically standard nowadays.

hr...@gmail.com <hr...@gmail.com> #5Sep 9, 2021 12:13PM

Still exists in 1.1.0-alpha03. I guess it is not obvious behavior at all and violates the OnSharedPreferenceChangeListener.onSharedPreferenceChanged(SharedPreferences sharedPreferences, String key) contract: Called when a shared preference is changed, added, or removed.

bo...@google.com <bo...@google.com> Sep 9, 2021 12:18PM

Reassigned to bo...@google.com.

ni...@google.com <ni...@google.com> Mar 15, 2022 05:59PM

Status: New

da...@google.com <da...@google.com> #6Oct 17, 2022 10:29PM

Marked as fixed, reassigned to da...@google.com.

Fix will be live in the next alpha release