Fixed
Status Update
Comments
su...@google.com <su...@google.com> #2
Hi. Thanks for reporting this. Fixed in alpha-04
ma...@gmail.com <ma...@gmail.com> #3
Project: platform/frameworks/support
Branch: androidx-main
commit e782987543a9f8ccd485e970ddc74564b24378db
Author: Vighnesh Raut <vighnesh.raut13@gmail.com>
Date: Mon Jan 02 15:27:40 2023
fix: tab row crashes when only 1 tab is added
Bug: b/264018028
Test: Added unit test
Change-Id: I6381dbac304fc1d69d3708c6655f8b595668e93f
M tv/tv-material/src/androidTest/java/androidx/tv/material/TabRowTest.kt
M tv/tv-material/src/main/java/androidx/tv/material/TabRow.kt
https://android-review.googlesource.com/2373449
Branch: androidx-main
commit e782987543a9f8ccd485e970ddc74564b24378db
Author: Vighnesh Raut <vighnesh.raut13@gmail.com>
Date: Mon Jan 02 15:27:40 2023
fix: tab row crashes when only 1 tab is added
Bug:
Test: Added unit test
Change-Id: I6381dbac304fc1d69d3708c6655f8b595668e93f
M tv/tv-material/src/androidTest/java/androidx/tv/material/TabRowTest.kt
M tv/tv-material/src/main/java/androidx/tv/material/TabRow.kt
su...@google.com <su...@google.com> #5
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.tv:tv-material:1.0.0-alpha04
ko...@gmail.com <ko...@gmail.com> #6
Tested with 2.5.0. Have two workers, second one was added with `APPEND_OR_REPLACE` when first one is not cancelled or failed yet, means second was added to the chain. Then first fails, the second one won't run as new chain even it was specified with `APPEND_OR_REPLACE`. Is that expected behavior?
My scenario: I need to execute sequentially workers regardless of previous worker status if it was cancelled or failed.
Please advice.
My scenario: I need to execute sequentially workers regardless of previous worker status if it was cancelled or failed.
Please advice.
ra...@google.com <ra...@google.com> #7
That is expected. APPEND_OR_REPLACE
is only applied during enqueue. It does not change the semantics of a chain of requests.
Description
Version used: 2.0.1
Devices/Android versions reproduced on: 25
I have a work "queue" defined by some string(`uniqueWorkName`) where I schedule different types of workers with netowrk constraints using `enqueueUniqueWork` and `ExistingPolicy.APPEND`.
Some of the workers may get cancelled before they run(no internet and user canceled the request during this thime). After I cancel ANY worker in the "queue", I am no longer able to submit any work there since everything after this gets marked CANCELED immideately on enqueuing.
Judgingby the code in `EnqueueRunnable.enqueueWorkWithPrerequisites` it is intended behaviour, but it shouldn't be. Why is CANCELING(not FAIL'ing) some of the work in the unique chain of work cancels the rest of them? It should only do so on FAILED jobs!