Status Update
Comments
mi...@gtempaccount.com <mi...@gtempaccount.com> #2
Note that only target platforms supported by Compose (not to confuse with Compose Multiplatform) will be supported by the lifecycle-viewmodel-compose
artifact.
lf...@google.com <lf...@google.com> #3
Project: platform/frameworks/support
Branch: androidx-main
commit 74baccb421292733fcff3fc12335fdbfdb69ece0
Author: Marcello Galhardo <mgalhardo@google.com>
Date: Wed Mar 20 11:39:47 2024
Add `KClass` method variants on `viewmodel-compose`
RelNote: "Composable `viewModel` functions now accept a `KClass` for Multiplatform compatibility. The `Class` variants are kept for Android compatibility."
Test: N/A
Bug: 330323282
Change-Id: I59611546d8a5fd133694817837a986c029fcd47e
M lifecycle/lifecycle-viewmodel-compose/api/current.txt
M lifecycle/lifecycle-viewmodel-compose/api/restricted_current.txt
M lifecycle/lifecycle-viewmodel-compose/src/androidMain/kotlin/androidx/lifecycle/viewmodel/compose/ViewModel.android.kt
https://android-review.googlesource.com/3007640
Branch: androidx-main
commit 74baccb421292733fcff3fc12335fdbfdb69ece0
Author: Marcello Galhardo <mgalhardo@google.com>
Date: Wed Mar 20 11:39:47 2024
Add `KClass` method variants on `viewmodel-compose`
RelNote: "Composable `viewModel` functions now accept a `KClass` for Multiplatform compatibility. The `Class` variants are kept for Android compatibility."
Test: N/A
Bug: 330323282
Change-Id: I59611546d8a5fd133694817837a986c029fcd47e
M lifecycle/lifecycle-viewmodel-compose/api/current.txt
M lifecycle/lifecycle-viewmodel-compose/api/restricted_current.txt
M lifecycle/lifecycle-viewmodel-compose/src/androidMain/kotlin/androidx/lifecycle/viewmodel/compose/ViewModel.android.kt
ad...@gmail.com <ad...@gmail.com> #4
Project: platform/frameworks/support
Branch: androidx-main
commit 4beef5f6d988924a9640138db56f193301ef1329
Author: Marcello Galhardo <mgalhardo@google.com>
Date: Wed Mar 20 11:18:32 2024
Configure KMP on `viewmodel-compose`
* Setup the build scripts.
* Setup folder hierarchy.
Test: N/A
Bug: 330323282
Change-Id: Ib7d563bb2c2277b3c3a4167803ffdc9472dcfd5c
M docs-tip-of-tree/build.gradle
M lifecycle/lifecycle-viewmodel-compose/build.gradle
M lifecycle/lifecycle-viewmodel-compose/src/androidInstrumentedTest/AndroidManifest.xml
M lifecycle/lifecycle-viewmodel-compose/src/androidInstrumentedTest/kotlin/androidx/lifecycle/viewmodel/compose/SavedStateHandleSaverTest.kt
M lifecycle/lifecycle-viewmodel-compose/src/androidInstrumentedTest/kotlin/androidx/lifecycle/viewmodel/compose/TestViewModelClasses.kt
M lifecycle/lifecycle-viewmodel-compose/src/androidInstrumentedTest/kotlin/androidx/lifecycle/viewmodel/compose/ViewModelInAppCompatActivityTest.kt
M lifecycle/lifecycle-viewmodel-compose/src/androidInstrumentedTest/kotlin/androidx/lifecycle/viewmodel/compose/ViewModelInComponentActivityTest.kt
M lifecycle/lifecycle-viewmodel-compose/src/androidInstrumentedTest/kotlin/androidx/lifecycle/viewmodel/compose/ViewModelInFragmentTest.kt
M lifecycle/lifecycle-viewmodel-compose/src/androidInstrumentedTest/kotlin/androidx/lifecycle/viewmodel/compose/ViewModelTest.kt
M lifecycle/lifecycle-viewmodel-compose/src/androidMain/kotlin/androidx/lifecycle/viewmodel/compose/LocalViewModelStoreOwner.kt
M lifecycle/lifecycle-viewmodel-compose/src/androidMain/kotlin/androidx/lifecycle/viewmodel/compose/SavedStateHandleSaveableApi.kt
M lifecycle/lifecycle-viewmodel-compose/src/androidMain/kotlin/androidx/lifecycle/viewmodel/compose/SavedStateHandleSaver.kt
M lifecycle/lifecycle-viewmodel-compose/src/androidMain/kotlin/androidx/lifecycle/viewmodel/compose/ViewModel.kt
https://android-review.googlesource.com/3007634
Branch: androidx-main
commit 4beef5f6d988924a9640138db56f193301ef1329
Author: Marcello Galhardo <mgalhardo@google.com>
Date: Wed Mar 20 11:18:32 2024
Configure KMP on `viewmodel-compose`
* Setup the build scripts.
* Setup folder hierarchy.
Test: N/A
Bug: 330323282
Change-Id: Ib7d563bb2c2277b3c3a4167803ffdc9472dcfd5c
M docs-tip-of-tree/build.gradle
M lifecycle/lifecycle-viewmodel-compose/build.gradle
M lifecycle/lifecycle-viewmodel-compose/src/androidInstrumentedTest/AndroidManifest.xml
M lifecycle/lifecycle-viewmodel-compose/src/androidInstrumentedTest/kotlin/androidx/lifecycle/viewmodel/compose/SavedStateHandleSaverTest.kt
M lifecycle/lifecycle-viewmodel-compose/src/androidInstrumentedTest/kotlin/androidx/lifecycle/viewmodel/compose/TestViewModelClasses.kt
M lifecycle/lifecycle-viewmodel-compose/src/androidInstrumentedTest/kotlin/androidx/lifecycle/viewmodel/compose/ViewModelInAppCompatActivityTest.kt
M lifecycle/lifecycle-viewmodel-compose/src/androidInstrumentedTest/kotlin/androidx/lifecycle/viewmodel/compose/ViewModelInComponentActivityTest.kt
M lifecycle/lifecycle-viewmodel-compose/src/androidInstrumentedTest/kotlin/androidx/lifecycle/viewmodel/compose/ViewModelInFragmentTest.kt
M lifecycle/lifecycle-viewmodel-compose/src/androidInstrumentedTest/kotlin/androidx/lifecycle/viewmodel/compose/ViewModelTest.kt
M lifecycle/lifecycle-viewmodel-compose/src/androidMain/kotlin/androidx/lifecycle/viewmodel/compose/LocalViewModelStoreOwner.kt
M lifecycle/lifecycle-viewmodel-compose/src/androidMain/kotlin/androidx/lifecycle/viewmodel/compose/SavedStateHandleSaveableApi.kt
M lifecycle/lifecycle-viewmodel-compose/src/androidMain/kotlin/androidx/lifecycle/viewmodel/compose/SavedStateHandleSaver.kt
M lifecycle/lifecycle-viewmodel-compose/src/androidMain/kotlin/androidx/lifecycle/viewmodel/compose/ViewModel.kt
[Deleted User] <[Deleted User]>
jo...@gmail.com <jo...@gmail.com> #5
Project: platform/frameworks/support
Branch: androidx-main
commit 89a169b4573e1b28c7a5a73fd52d294bd0596a79
Author: Marcello Galhardo <mgalhardo@google.com>
Date: Wed Mar 20 11:33:41 2024
Move `LocalViewModelStoreOwner` to common on `viewmodel-compose`
Test: N/A
Bug: 330323282
Change-Id: I1ead8036fc8b3c49d5846c417d301f281cff90e3
M lifecycle/lifecycle-viewmodel-compose/src/androidMain/kotlin/androidx/lifecycle/viewmodel/compose/LocalViewModelStoreOwner.android.kt
A lifecycle/lifecycle-viewmodel-compose/src/commonMain/kotlin/androidx/lifecycle/viewmodel/compose/LocalViewModelStoreOwner.kt
A lifecycle/lifecycle-viewmodel-compose/src/desktopMain/kotlin/androidx/lifecycle/viewmodel/compose/LocalViewModelStoreOwner.desktop.kt
https://android-review.googlesource.com/3007638
Branch: androidx-main
commit 89a169b4573e1b28c7a5a73fd52d294bd0596a79
Author: Marcello Galhardo <mgalhardo@google.com>
Date: Wed Mar 20 11:33:41 2024
Move `LocalViewModelStoreOwner` to common on `viewmodel-compose`
Test: N/A
Bug: 330323282
Change-Id: I1ead8036fc8b3c49d5846c417d301f281cff90e3
M lifecycle/lifecycle-viewmodel-compose/src/androidMain/kotlin/androidx/lifecycle/viewmodel/compose/LocalViewModelStoreOwner.android.kt
A lifecycle/lifecycle-viewmodel-compose/src/commonMain/kotlin/androidx/lifecycle/viewmodel/compose/LocalViewModelStoreOwner.kt
A lifecycle/lifecycle-viewmodel-compose/src/desktopMain/kotlin/androidx/lifecycle/viewmodel/compose/LocalViewModelStoreOwner.desktop.kt
mo...@gmail.com <mo...@gmail.com> #6
Project: platform/frameworks/support
Branch: androidx-main
commit b8e5ea51a234c4cdbbed82e41f6ffd28f630dcd9
Author: Marcello Galhardo <mgalhardo@google.com>
Date: Wed Mar 20 11:22:15 2024
Rename source from `viewmodel-compose` to follow KMP convention
Test: N/A
Bug: 330323282
Change-Id: Ic417903127417b53f0888263a35fc5e4a82d57cc
M lifecycle/lifecycle-viewmodel-compose/src/androidInstrumentedTest/kotlin/androidx/lifecycle/viewmodel/compose/SavedStateHandleSaverTest.android.kt
M lifecycle/lifecycle-viewmodel-compose/src/androidInstrumentedTest/kotlin/androidx/lifecycle/viewmodel/compose/TestViewModelClasses.android.kt
M lifecycle/lifecycle-viewmodel-compose/src/androidInstrumentedTest/kotlin/androidx/lifecycle/viewmodel/compose/ViewModelInAppCompatActivityTest.android.kt
M lifecycle/lifecycle-viewmodel-compose/src/androidInstrumentedTest/kotlin/androidx/lifecycle/viewmodel/compose/ViewModelInComponentActivityTest.android.kt
M lifecycle/lifecycle-viewmodel-compose/src/androidInstrumentedTest/kotlin/androidx/lifecycle/viewmodel/compose/ViewModelInFragmentTest.android.kt
M lifecycle/lifecycle-viewmodel-compose/src/androidInstrumentedTest/kotlin/androidx/lifecycle/viewmodel/compose/ViewModelTest.android.kt
M lifecycle/lifecycle-viewmodel-compose/src/androidMain/kotlin/androidx/lifecycle/viewmodel/compose/LocalViewModelStoreOwner.android.kt
M lifecycle/lifecycle-viewmodel-compose/src/androidMain/kotlin/androidx/lifecycle/viewmodel/compose/SavedStateHandleSaveableApi.android.kt
M lifecycle/lifecycle-viewmodel-compose/src/androidMain/kotlin/androidx/lifecycle/viewmodel/compose/SavedStateHandleSaver.android.kt
M lifecycle/lifecycle-viewmodel-compose/src/androidMain/kotlin/androidx/lifecycle/viewmodel/compose/ViewModel.android.kt
https://android-review.googlesource.com/3007635
Branch: androidx-main
commit b8e5ea51a234c4cdbbed82e41f6ffd28f630dcd9
Author: Marcello Galhardo <mgalhardo@google.com>
Date: Wed Mar 20 11:22:15 2024
Rename source from `viewmodel-compose` to follow KMP convention
Test: N/A
Bug: 330323282
Change-Id: Ic417903127417b53f0888263a35fc5e4a82d57cc
M lifecycle/lifecycle-viewmodel-compose/src/androidInstrumentedTest/kotlin/androidx/lifecycle/viewmodel/compose/SavedStateHandleSaverTest.android.kt
M lifecycle/lifecycle-viewmodel-compose/src/androidInstrumentedTest/kotlin/androidx/lifecycle/viewmodel/compose/TestViewModelClasses.android.kt
M lifecycle/lifecycle-viewmodel-compose/src/androidInstrumentedTest/kotlin/androidx/lifecycle/viewmodel/compose/ViewModelInAppCompatActivityTest.android.kt
M lifecycle/lifecycle-viewmodel-compose/src/androidInstrumentedTest/kotlin/androidx/lifecycle/viewmodel/compose/ViewModelInComponentActivityTest.android.kt
M lifecycle/lifecycle-viewmodel-compose/src/androidInstrumentedTest/kotlin/androidx/lifecycle/viewmodel/compose/ViewModelInFragmentTest.android.kt
M lifecycle/lifecycle-viewmodel-compose/src/androidInstrumentedTest/kotlin/androidx/lifecycle/viewmodel/compose/ViewModelTest.android.kt
M lifecycle/lifecycle-viewmodel-compose/src/androidMain/kotlin/androidx/lifecycle/viewmodel/compose/LocalViewModelStoreOwner.android.kt
M lifecycle/lifecycle-viewmodel-compose/src/androidMain/kotlin/androidx/lifecycle/viewmodel/compose/SavedStateHandleSaveableApi.android.kt
M lifecycle/lifecycle-viewmodel-compose/src/androidMain/kotlin/androidx/lifecycle/viewmodel/compose/SavedStateHandleSaver.android.kt
M lifecycle/lifecycle-viewmodel-compose/src/androidMain/kotlin/androidx/lifecycle/viewmodel/compose/ViewModel.android.kt
am...@gmail.com <am...@gmail.com> #7
Project: platform/frameworks/support
Branch: androidx-main
commit 37991db14175338fe6beac23bae696090689d418
Author: Marcello Galhardo <mgalhardo@google.com>
Date: Wed Mar 20 11:24:42 2024
Update Compose UI and Runtime to 1.6.0 in `viewmodel-compose`
* Required to use the `Composable` annotation from the common source set.
Test: N/A
Bug: 330323282
Change-Id: I879d9bd2c904524f157cf24068130d7cfc1cce45
M lifecycle/lifecycle-viewmodel-compose/build.gradle
https://android-review.googlesource.com/3007636
Branch: androidx-main
commit 37991db14175338fe6beac23bae696090689d418
Author: Marcello Galhardo <mgalhardo@google.com>
Date: Wed Mar 20 11:24:42 2024
Update Compose UI and Runtime to 1.6.0 in `viewmodel-compose`
* Required to use the `Composable` annotation from the common source set.
Test: N/A
Bug: 330323282
Change-Id: I879d9bd2c904524f157cf24068130d7cfc1cce45
M lifecycle/lifecycle-viewmodel-compose/build.gradle
vi...@gmail.com <vi...@gmail.com> #8
Comment has been deleted.
ru...@gmail.com <ru...@gmail.com> #9
Project: platform/frameworks/support
Branch: androidx-main
commit 61e7561c841336e65be6c18fa7fd8d8b003fb2a4
Author: Marcello Galhardo <mgalhardo@google.com>
Date: Wed Mar 20 11:26:09 2024
Move dependencies to `commonMain` on `viewmodel-compose`
Test: N/A
Bug: 330323282
Change-Id: I9ccddf090462f16a71dabe9a0f687c7e91ffb5f6
M lifecycle/lifecycle-viewmodel-compose/build.gradle
https://android-review.googlesource.com/3007637
Branch: androidx-main
commit 61e7561c841336e65be6c18fa7fd8d8b003fb2a4
Author: Marcello Galhardo <mgalhardo@google.com>
Date: Wed Mar 20 11:26:09 2024
Move dependencies to `commonMain` on `viewmodel-compose`
Test: N/A
Bug: 330323282
Change-Id: I9ccddf090462f16a71dabe9a0f687c7e91ffb5f6
M lifecycle/lifecycle-viewmodel-compose/build.gradle
at...@gmail.com <at...@gmail.com> #10
Project: platform/frameworks/support
Branch: androidx-main
commit a1f7b7585088dd00015c61bfa10053e76f77cc85
Author: Marcello Galhardo <mgalhardo@google.com>
Date: Wed Mar 20 11:41:44 2024
Use `ViewModelProvider.create` method on `viewmodel-compose`
Test: N/A
Bug: 330323282
Change-Id: I056165d298392ddae01f170bd7912196207c30ea
M lifecycle/lifecycle-viewmodel-compose/src/androidMain/kotlin/androidx/lifecycle/viewmodel/compose/ViewModel.android.kt
https://android-review.googlesource.com/3007641
Branch: androidx-main
commit a1f7b7585088dd00015c61bfa10053e76f77cc85
Author: Marcello Galhardo <mgalhardo@google.com>
Date: Wed Mar 20 11:41:44 2024
Use `ViewModelProvider.create` method on `viewmodel-compose`
Test: N/A
Bug: 330323282
Change-Id: I056165d298392ddae01f170bd7912196207c30ea
M lifecycle/lifecycle-viewmodel-compose/src/androidMain/kotlin/androidx/lifecycle/viewmodel/compose/ViewModel.android.kt
Description
AI-191.7141.44.36.5599242, JRE 1.8.0_202-release-1483-b03x64 JetBrains s.r.o, OS Windows 7(amd64) v6.1 Service Pack 1, screens 1920x1080, 1920x1080
AS: 3.6 Canary 2; Kotlin plugin: 1.3.31-release-Studio3.5-1; Android Gradle Plugin: 3.6.0-alpha02; Gradle: 5.4.1; NDK: from local.properties: (not specified), latest from SDK: (not found); LLDB: pinned revision 3.1 not found, latest from SDK: (package not found); CMake: from local.properties: (not specified), latest from SDK: (not found), from PATH: (not found)
After updating platform-tools to 29.0.0 adb always crashes when the emulator is running